media: Implement StreamParser::MarkEndOfStream for non-destructive HLS flush [chromium/src : main]

0 views
Skip to first unread message

Ted (Chromium) Meyer (Gerrit)

unread,
Jun 26, 2026, 9:36:28 PM (2 days ago) Jun 26
to Lance Bai, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Lance Bai

Ted (Chromium) Meyer voted and added 1 comment

Votes added by Ted (Chromium) Meyer

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Ted (Chromium) Meyer . resolved

I think this is pretty good. Would you also be willing to add a test for it to //media/filters/chunk_demuxer_unittest.cc

I think all you'd need to do is take the last media segment ts file from the bug, add it to //media/test/data (should be fine, it's not copyrighted), and then append it all in the test and assert that the buffered ranges are correct. If I'm correct, the old broken ranges should be "[0 -> 1.875]" and the new, correct ranges should be "[0 -> 2.170655]".

Open in Gerrit

Related details

Attention is currently required from:
  • Lance Bai
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I17ecffdc50d5a7538a92642b055b2c5cc220c07b
Gerrit-Change-Number: 8006487
Gerrit-PatchSet: 1
Gerrit-Owner: Lance Bai <lanc...@gmail.com>
Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
Gerrit-Attention: Lance Bai <lanc...@gmail.com>
Gerrit-Comment-Date: Sat, 27 Jun 2026 01:36:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Ted (Chromium) Meyer (Gerrit)

unread,
Jun 26, 2026, 9:37:59 PM (2 days ago) Jun 26
to Lance Bai, Eugene Zemtsov, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Eugene Zemtsov and Lance Bai

Ted (Chromium) Meyer added 1 comment

Patchset-level comments
Ted (Chromium) Meyer . resolved

Also you're external, so you'll need a second +1. Dale's out so over to Eugene too.

Open in Gerrit

Related details

Attention is currently required from:
  • Eugene Zemtsov
  • Lance Bai
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I17ecffdc50d5a7538a92642b055b2c5cc220c07b
Gerrit-Change-Number: 8006487
Gerrit-PatchSet: 1
Gerrit-Owner: Lance Bai <lanc...@gmail.com>
Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
Gerrit-Attention: Eugene Zemtsov <eug...@chromium.org>
Gerrit-Attention: Lance Bai <lanc...@gmail.com>
Gerrit-Comment-Date: Sat, 27 Jun 2026 01:37:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Lance Bai (Gerrit)

unread,
Jun 27, 2026, 9:53:09 AM (yesterday) Jun 27
to SLSA Policy Verification Service, Eugene Zemtsov, Ted (Chromium) Meyer, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Eugene Zemtsov and Ted (Chromium) Meyer

Lance Bai added 1 comment

Patchset-level comments
Ted (Chromium) Meyer . resolved

I think this is pretty good. Would you also be willing to add a test for it to //media/filters/chunk_demuxer_unittest.cc

I think all you'd need to do is take the last media segment ts file from the bug, add it to //media/test/data (should be fine, it's not copyrighted), and then append it all in the test and assert that the buffered ranges are correct. If I'm correct, the old broken ranges should be "[0 -> 1.875]" and the new, correct ranges should be "[0 -> 2.170655]".

Lance Bai

thanks, I have added the asset and the test case ChunkDemuxerTest.HlsEndOfStreamFlush. please review them when available.

Open in Gerrit

Related details

Attention is currently required from:
  • Eugene Zemtsov
  • Ted (Chromium) Meyer
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I17ecffdc50d5a7538a92642b055b2c5cc220c07b
Gerrit-Change-Number: 8006487
Gerrit-PatchSet: 3
Gerrit-Owner: Lance Bai <lanc...@gmail.com>
Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
Gerrit-Attention: Ted (Chromium) Meyer <tmath...@chromium.org>
Gerrit-Attention: Eugene Zemtsov <eug...@chromium.org>
Gerrit-Comment-Date: Sat, 27 Jun 2026 13:52:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ted (Chromium) Meyer <tmath...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages