[ios] Mitigate OOM by adding autorelease [chromium/src : main]
1 view
Skip to first unread message
Federica Germinario (Gerrit)
Dec 23, 2025, 12:06:19 PM (4 days ago) Dec 23
to Asami Doi, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, rginda...@chromium.org
Attention needed from Asami Doi
Federica Germinario voted and added 1 comment![]( "Open in Gerrit")
Votes added by Federica Germinario
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Asami Doi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Asami Doi (Gerrit)
Dec 24, 2025, 4:51:59 AM (4 days ago) Dec 24
to Federica Germinario, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, rginda...@chromium.org
Asami Doi voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 24, 2025, 4:54:57 AM (4 days ago) Dec 24
to Asami Doi, Federica Germinario, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, rginda...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[ios] Mitigate OOM by adding autorelease
This CL mitigates OOM by adding autorelease to where
UIGraphicsImageRenderer is called in SnapshotGenerator.
Investigation doc:
https://docs.google.com/document/d/1D1WcI1CkWLIUQw-DsoNPoj88IyENkaScFYFeHPekWRE/edit?usp=sharing&resourcekey=0-GXYv2VTqAu9Jut6un-6g2g
Change-Id: I4a449f8f83eb5ae46c01d2c5e42de219bfc20856
Commit-Queue: Asami Doi <asam...@chromium.org>
Reviewed-by: Federica Germinario <fede...@google.com>
Cr-Commit-Position: refs/heads/main@{#1562454}
Files:
- M ios/chrome/browser/snapshots/model/snapshot_generator.swift
Change size: M
Delta: 1 file changed, 50 insertions(+), 44 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Federica Germinario
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages