[ios] Mitigate OOM by adding autorelease [chromium/src : main]

1 view
Skip to first unread message

Federica Germinario (Gerrit)

unread,
Dec 23, 2025, 12:06:19 PM (4 days ago) Dec 23
to Asami Doi, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, rginda...@chromium.org
Attention needed from Asami Doi

Federica Germinario voted and added 1 comment

Votes added by Federica Germinario

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 8 (Latest):
Federica Germinario . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Asami Doi
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4a449f8f83eb5ae46c01d2c5e42de219bfc20856
Gerrit-Change-Number: 7309408
Gerrit-PatchSet: 8
Gerrit-Owner: Asami Doi <asam...@chromium.org>
Gerrit-Reviewer: Asami Doi <asam...@chromium.org>
Gerrit-Reviewer: Federica Germinario <fede...@google.com>
Gerrit-Attention: Asami Doi <asam...@chromium.org>
Gerrit-Comment-Date: Tue, 23 Dec 2025 17:06:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Asami Doi (Gerrit)

unread,
Dec 24, 2025, 4:51:59 AM (4 days ago) Dec 24
to Federica Germinario, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, rginda...@chromium.org

Asami Doi voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4a449f8f83eb5ae46c01d2c5e42de219bfc20856
Gerrit-Change-Number: 7309408
Gerrit-PatchSet: 8
Gerrit-Owner: Asami Doi <asam...@chromium.org>
Gerrit-Reviewer: Asami Doi <asam...@chromium.org>
Gerrit-Reviewer: Federica Germinario <fede...@google.com>
Gerrit-Comment-Date: Wed, 24 Dec 2025 09:51:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Dec 24, 2025, 4:54:57 AM (4 days ago) Dec 24
to Asami Doi, Federica Germinario, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, rginda...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[ios] Mitigate OOM by adding autorelease

This CL mitigates OOM by adding autorelease to where
UIGraphicsImageRenderer is called in SnapshotGenerator.

Investigation doc:
https://docs.google.com/document/d/1D1WcI1CkWLIUQw-DsoNPoj88IyENkaScFYFeHPekWRE/edit?usp=sharing&resourcekey=0-GXYv2VTqAu9Jut6un-6g2g
Change-Id: I4a449f8f83eb5ae46c01d2c5e42de219bfc20856
Commit-Queue: Asami Doi <asam...@chromium.org>
Reviewed-by: Federica Germinario <fede...@google.com>
Cr-Commit-Position: refs/heads/main@{#1562454}
Files:
  • M ios/chrome/browser/snapshots/model/snapshot_generator.swift
Change size: M
Delta: 1 file changed, 50 insertions(+), 44 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Federica Germinario
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4a449f8f83eb5ae46c01d2c5e42de219bfc20856
Gerrit-Change-Number: 7309408
Gerrit-PatchSet: 9
Gerrit-Owner: Asami Doi <asam...@chromium.org>
Gerrit-Reviewer: Asami Doi <asam...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Federica Germinario <fede...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages