[//media] Split out VideoFrame::CreateFrameFor{GMB, MappableSI}Internal [chromium/src : main]
0 views
Skip to first unread message
Colin Blundell (Gerrit)
Jul 7, 2025, 12:04:11 PM7/7/25
to Colin Blundell, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mfoltz...@chromium.org
Attention needed from Vasiliy Telezhnikov
Colin Blundell voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vasiliy Telezhnikov (Gerrit)
Jul 7, 2025, 12:34:10 PM7/7/25
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mfoltz...@chromium.org
Attention needed from Colin Blundell
Vasiliy Telezhnikov voted and added 3 comments![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Code-Review | +1 |
3 comments
Patchset-level comments
File media/base/video_frame.cc
Line 403, Patchset 3 (Latest):
const auto gmb_handle = shared_image->CloneGpuMemoryBufferHandle();Vasiliy Telezhnikov . unresolved
(maybe in a follow-up) nit: I know this was this way before, but it's quite unfortunate to clone handle for no reason. Could you add a TODO, so we don't forget to look into it eventually? I think this all code might not very useful, but if it is, we could get this info without Cloning.
Line 483, Patchset 3 (Latest):
if (is_native_buffer) {Vasiliy Telezhnikov . resolved
I guess this supposed to be always true?
Related details
Attention is currently required from:
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Jul 8, 2025, 2:49:02 AM7/8/25
to Colin Blundell, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mfoltz...@chromium.org
Colin Blundell voted and added 3 comments![]( "Open in Gerrit")
Votes added by Colin Blundell
| Commit-Queue | +2 |
3 comments
Patchset-level comments
Colin Blundell . resolved
Thanks!
File media/base/video_frame.cc
Line 403, Patchset 3 (Latest):
const auto gmb_handle = shared_image->CloneGpuMemoryBufferHandle();Vasiliy Telezhnikov . resolved
(maybe in a follow-up) nit: I know this was this way before, but it's quite unfortunate to clone handle for no reason. Could you add a TODO, so we don't forget to look into it eventually? I think this all code might not very useful, but if it is, we could get this info without Cloning.
Colin Blundell
Thanks! I was wondering about this code too. Will examine in a followup and either clean up, add a TODO, or both depending on what I find.
Line 483, Patchset 3 (Latest):
if (is_native_buffer) {Vasiliy Telezhnikov . resolved
I guess this supposed to be always true?
Colin Blundell
Yes, I'm going to eliminate the conditional when I change this code to operate on GMBNativePixmap directly.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Jul 8, 2025, 3:01:18 AM7/8/25
to Colin Blundell, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mfoltz...@chromium.org
Colin Blundell voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Jul 8, 2025, 3:08:40 AM7/8/25
to Colin Blundell, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mfoltz...@chromium.org
Colin Blundell voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 8, 2025, 3:36:32 AM7/8/25
to Colin Blundell, Vasiliy Telezhnikov, chromium...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mfoltz...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[//media] Split out VideoFrame::CreateFrameFor{GMB, MappableSI}Internal
This helper method can currently handle both. However, we're making all
knowledge of GpuMemoryBuffer in VideoFrame ChromeOS-specific. This CL
splits out handling of GMB from MappableSI.Bug: 40263579
Change-Id: I9e86704f73682509bfa59693eaacc995adf5a30d
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Commit-Queue: Colin Blundell <blun...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1483589}
Files:
- M media/base/video_frame.cc
- M media/base/video_frame.h
Change size: M
Delta: 2 files changed, 103 insertions(+), 57 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Vasiliy Telezhnikov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages