[iOS] Enable kTabRecallNewTabGroupButton by default [chromium/src : main]

0 views
Skip to first unread message

Briana McClure (Gerrit)

unread,
10:02 AM (5 hours ago) 10:02 AM
to Chris Lu, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Chris Lu

Briana McClure added 1 comment

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Briana McClure . resolved

Hey Chris PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Chris Lu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I02ae9997373627ca0c499d912088d6753ed9cc74
Gerrit-Change-Number: 7785324
Gerrit-PatchSet: 7
Gerrit-Owner: Briana McClure <bmcc...@google.com>
Gerrit-Reviewer: Briana McClure <bmcc...@google.com>
Gerrit-Reviewer: Chris Lu <thegre...@chromium.org>
Gerrit-Attention: Chris Lu <thegre...@chromium.org>
Gerrit-Comment-Date: Thu, 23 Apr 2026 14:02:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Chris Lu (Gerrit)

unread,
10:53 AM (4 hours ago) 10:53 AM
to Briana McClure, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Briana McClure

Chris Lu added 1 comment

Patchset-level comments
Chris Lu . resolved

Remove in fieldtrial_config as well?

Open in Gerrit

Related details

Attention is currently required from:
  • Briana McClure
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I02ae9997373627ca0c499d912088d6753ed9cc74
Gerrit-Change-Number: 7785324
Gerrit-PatchSet: 7
Gerrit-Owner: Briana McClure <bmcc...@google.com>
Gerrit-Reviewer: Briana McClure <bmcc...@google.com>
Gerrit-Reviewer: Chris Lu <thegre...@chromium.org>
Gerrit-Attention: Briana McClure <bmcc...@google.com>
Gerrit-Comment-Date: Thu, 23 Apr 2026 14:52:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Chris Lu (Gerrit)

unread,
10:53 AM (4 hours ago) 10:53 AM
to Briana McClure, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Briana McClure

Chris Lu added 1 comment

File ios/chrome/browser/shared/public/features/features.mm
Line 104, Patchset 7 (Parent):BASE_FEATURE(kTabRecallNewTabGroupButton, base::FEATURE_DISABLED_BY_DEFAULT);
Chris Lu . unresolved

should we just remove this feature declaration as well?

Open in Gerrit

Related details

Attention is currently required from:
  • Briana McClure
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I02ae9997373627ca0c499d912088d6753ed9cc74
    Gerrit-Change-Number: 7785324
    Gerrit-PatchSet: 7
    Gerrit-Owner: Briana McClure <bmcc...@google.com>
    Gerrit-Reviewer: Briana McClure <bmcc...@google.com>
    Gerrit-Reviewer: Chris Lu <thegre...@chromium.org>
    Gerrit-Attention: Briana McClure <bmcc...@google.com>
    Gerrit-Comment-Date: Thu, 23 Apr 2026 14:53:30 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Briana McClure (Gerrit)

    unread,
    11:19 AM (4 hours ago) 11:19 AM
    to Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, Chris Lu, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
    Attention needed from Chris Lu

    Briana McClure voted and added 2 comments

    Votes added by Briana McClure

    Commit-Queue+1

    2 comments

    Patchset-level comments
    Chris Lu . resolved

    Remove in fieldtrial_config as well?

    Briana McClure

    Done thanks for the reminder.

    File ios/chrome/browser/shared/public/features/features.mm
    Line 104, Patchset 7 (Parent):BASE_FEATURE(kTabRecallNewTabGroupButton, base::FEATURE_DISABLED_BY_DEFAULT);
    Chris Lu . resolved

    should we just remove this feature declaration as well?

    Briana McClure

    I removed the feature declaration since I already removed the enabled conditionals.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Chris Lu
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I02ae9997373627ca0c499d912088d6753ed9cc74
      Gerrit-Change-Number: 7785324
      Gerrit-PatchSet: 8
      Gerrit-Owner: Briana McClure <bmcc...@google.com>
      Gerrit-Reviewer: Briana McClure <bmcc...@google.com>
      Gerrit-Reviewer: Chris Lu <thegre...@chromium.org>
      Gerrit-Attention: Chris Lu <thegre...@chromium.org>
      Gerrit-Comment-Date: Thu, 23 Apr 2026 15:19:43 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Chris Lu <thegre...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Chris Lu (Gerrit)

      unread,
      11:26 AM (4 hours ago) 11:26 AM
      to Briana McClure, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
      Attention needed from Briana McClure

      Chris Lu voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Briana McClure
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I02ae9997373627ca0c499d912088d6753ed9cc74
      Gerrit-Change-Number: 7785324
      Gerrit-PatchSet: 8
      Gerrit-Owner: Briana McClure <bmcc...@google.com>
      Gerrit-Reviewer: Briana McClure <bmcc...@google.com>
      Gerrit-Reviewer: Chris Lu <thegre...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-Attention: Briana McClure <bmcc...@google.com>
      Gerrit-Comment-Date: Thu, 23 Apr 2026 15:26:28 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Briana McClure (Gerrit)

      unread,
      11:27 AM (4 hours ago) 11:27 AM
      to Chris Lu, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

      Briana McClure voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I02ae9997373627ca0c499d912088d6753ed9cc74
      Gerrit-Change-Number: 7785324
      Gerrit-PatchSet: 8
      Gerrit-Owner: Briana McClure <bmcc...@google.com>
      Gerrit-Reviewer: Briana McClure <bmcc...@google.com>
      Gerrit-Reviewer: Chris Lu <thegre...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-Comment-Date: Thu, 23 Apr 2026 15:27:21 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      1:09 PM (2 hours ago) 1:09 PM
      to Briana McClure, Chris Lu, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, asvitkine...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      [iOS] Enable kTabRecallNewTabGroupButton by default
      Fixed: 505395413
      Change-Id: I02ae9997373627ca0c499d912088d6753ed9cc74
      Commit-Queue: Briana McClure <bmcc...@google.com>
      Reviewed-by: Chris Lu <thegre...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1619606}
      Files:
      • M chrome/browser/flag-metadata.json
      • M ios/chrome/browser/flags/about_flags.mm
      • M ios/chrome/browser/flags/ios_chrome_flag_descriptions.cc
      • M ios/chrome/browser/flags/ios_chrome_flag_descriptions.h
      • M ios/chrome/browser/shared/public/features/features.h
      • M ios/chrome/browser/shared/public/features/features.mm
      • M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/tab_groups/tab_groups_panel_mediator.mm
      • M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/tab_groups/tab_groups_panel_mediator_unittest.mm
      • M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/toolbars/tab_grid_bottom_toolbar.mm
      • M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/toolbars/tab_grid_new_tab_button.mm
      • M testing/variations/fieldtrial_testing_config.json
      Change size: M
      Delta: 11 files changed, 17 insertions(+), 82 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Chris Lu
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I02ae9997373627ca0c499d912088d6753ed9cc74
      Gerrit-Change-Number: 7785324
      Gerrit-PatchSet: 9
      Gerrit-Owner: Briana McClure <bmcc...@google.com>
      Gerrit-Reviewer: Briana McClure <bmcc...@google.com>
      Gerrit-Reviewer: Chris Lu <thegre...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages