Reland "Add LockTopControlsV2 to field trial testing config" [chromium/src : main]

0 views
Skip to first unread message

Wenyu Fu (Gerrit)

unread,
Jan 16, 2026, 4:54:55 PM (2 days ago) Jan 16
to Sirisha Kavuluru, Chromium LUCI CQ, Theresa Sullivan, Rubber Stamper, AyeAye, chromium...@chromium.org, Peter Beverloo, Chromium Metrics Reviews, gangwu...@chromium.org, feature-me...@chromium.org, asvitkine...@chromium.org, donnd...@chromium.org, lizeb+watch...@chromium.org, twelling...@chromium.org, browser-comp...@chromium.org, sloboda...@chromium.org
Attention needed from Sirisha Kavuluru and Theresa Sullivan

Wenyu Fu voted and added 1 comment

Votes added by Wenyu Fu

Commit-Queue+1

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Sirisha Kavuluru
  • Theresa Sullivan
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If3109ef810b1734bb293d98ad5ff06fa179d8439
Gerrit-Change-Number: 7489272
Gerrit-PatchSet: 2
Gerrit-Owner: Wenyu Fu <wen...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Sirisha Kavuluru <skav...@google.com>
Gerrit-Reviewer: Theresa Sullivan <twell...@chromium.org>
Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-Attention: Sirisha Kavuluru <skav...@google.com>
Gerrit-Attention: Theresa Sullivan <twell...@chromium.org>
Gerrit-Comment-Date: Fri, 16 Jan 2026 21:54:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Jan 16, 2026, 4:55:13 PM (2 days ago) Jan 16
to Wenyu Fu, Sirisha Kavuluru, Chromium LUCI CQ, Theresa Sullivan, AyeAye, chromium...@chromium.org, Peter Beverloo, Chromium Metrics Reviews, gangwu...@chromium.org, feature-me...@chromium.org, asvitkine...@chromium.org, donnd...@chromium.org, lizeb+watch...@chromium.org, twelling...@chromium.org, browser-comp...@chromium.org, sloboda...@chromium.org
Attention needed from Sirisha Kavuluru and Theresa Sullivan

Message from Rubber Stamper

Gerrit GetPureRevert API does not mark this CL as a pure revert. Learn more: go/rubber-stamper-user-guide.

Gerrit-Comment-Date: Fri, 16 Jan 2026 21:55:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Theresa Sullivan (Gerrit)

unread,
Jan 16, 2026, 5:00:04 PM (2 days ago) Jan 16
to Wenyu Fu, Sirisha Kavuluru, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Peter Beverloo, Chromium Metrics Reviews, gangwu...@chromium.org, feature-me...@chromium.org, asvitkine...@chromium.org, donnd...@chromium.org, lizeb+watch...@chromium.org, twelling...@chromium.org, browser-comp...@chromium.org, sloboda...@chromium.org
Attention needed from Sirisha Kavuluru and Wenyu Fu

Theresa Sullivan voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Sirisha Kavuluru
  • Wenyu Fu
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If3109ef810b1734bb293d98ad5ff06fa179d8439
    Gerrit-Change-Number: 7489272
    Gerrit-PatchSet: 4
    Gerrit-Owner: Wenyu Fu <wen...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Sirisha Kavuluru <skav...@google.com>
    Gerrit-Reviewer: Theresa Sullivan <twell...@chromium.org>
    Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-Attention: Sirisha Kavuluru <skav...@google.com>
    Gerrit-Attention: Wenyu Fu <wen...@chromium.org>
    Gerrit-Comment-Date: Fri, 16 Jan 2026 21:59:51 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Wenyu Fu (Gerrit)

    unread,
    Jan 16, 2026, 6:16:58 PM (2 days ago) Jan 16
    to Theresa Sullivan, Sirisha Kavuluru, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Peter Beverloo, Chromium Metrics Reviews, gangwu...@chromium.org, feature-me...@chromium.org, asvitkine...@chromium.org, donnd...@chromium.org, lizeb+watch...@chromium.org, twelling...@chromium.org, browser-comp...@chromium.org, sloboda...@chromium.org
    Attention needed from Sirisha Kavuluru

    Wenyu Fu voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Sirisha Kavuluru
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If3109ef810b1734bb293d98ad5ff06fa179d8439
    Gerrit-Change-Number: 7489272
    Gerrit-PatchSet: 6
    Gerrit-Owner: Wenyu Fu <wen...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Sirisha Kavuluru <skav...@google.com>
    Gerrit-Reviewer: Theresa Sullivan <twell...@chromium.org>
    Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-Attention: Sirisha Kavuluru <skav...@google.com>
    Gerrit-Comment-Date: Fri, 16 Jan 2026 23:16:39 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 16, 2026, 8:47:52 PM (2 days ago) Jan 16
    to Wenyu Fu, Theresa Sullivan, Sirisha Kavuluru, AyeAye, chromium...@chromium.org, Peter Beverloo, Chromium Metrics Reviews, gangwu...@chromium.org, feature-me...@chromium.org, asvitkine...@chromium.org, donnd...@chromium.org, lizeb+watch...@chromium.org, twelling...@chromium.org, browser-comp...@chromium.org, sloboda...@chromium.org

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    4 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    Reland "Add LockTopControlsV2 to field trial testing config"

    This reverts commit a9cce57494a4fa3c9e0cae5b26a84f8a1dab025d.

    Reason for revert: Disable LTCv2 on the failed test.

    Skipping new flaky tests since this CL runs on all CI-only tests.
    android-15-tablet-landscape-x64-rel test run passes correctly.

    Original change's description:
    > Revert "Add LockTopControlsV2 to field trial testing config"
    >
    > This reverts commit 6e08c5868e1e14dd13c401a82ee6e288d38a81fd.
    >
    > Reason for revert: crbug.com/476375461
    >
    > Original change's description:
    > > Add LockTopControlsV2 to field trial testing config
    > >
    > > Test that are not compatible with the feature will have the feature
    > > temporarily disabled.
    > >
    > > Include-Ci-Only-Tests: chromium.android.desktop:android-desktop-x64-rel-15-tests|chrome_public_test_apk
    > > Bug: 450970998, 473893732
    > > Change-Id: I248bfa8f94f39010b26b8e22374ba512caf88bff
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7458201
    > > Reviewed-by: Theresa Sullivan <twell...@chromium.org>
    > > Reviewed-by: Sirisha Kavuluru <skav...@google.com>
    > > Commit-Queue: Wenyu Fu <wen...@chromium.org>
    > > Cr-Commit-Position: refs/heads/main@{#1570159}
    >
    > Bug: 450970998, 473893732
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Change-Id: Ia0a9947f631bb1a6b98a555317ed49941449cfca
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7487037
    > Reviewed-by: Arthur Sonzogni <arthurs...@chromium.org>
    > Auto-Submit: Egor Pasko <pa...@chromium.org>
    > Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    > Owners-Override: Egor Pasko <pa...@chromium.org>
    > Commit-Queue: Arthur Sonzogni <arthurs...@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#1570346}
    Bug: 450970998, 473893732
    Change-Id: If3109ef810b1734bb293d98ad5ff06fa179d8439
    Include-Ci-Only-Tests: true
    Validate-Test-Flakiness: skip
    Commit-Queue: Wenyu Fu <wen...@chromium.org>
    Reviewed-by: Theresa Sullivan <twell...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1570714}
    Files:
    • M chrome/android/BUILD.gn
    • M chrome/android/features/keyboard_accessory/javatests/src/org/chromium/chrome/browser/keyboard_accessory/AutofillKeyboardAccessoryIntegrationTest.java
    • M chrome/android/features/keyboard_accessory/javatests/src/org/chromium/chrome/browser/keyboard_accessory/PasswordGenerationIntegrationTest.java
    • M chrome/android/javatests/src/org/chromium/chrome/browser/PopupMultiwindowPTTest.java
    • M chrome/android/javatests/src/org/chromium/chrome/browser/ViewTransitionPixelTest.java
    • M chrome/android/javatests/src/org/chromium/chrome/browser/autofill/TouchToFillCreditCardTest.java
    • M chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
    • M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
    • M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/TabReparentingTest.java
    • M chrome/android/javatests/src/org/chromium/chrome/browser/fullscreen/FullscreenManagerTest.java
    • M chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java
    • M chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/AutoplayMutedNotificationTest.java
    • M chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/FullscreenVideoPictureInPictureControllerTest.java
    • M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestRule.java
    • M chrome/android/javatests/src/org/chromium/chrome/browser/tab/SadTabTest.java
    • M chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
    • M chrome/browser/ui/android/tabstrip/java/src/org/chromium/chrome/browser/tabstrip/TabStripTopControlLayerUnitTest.java
    • M testing/variations/fieldtrial_testing_config.json
    Change size: M
    Delta: 18 files changed, 106 insertions(+), 10 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Theresa Sullivan
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If3109ef810b1734bb293d98ad5ff06fa179d8439
    Gerrit-Change-Number: 7489272
    Gerrit-PatchSet: 7
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages