Pass parsed h264 level into VideoSampleEntry [chromium/src : main]
0 views
Skip to first unread message
Maciej Kubicz (Gerrit)
Nov 7, 2025, 3:36:58 AM (6 days ago) Nov 7
to Eugene Zemtsov, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Eugene Zemtsov
Maciej Kubicz added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Maciej Kubicz . resolved
Hi! Could you share your opinion about this small patch?
Related details
Attention is currently required from:
- Eugene Zemtsov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eugene Zemtsov (Gerrit)
Nov 7, 2025, 5:11:36 PM (5 days ago) Nov 7
to Maciej Kubicz, Eugene Zemtsov, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Maciej Kubicz
Eugene Zemtsov voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Maciej Kubicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eugene Zemtsov (Gerrit)
Nov 7, 2025, 5:12:03 PM (5 days ago) Nov 7
to Maciej Kubicz, Dale Curtis, Eugene Zemtsov, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Dale Curtis and Maciej Kubicz
Eugene Zemtsov added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Dale Curtis
- Maciej Kubicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Nov 10, 2025, 1:18:15 PM (2 days ago) Nov 10
to Maciej Kubicz, Eugene Zemtsov, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Maciej Kubicz
Dale Curtis voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Maciej Kubicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maciej Kubicz (Gerrit)
2:13 AM (16 hours ago) 2:13 AM
to Dale Curtis, Eugene Zemtsov, chromium...@chromium.org, feature-me...@chromium.org
Maciej Kubicz voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maciej Kubicz (Gerrit)
2:21 AM (16 hours ago) 2:21 AM
to Chromium LUCI CQ, Dale Curtis, Eugene Zemtsov, chromium...@chromium.org, feature-me...@chromium.org
Maciej Kubicz added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Maciej Kubicz . resolved
Eugene, can you please help to get the commit to CQ (or run try jobs if needed)? Thanks!
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eugene Zemtsov (Gerrit)
3:04 AM (15 hours ago) 3:04 AM
to Maciej Kubicz, Eugene Zemtsov, Chromium LUCI CQ, Dale Curtis, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Maciej Kubicz
Eugene Zemtsov voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Maciej Kubicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
4:00 AM (14 hours ago) 4:00 AM
to Maciej Kubicz, Eugene Zemtsov, Dale Curtis, chromium...@chromium.org, feature-me...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Pass parsed h264 level into VideoSampleEntry
That piece of info will later make its way into VideoDecoderConfig of
DemuxerStream. That makes information about h264 level available to the
clients of ChunkDemuxer.
Having that info is useful, because it allows rejecting the playback of
too demanding streams early - some lower-end devices have constraints on
the h264 level they are able to play, and with playback being
orchestrated by a js MSE app, we might find ourselves in a situation
where we receive a too demanding stream to play. Attempting to play such
stream could result in poor user experience (e.g. choppy playback).
In our use-case, we parse the h264 bitstream ourselves to find out the
level just before passing the data to the platform's decoder. Having
access to the h264 level straight from chunk demuxer would allow us to
avoid unnecessary duplication of the work already done in chunk demuxer.
Change-Id: I81d70445960c5889f0c43cec4e73a7d39da6901a
Commit-Queue: Eugene Zemtsov <eug...@chromium.org>
Reviewed-by: Dale Curtis <dalec...@chromium.org>
Reviewed-by: Eugene Zemtsov <eug...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1543589}
Files:
- M media/formats/mp4/box_definitions.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Eugene Zemtsov, +1 by Dale Curtis
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages