Update save card and cvc-save only to use wallet icon [chromium/src : main]

0 views
Skip to first unread message

Olivia Saul (Gerrit)

unread,
Jan 16, 2026, 5:04:28 PM (2 days ago) Jan 16
to Qihui Zhao, Olivia Saul, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, sloboda...@chromium.org
Attention needed from Qihui Zhao

Olivia Saul added 1 comment

Open in Gerrit

Related details

Attention is currently required from:
  • Qihui Zhao
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8359095139486cfbcc4f066fd524435c628a635e
Gerrit-Change-Number: 7490081
Gerrit-PatchSet: 6
Gerrit-Owner: Qihui Zhao <qihu...@google.com>
Gerrit-Reviewer: Olivia Saul <os...@google.com>
Gerrit-Reviewer: Qihui Zhao <qihu...@google.com>
Gerrit-Attention: Qihui Zhao <qihu...@google.com>
Gerrit-Comment-Date: Fri, 16 Jan 2026 22:04:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Qihui Zhao (Gerrit)

unread,
Jan 16, 2026, 6:44:05 PM (2 days ago) Jan 16
to Olivia Saul, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, sloboda...@chromium.org
Attention needed from Olivia Saul

Qihui Zhao added 1 comment

Commit Message
Qihui Zhao

I think it's the building issue, I added the svg file in [this](https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/8924070) CL and the preview looks good: https://screenshot.googleplex.com/BjjNKhRXqsLc986
It's because that the view is built under the flag: https://screenshot.googleplex.com/5PEwcZmrmhgHedr.
So I have to manual edit the icon.

Open in Gerrit

Related details

Attention is currently required from:
  • Olivia Saul
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8359095139486cfbcc4f066fd524435c628a635e
Gerrit-Change-Number: 7490081
Gerrit-PatchSet: 6
Gerrit-Owner: Qihui Zhao <qihu...@google.com>
Gerrit-Reviewer: Olivia Saul <os...@google.com>
Gerrit-Reviewer: Qihui Zhao <qihu...@google.com>
Gerrit-Attention: Olivia Saul <os...@google.com>
Gerrit-Comment-Date: Fri, 16 Jan 2026 23:43:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Olivia Saul <os...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages