Add parser for X-I-FRAME-STREAM-INF HLS tag [chromium/src : main]
1 view
Skip to first unread message
Ted (Chromium) Meyer (Gerrit)
Jul 7, 2025, 6:29:16 PM7/7/25
to Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Eugene Zemtsov
Ted (Chromium) Meyer voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Eugene Zemtsov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eugene Zemtsov (Gerrit)
Jul 7, 2025, 10:19:08 PM7/7/25
to Ted (Chromium) Meyer, Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Ted (Chromium) Meyer
Eugene Zemtsov added 2 comments![]( "Open in Gerrit")
File media/formats/hls/tags.h
Line 710, Patchset 2 (Latest):
std::optional<std::vector<std::string>> codecs;Eugene Zemtsov . unresolved
is there any meaningful difference here between absence of value and an empty list?
File media/formats/hls/tags_unittest.cc
Line 381, Patchset 2 (Latest):
"SCORE=9.5,CODECS=\"avc1.64001f\"",Eugene Zemtsov . unresolved
a test with more than one codec?
Related details
Attention is currently required from:
- Ted (Chromium) Meyer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ted (Chromium) Meyer (Gerrit)
Jul 8, 2025, 2:09:48 PM7/8/25
to Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Eugene Zemtsov
Ted (Chromium) Meyer added 2 comments![]( "Open in Gerrit")
File media/formats/hls/tags.h
Line 710, Patchset 2 (Latest):
std::optional<std::vector<std::string>> codecs;Eugene Zemtsov . resolved
is there any meaningful difference here between absence of value and an empty list?
Ted (Chromium) Meyer
I can update the previous comment to be more clear, but basically, nullopt implies that the CODECS property is not present, while an empty vector means it's been declared empty: CODECS="".
I don't think we'd ever actually see that happen, but the spec allows it.
File media/formats/hls/tags_unittest.cc
Line 381, Patchset 2 (Latest):
"SCORE=9.5,CODECS=\"avc1.64001f\"",Eugene Zemtsov . resolved
a test with more than one codec?
Attention is currently required from:
- Eugene Zemtsov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eugene Zemtsov (Gerrit)
Jul 8, 2025, 2:11:22 PM7/8/25
to Ted (Chromium) Meyer, Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Ted (Chromium) Meyer
Eugene Zemtsov voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Ted (Chromium) Meyer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 8, 2025, 3:52:15 PM7/8/25
to Ted (Chromium) Meyer, Eugene Zemtsov, chromium...@chromium.org, feature-me...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: media/formats/hls/tags.h
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
Add parser for X-I-FRAME-STREAM-INF HLS tag
This is part of a series of changes to finish adding all the tags that
are specified in the HLS spec. They'll be added to the manifest parsers
in follow up CLs.
Fixed: 314834376
Change-Id: Id03836420def9a74de91711bc84e5f07097c6339
Reviewed-by: Eugene Zemtsov <eug...@chromium.org>
Commit-Queue: Ted (Chromium) Meyer <tmath...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1483940}
Files:
- M media/formats/hls/tags.cc
- M media/formats/hls/tags.h
- M media/formats/hls/tags_unittest.cc
- M media/formats/hls/types.cc
- M media/formats/hls/types.h
Change size: L
Delta: 5 files changed, 287 insertions(+), 22 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Eugene Zemtsov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages