Make FromLayout() constexpr for Mono/Stereo [chromium/src : main]

0 views
Skip to first unread message

Thomas Guilbert (Gerrit)

unread,
Feb 11, 2026, 5:24:41 PM (10 hours ago) Feb 11
to Thomas Guilbert, Syed AbuTalib, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Syed AbuTalib

Thomas Guilbert voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Syed AbuTalib
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5aed415695d17cbc30debec10da66db83e971b5a
Gerrit-Change-Number: 7568793
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Guilbert <tgui...@chromium.org>
Gerrit-Reviewer: Syed AbuTalib <low...@google.com>
Gerrit-Reviewer: Thomas Guilbert <tgui...@chromium.org>
Gerrit-Attention: Syed AbuTalib <low...@google.com>
Gerrit-Comment-Date: Wed, 11 Feb 2026 22:24:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Syed AbuTalib (Gerrit)

unread,
Feb 11, 2026, 5:29:12 PM (10 hours ago) Feb 11
to Thomas Guilbert, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Thomas Guilbert

Syed AbuTalib voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Guilbert
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I5aed415695d17cbc30debec10da66db83e971b5a
    Gerrit-Change-Number: 7568793
    Gerrit-PatchSet: 1
    Gerrit-Owner: Thomas Guilbert <tgui...@chromium.org>
    Gerrit-Reviewer: Syed AbuTalib <low...@google.com>
    Gerrit-Reviewer: Thomas Guilbert <tgui...@chromium.org>
    Gerrit-Attention: Thomas Guilbert <tgui...@chromium.org>
    Gerrit-Comment-Date: Wed, 11 Feb 2026 22:29:00 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Feb 11, 2026, 7:10:48 PM (8 hours ago) Feb 11
    to Thomas Guilbert, Syed AbuTalib, chromium...@chromium.org, feature-me...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Make FromLayout() constexpr for Mono/Stereo

    This CL special cases the templated `FromLayout` helper to allow for
    constexpr creation of mono and stereo ChannelLayoutConfigs, since these
    layouts are the two most commonly found throughout the code.
    Change-Id: I5aed415695d17cbc30debec10da66db83e971b5a
    Auto-Submit: Thomas Guilbert <tgui...@chromium.org>
    Commit-Queue: Thomas Guilbert <tgui...@chromium.org>
    Commit-Queue: Syed AbuTalib <low...@google.com>
    Reviewed-by: Syed AbuTalib <low...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1583601}
    Files:
    • M media/base/channel_layout.h
    • M media/base/channel_layout_unittest.cc
    Change size: S
    Delta: 2 files changed, 15 insertions(+), 8 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Syed AbuTalib
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I5aed415695d17cbc30debec10da66db83e971b5a
    Gerrit-Change-Number: 7568793
    Gerrit-PatchSet: 2
    Gerrit-Owner: Thomas Guilbert <tgui...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Syed AbuTalib <low...@google.com>
    Gerrit-Reviewer: Thomas Guilbert <tgui...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages