Dibyajyoti Pal (Gerrit)

unread,

May 12, 2026, 12:24:30 PM (6 days ago) May 12

to Paulina Gacek, Chromium LUCI CQ, Tove Petersson, android-bu...@system.gserviceaccount.com, Rijubrata Bhaumik, Simon Hangl, Chromium Web Applications Reviews, chromium...@chromium.org, Andrew Rayskiy, Chromium Metrics Reviews, zelin+watch-we...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, chfreme...@chromium.org, webap...@microsoft.com, japhet+...@chromium.org, mek+w...@chromium.org, dibyapal+wa...@chromium.org, phoglun...@chromium.org, asvitkine...@chromium.org, aixba+wat...@chromium.org, jmedle...@chromium.org, mgiuca...@chromium.org, feature-me...@chromium.org, dmurph+watc...@chromium.org, asvitki...@chromium.org, loyso...@chromium.org

Attention needed from Paulina Gacek and Tove Petersson

Dibyajyoti Pal added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Dibyajyoti Pal . resolved

Removing myself from the attention set, please reassign back to me once the flakiness has been handled. Thanks!

Open in Gerrit

Related details

Attention is currently required from:

Paulina Gacek
Tove Petersson

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Tove Petersson (Gerrit)

unread,

May 13, 2026, 6:28:26 AM (5 days ago) May 13

to Paulina Gacek, Chromium LUCI CQ, Dibyajyoti Pal, android-bu...@system.gserviceaccount.com, Rijubrata Bhaumik, Simon Hangl, Chromium Web Applications Reviews, chromium...@chromium.org, Andrew Rayskiy, Chromium Metrics Reviews, zelin+watch-we...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, chfreme...@chromium.org, webap...@microsoft.com, japhet+...@chromium.org, mek+w...@chromium.org, dibyapal+wa...@chromium.org, phoglun...@chromium.org, asvitkine...@chromium.org, aixba+wat...@chromium.org, jmedle...@chromium.org, mgiuca...@chromium.org, feature-me...@chromium.org, dmurph+watc...@chromium.org, asvitki...@chromium.org, loyso...@chromium.org

Attention needed from Dibyajyoti Pal and Paulina Gacek

Tove Petersson voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Dibyajyoti Pal
Paulina Gacek

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dibyajyoti Pal (Gerrit)

unread,

May 13, 2026, 12:05:26 PM (5 days ago) May 13

to Paulina Gacek, Tove Petersson, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Rijubrata Bhaumik, Simon Hangl, Chromium Web Applications Reviews, chromium...@chromium.org, Andrew Rayskiy, Chromium Metrics Reviews, zelin+watch-we...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, chfreme...@chromium.org, webap...@microsoft.com, japhet+...@chromium.org, mek+w...@chromium.org, dibyapal+wa...@chromium.org, phoglun...@chromium.org, asvitkine...@chromium.org, aixba+wat...@chromium.org, jmedle...@chromium.org, mgiuca...@chromium.org, feature-me...@chromium.org, dmurph+watc...@chromium.org, asvitki...@chromium.org, loyso...@chromium.org

Attention needed from Paulina Gacek

Dibyajyoti Pal voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Paulina Gacek

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Paulina Gacek (Gerrit)

unread,

5:17 AM (4 hours ago) 5:17 AM

to Tove Petersson, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Rijubrata Bhaumik, Simon Hangl, Chromium Web Applications Reviews, chromium...@chromium.org, Andrew Rayskiy, Chromium Metrics Reviews, zelin+watch-we...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, chfreme...@chromium.org, webap...@microsoft.com, japhet+...@chromium.org, mek+w...@chromium.org, dibyapal+wa...@chromium.org, phoglun...@chromium.org, asvitkine...@chromium.org, aixba+wat...@chromium.org, jmedle...@chromium.org, mgiuca...@chromium.org, feature-me...@chromium.org, dmurph+watc...@chromium.org, asvitki...@chromium.org, loyso...@chromium.org

Paulina Gacek voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

7:18 AM (2 hours ago) 7:18 AM

to Paulina Gacek, Dibyajyoti Pal, Tove Petersson, android-bu...@system.gserviceaccount.com, Rijubrata Bhaumik, Simon Hangl, Chromium Web Applications Reviews, chromium...@chromium.org, Andrew Rayskiy, Chromium Metrics Reviews, zelin+watch-we...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, chfreme...@chromium.org, webap...@microsoft.com, japhet+...@chromium.org, mek+w...@chromium.org, dibyapal+wa...@chromium.org, phoglun...@chromium.org, asvitkine...@chromium.org, aixba+wat...@chromium.org, jmedle...@chromium.org, mgiuca...@chromium.org, feature-me...@chromium.org, dmurph+watc...@chromium.org, asvitki...@chromium.org, loyso...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Reland "Reland "iwa: Enable Capture Handle extraction and tracking for IWA/PWA windows""

This is a reland of commit e6e606867f275256925ed7193067d2f64974060a

The previous reland failed on `linux_chromium_chromeos_msan_rel_ng`.
`CaptureHandleSystemWebAppBrowserTest` was explicitly passing
`--use-gpu-in-tests`, which forced the MSan bot to load uninstrumented
system graphics drivers (Mesa), triggering false-positive uninitialized
memory crashes. This switch has been removed.

Original change's description:
> Reland "iwa: Enable Capture Handle extraction and tracking for IWA/PWA windows"
>
> This is a reland of commit 0b0be7a8fb75daffc0556976aedac5c63252831f
>
> Reason for reland: The original CL caused test failures on
> `mac15-x64-rel-tests`. Since this feature is currently only implemented
> for ChromeOS, this reland disables the affected tests on Mac to fix the
> builder.
>
> Original change's description:
> > iwa: Enable Capture Handle extraction and tracking for IWA/PWA windows
> >
> > Currently, the Capture Handle API is only supported for tab capture
> > (`TYPE_WEB_CONTENTS`). When IWAs/PWAs are captured as a standalone OS
> > window (`TYPE_WINDOW`), their Capture Handle configuration is dropped.
> >
> > Specifically, this CL updates `DesktopMediaIDToDisplayMediaInformation`
> > to extract handles for TYPE_WINDOW IDs. This is strictly gated only for
> > IWAs and PWAs behind the `CaptureHandleForStandalonePwasAndIwas` feature
> > flag to ensure standard SWAs and regular browser windows do not expose
> > handles.
> >
> > This CL handles the 'pull' part of the API (initial handle via
> > getCaptureHandle), but it bypasses the 'push' part (dynamic updates).
> > The push part is implemented in the subsequent CL.
> >
> > Design doc: go/capture-handle-for-pwas-iwas
> >
> > Low-Coverage-Reason: TRIVIAL_CHANGE Default base class implementation returning a fallback (false). This is overridden and tested in the active subclass `WebAppBrowserController`.
> > Bug: 494331663
> > Change-Id: Ia90f53761fd727928341a01cf68c67a71e6e4699
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7698072
> > Reviewed-by: Dibyajyoti Pal <diby...@chromium.org>
> > Commit-Queue: Paulina Gacek <paulin...@google.com>
> > Reviewed-by: Tove Petersson <to...@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1627617}
>
> Bug: 494331663
> Change-Id: I1d5947c004bd3b5bc4aed8ff1d8667dcc27bf916
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7827455
> Reviewed-by: Dibyajyoti Pal <diby...@chromium.org>
> Commit-Queue: Paulina Gacek <paulin...@google.com>
> Reviewed-by: Tove Petersson <to...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1628634}

Bug: 494331663

Change-Id: I6cc18aabb41e2240879f07fa4ab45c1355238643

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7841712

Reviewed-by: Tove Petersson <to...@chromium.org>

Reviewed-by: Dibyajyoti Pal <diby...@chromium.org>

Commit-Queue: Paulina Gacek <paulin...@google.com>

Cr-Commit-Position: refs/heads/main@{#1632076}

Files:

M chrome/browser/about_flags.cc
M chrome/browser/flag-metadata.json
M chrome/browser/flag_descriptions.h
A chrome/browser/media/webrtc/capture_handle_app_window_browsertest.cc
M chrome/browser/media/webrtc/desktop_capture_devices_util.cc
M chrome/browser/media/webrtc/desktop_capture_devices_util.h
M chrome/browser/ui/web_applications/app_browser_controller.cc
M chrome/browser/ui/web_applications/app_browser_controller.h
M chrome/browser/ui/web_applications/web_app_browser_controller.cc
M chrome/browser/ui/web_applications/web_app_browser_controller.h
M chrome/browser/web_applications/web_app_filter.cc
M chrome/browser/web_applications/web_app_filter.h
M chrome/browser/web_applications/web_app_registrar.cc
M chrome/common/chrome_features.cc
M chrome/common/chrome_features.h
M chrome/test/BUILD.gn
M tools/metrics/histograms/enums.xml

Change size: XL

Delta: 17 files changed, 1038 insertions(+), 8 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Tove Petersson, +1 by Dibyajyoti Pal

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Reland "Reland "iwa: Enable Capture Handle extraction and tracking for IWA/PWA windows"" [chromium/src : main]

Dibyajyoti Pal (Gerrit)

Dibyajyoti Pal added 1 comment

Related details

Tove Petersson (Gerrit)

Tove Petersson voted Code-Review+1

Related details

Dibyajyoti Pal (Gerrit)

Dibyajyoti Pal voted Code-Review+1

Related details

Paulina Gacek (Gerrit)

Paulina Gacek voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information