DSEPrewarm: Explicitly Disable DSE Prewarm in some browser tests [chromium/src : main]

1 view
Skip to first unread message

Takashi Toyoshima (Gerrit)

unread,
Jul 7, 2025, 8:55:51 AM7/7/25
to Jiacheng Guo, Kouhei Ueno, Ryan Sultanem, Chromium LUCI CQ, David Roger, Shunya Shishido, Rijubrata Bhaumik, Andrew Rayskiy, Simon Hangl, Chromium Metrics Reviews, AyeAye, chromiumme...@microsoft.com, loading-rev...@chromium.org, bmcquad...@chromium.org, print-rev...@chromium.org, asvitki...@chromium.org, cros-print...@google.com, speed-metrics...@chromium.org, speed-metr...@chromium.org, csharris...@chromium.org, headless...@chromium.org, feature-me...@chromium.org, rmcelra...@chromium.org, omnibox-...@chromium.org, chfreme...@chromium.org, jdonnel...@chromium.org, lingqi...@chromium.org, permissio...@chromium.org, tburkar...@chromium.org, prerenderi...@chromium.org, gavin...@chromium.org, jdeblas...@chromium.org, dibyapal+wa...@chromium.org, kuragin+web-ap...@chromium.org, dmurph+watc...@chromium.org, zelin+watch-we...@chromium.org, loyso...@chromium.org, extension...@chromium.org, webap...@microsoft.com, chromium-a...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, asvitkine...@chromium.org
Attention needed from David Roger, Jiacheng Guo and Kouhei Ueno

Takashi Toyoshima voted

Auto-Submit+0
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • David Roger
  • Jiacheng Guo
  • Kouhei Ueno
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2d315ec966e2190cf086bc0f38b11a6c2c19ccc1
Gerrit-Change-Number: 6700901
Gerrit-PatchSet: 29
Gerrit-Owner: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-Reviewer: David Roger <dro...@chromium.org>
Gerrit-Reviewer: Jiacheng Guo <g...@google.com>
Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Ryan Sultanem <rs...@google.com>
Gerrit-CC: Shunya Shishido <sisid...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Kouhei Ueno <kou...@chromium.org>
Gerrit-Attention: Jiacheng Guo <g...@google.com>
Gerrit-Attention: David Roger <dro...@chromium.org>
Gerrit-Comment-Date: Mon, 07 Jul 2025 12:55:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Takashi Toyoshima (Gerrit)

unread,
Jul 7, 2025, 11:40:59 AM7/7/25
to Jiacheng Guo, Kouhei Ueno, Ryan Sultanem, Chromium LUCI CQ, David Roger, Shunya Shishido, Rijubrata Bhaumik, Andrew Rayskiy, Simon Hangl, Chromium Metrics Reviews, AyeAye, chromiumme...@microsoft.com, loading-rev...@chromium.org, bmcquad...@chromium.org, print-rev...@chromium.org, asvitki...@chromium.org, cros-print...@google.com, speed-metrics...@chromium.org, speed-metr...@chromium.org, csharris...@chromium.org, headless...@chromium.org, feature-me...@chromium.org, rmcelra...@chromium.org, omnibox-...@chromium.org, chfreme...@chromium.org, jdonnel...@chromium.org, lingqi...@chromium.org, permissio...@chromium.org, tburkar...@chromium.org, prerenderi...@chromium.org, gavin...@chromium.org, jdeblas...@chromium.org, dibyapal+wa...@chromium.org, kuragin+web-ap...@chromium.org, dmurph+watc...@chromium.org, zelin+watch-we...@chromium.org, loyso...@chromium.org, extension...@chromium.org, webap...@microsoft.com, chromium-a...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, asvitkine...@chromium.org
Attention needed from David Roger, Jiacheng Guo and Kouhei Ueno

Takashi Toyoshima voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • David Roger
  • Jiacheng Guo
  • Kouhei Ueno
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2d315ec966e2190cf086bc0f38b11a6c2c19ccc1
Gerrit-Change-Number: 6700901
Gerrit-PatchSet: 30
Gerrit-Owner: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-Reviewer: David Roger <dro...@chromium.org>
Gerrit-Reviewer: Jiacheng Guo <g...@google.com>
Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Ryan Sultanem <rs...@google.com>
Gerrit-CC: Shunya Shishido <sisid...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Kouhei Ueno <kou...@chromium.org>
Gerrit-Attention: Jiacheng Guo <g...@google.com>
Gerrit-Attention: David Roger <dro...@chromium.org>
Gerrit-Comment-Date: Mon, 07 Jul 2025 15:40:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jiacheng Guo (Gerrit)

unread,
Jul 8, 2025, 1:32:03 AM7/8/25
to Takashi Toyoshima, Kouhei Ueno, Ryan Sultanem, Chromium LUCI CQ, David Roger, Shunya Shishido, Rijubrata Bhaumik, Andrew Rayskiy, Simon Hangl, Chromium Metrics Reviews, AyeAye, chromiumme...@microsoft.com, loading-rev...@chromium.org, bmcquad...@chromium.org, print-rev...@chromium.org, asvitki...@chromium.org, cros-print...@google.com, speed-metrics...@chromium.org, speed-metr...@chromium.org, csharris...@chromium.org, headless...@chromium.org, feature-me...@chromium.org, rmcelra...@chromium.org, omnibox-...@chromium.org, chfreme...@chromium.org, jdonnel...@chromium.org, lingqi...@chromium.org, permissio...@chromium.org, tburkar...@chromium.org, prerenderi...@chromium.org, gavin...@chromium.org, jdeblas...@chromium.org, dibyapal+wa...@chromium.org, kuragin+web-ap...@chromium.org, dmurph+watc...@chromium.org, zelin+watch-we...@chromium.org, loyso...@chromium.org, extension...@chromium.org, webap...@microsoft.com, chromium-a...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, asvitkine...@chromium.org
Attention needed from David Roger, Kouhei Ueno and Takashi Toyoshima

Jiacheng Guo voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • David Roger
  • Kouhei Ueno
  • Takashi Toyoshima
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2d315ec966e2190cf086bc0f38b11a6c2c19ccc1
    Gerrit-Change-Number: 6700901
    Gerrit-PatchSet: 30
    Gerrit-Owner: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-Reviewer: David Roger <dro...@chromium.org>
    Gerrit-Reviewer: Jiacheng Guo <g...@google.com>
    Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Ryan Sultanem <rs...@google.com>
    Gerrit-CC: Shunya Shishido <sisid...@chromium.org>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-Attention: Kouhei Ueno <kou...@chromium.org>
    Gerrit-Attention: David Roger <dro...@chromium.org>
    Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-Comment-Date: Tue, 08 Jul 2025 05:31:38 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Takashi Toyoshima (Gerrit)

    unread,
    Jul 9, 2025, 1:50:54 PM7/9/25
    to Nico Weber, Jiacheng Guo, Kouhei Ueno, Ryan Sultanem, Chromium LUCI CQ, David Roger, Shunya Shishido, Rijubrata Bhaumik, Andrew Rayskiy, Simon Hangl, Chromium Metrics Reviews, AyeAye, chromiumme...@microsoft.com, loading-rev...@chromium.org, bmcquad...@chromium.org, print-rev...@chromium.org, asvitki...@chromium.org, cros-print...@google.com, speed-metrics...@chromium.org, speed-metr...@chromium.org, csharris...@chromium.org, headless...@chromium.org, feature-me...@chromium.org, rmcelra...@chromium.org, omnibox-...@chromium.org, chfreme...@chromium.org, jdonnel...@chromium.org, lingqi...@chromium.org, permissio...@chromium.org, tburkar...@chromium.org, prerenderi...@chromium.org, gavin...@chromium.org, jdeblas...@chromium.org, dibyapal+wa...@chromium.org, kuragin+web-ap...@chromium.org, dmurph+watc...@chromium.org, zelin+watch-we...@chromium.org, loyso...@chromium.org, extension...@chromium.org, webap...@microsoft.com, chromium-a...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, asvitkine...@chromium.org
    Attention needed from David Roger, Kouhei Ueno and Nico Weber

    Takashi Toyoshima added 1 comment

    Patchset-level comments
    File-level comment, Patchset 30 (Latest):
    Takashi Toyoshima . unresolved

    +Nico as EST //chrome OWNERS

    Open in Gerrit

    Related details

    Attention is currently required from:
    • David Roger
    • Kouhei Ueno
    • Nico Weber
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I2d315ec966e2190cf086bc0f38b11a6c2c19ccc1
      Gerrit-Change-Number: 6700901
      Gerrit-PatchSet: 30
      Gerrit-Owner: Takashi Toyoshima <toyo...@chromium.org>
      Gerrit-Reviewer: David Roger <dro...@chromium.org>
      Gerrit-Reviewer: Jiacheng Guo <g...@google.com>
      Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
      Gerrit-Reviewer: Nico Weber <tha...@google.com>
      Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
      Gerrit-CC: Andrew Rayskiy <green...@google.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
      Gerrit-CC: Ryan Sultanem <rs...@google.com>
      Gerrit-CC: Shunya Shishido <sisid...@chromium.org>
      Gerrit-CC: Simon Hangl <sim...@google.com>
      Gerrit-Attention: Kouhei Ueno <kou...@chromium.org>
      Gerrit-Attention: Nico Weber <tha...@google.com>
      Gerrit-Attention: David Roger <dro...@chromium.org>
      Gerrit-Comment-Date: Wed, 09 Jul 2025 17:50:25 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      David Roger (Gerrit)

      unread,
      Jul 10, 2025, 7:15:21 AM7/10/25
      to Takashi Toyoshima, Kouhei Ueno, Nico Weber, Jiacheng Guo, Ryan Sultanem, Chromium LUCI CQ, Shunya Shishido, Rijubrata Bhaumik, Andrew Rayskiy, Simon Hangl, Chromium Metrics Reviews, AyeAye, chromiumme...@microsoft.com, loading-rev...@chromium.org, bmcquad...@chromium.org, print-rev...@chromium.org, asvitki...@chromium.org, cros-print...@google.com, speed-metrics...@chromium.org, speed-metr...@chromium.org, csharris...@chromium.org, headless...@chromium.org, feature-me...@chromium.org, rmcelra...@chromium.org, omnibox-...@chromium.org, chfreme...@chromium.org, jdonnel...@chromium.org, lingqi...@chromium.org, permissio...@chromium.org, tburkar...@chromium.org, prerenderi...@chromium.org, gavin...@chromium.org, jdeblas...@chromium.org, dibyapal+wa...@chromium.org, kuragin+web-ap...@chromium.org, dmurph+watc...@chromium.org, zelin+watch-we...@chromium.org, loyso...@chromium.org, extension...@chromium.org, webap...@microsoft.com, chromium-a...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, asvitkine...@chromium.org
      Attention needed from Nico Weber and Takashi Toyoshima

      David Roger voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Nico Weber
      • Takashi Toyoshima
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I2d315ec966e2190cf086bc0f38b11a6c2c19ccc1
      Gerrit-Change-Number: 6700901
      Gerrit-PatchSet: 30
      Gerrit-Owner: Takashi Toyoshima <toyo...@chromium.org>
      Gerrit-Reviewer: David Roger <dro...@chromium.org>
      Gerrit-Reviewer: Jiacheng Guo <g...@google.com>
      Gerrit-Reviewer: Nico Weber <tha...@google.com>
      Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
      Gerrit-CC: Andrew Rayskiy <green...@google.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Kouhei Ueno <kou...@chromium.org>
      Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
      Gerrit-CC: Ryan Sultanem <rs...@google.com>
      Gerrit-CC: Shunya Shishido <sisid...@chromium.org>
      Gerrit-CC: Simon Hangl <sim...@google.com>
      Gerrit-Attention: Nico Weber <tha...@google.com>
      Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
      Gerrit-Comment-Date: Thu, 10 Jul 2025 11:15:04 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Takashi Toyoshima (Gerrit)

      unread,
      Jul 11, 2025, 12:53:12 AM7/11/25
      to David Roger, Kouhei Ueno, Nico Weber, Jiacheng Guo, Ryan Sultanem, Chromium LUCI CQ, Shunya Shishido, Rijubrata Bhaumik, Andrew Rayskiy, Simon Hangl, Chromium Metrics Reviews, AyeAye, chromiumme...@microsoft.com, loading-rev...@chromium.org, bmcquad...@chromium.org, print-rev...@chromium.org, asvitki...@chromium.org, cros-print...@google.com, speed-metrics...@chromium.org, speed-metr...@chromium.org, csharris...@chromium.org, headless...@chromium.org, feature-me...@chromium.org, rmcelra...@chromium.org, omnibox-...@chromium.org, chfreme...@chromium.org, jdonnel...@chromium.org, lingqi...@chromium.org, permissio...@chromium.org, tburkar...@chromium.org, prerenderi...@chromium.org, gavin...@chromium.org, jdeblas...@chromium.org, dibyapal+wa...@chromium.org, kuragin+web-ap...@chromium.org, dmurph+watc...@chromium.org, zelin+watch-we...@chromium.org, loyso...@chromium.org, extension...@chromium.org, webap...@microsoft.com, chromium-a...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, asvitkine...@chromium.org
      Attention needed from Nico Weber

      Takashi Toyoshima voted and added 1 comment

      Votes added by Takashi Toyoshima

      Commit-Queue+2

      1 comment

      Patchset-level comments
      Takashi Toyoshima . resolved

      +Nico as EST //chrome OWNERS

      Takashi Toyoshima

      Done

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Nico Weber
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I2d315ec966e2190cf086bc0f38b11a6c2c19ccc1
      Gerrit-Change-Number: 6700901
      Gerrit-PatchSet: 30
      Gerrit-Owner: Takashi Toyoshima <toyo...@chromium.org>
      Gerrit-Reviewer: David Roger <dro...@chromium.org>
      Gerrit-Reviewer: Jiacheng Guo <g...@google.com>
      Gerrit-Reviewer: Nico Weber <tha...@google.com>
      Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
      Gerrit-CC: Andrew Rayskiy <green...@google.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Kouhei Ueno <kou...@chromium.org>
      Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
      Gerrit-CC: Ryan Sultanem <rs...@google.com>
      Gerrit-CC: Shunya Shishido <sisid...@chromium.org>
      Gerrit-CC: Simon Hangl <sim...@google.com>
      Gerrit-Attention: Nico Weber <tha...@google.com>
      Gerrit-Comment-Date: Fri, 11 Jul 2025 04:52:50 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Takashi Toyoshima <toyo...@chromium.org>
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Jul 11, 2025, 2:02:54 AM7/11/25
      to Takashi Toyoshima, David Roger, Kouhei Ueno, Nico Weber, Jiacheng Guo, Ryan Sultanem, Shunya Shishido, Rijubrata Bhaumik, Andrew Rayskiy, Simon Hangl, Chromium Metrics Reviews, AyeAye, chromiumme...@microsoft.com, loading-rev...@chromium.org, bmcquad...@chromium.org, print-rev...@chromium.org, asvitki...@chromium.org, cros-print...@google.com, speed-metrics...@chromium.org, speed-metr...@chromium.org, csharris...@chromium.org, headless...@chromium.org, feature-me...@chromium.org, rmcelra...@chromium.org, omnibox-...@chromium.org, chfreme...@chromium.org, jdonnel...@chromium.org, lingqi...@chromium.org, permissio...@chromium.org, tburkar...@chromium.org, prerenderi...@chromium.org, gavin...@chromium.org, jdeblas...@chromium.org, dibyapal+wa...@chromium.org, kuragin+web-ap...@chromium.org, dmurph+watc...@chromium.org, zelin+watch-we...@chromium.org, loyso...@chromium.org, extension...@chromium.org, webap...@microsoft.com, chromium-a...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, asvitkine...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      DSEPrewarm: Explicitly Disable DSE Prewarm in some browser tests

      As a preparation to add a DSE Prewarm entry to
      fieldtrial_testing_config.json, this patch disables DSE Prewarm
      explicitly in some affected browser tests.

      This is needed to suppress unexpected side effects to existing browser
      tests as the DSE Prewarm automatically creates a prerendering page in
      WebContents, it results in making existing expectation checks confused.
      Change-Id: I2d315ec966e2190cf086bc0f38b11a6c2c19ccc1
      Bug: 423465927
      Reviewed-by: Jiacheng Guo <g...@google.com>
      Commit-Queue: Takashi Toyoshima <toyo...@chromium.org>
      Reviewed-by: David Roger <dro...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1485381}
      Files:
      • M chrome/browser/controlled_frame/controlled_frame_permission_request_test_base.h
      • M chrome/browser/extensions/extension_apitest.h
      • M chrome/browser/headless/headless_mode_protocol_browsertest.h
      • M chrome/browser/lookalikes/lookalike_url_navigation_throttle_browsertest.cc
      • M chrome/browser/media/webrtc/display_media_access_handler_interactive_uitest.cc
      • M chrome/browser/metrics/usage_scenario/tab_usage_scenario_tracker_browsertest.cc
      • M chrome/browser/navigation_predictor/anchor_element_preloader_browsertest.cc
      • M chrome/browser/page_load_metrics/integration_tests/metric_integration_test.h
      • M chrome/browser/picture_in_picture/auto_picture_in_picture_tab_helper_browsertest.cc
      • M chrome/browser/picture_in_picture/document_picture_in_picture_window_controller_browsertest.cc
      • M chrome/browser/preloading/prefetch/no_state_prefetch/prerender_nostate_prefetch_browsertest.cc
      • M chrome/browser/preloading/prefetch/search_prefetch/search_prefetch_browser_test_base.h
      • M chrome/browser/preloading/prefetch/search_prefetch/search_preload_unified_browsertest.cc
      • M chrome/browser/printing/print_preview_dialog_controller_browsertest.cc
      • M chrome/browser/profiles/profile_keyed_service_browsertest.cc
      • M chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
      • M chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc
      • M chrome/browser/ssl/https_upgrades_browsertest.cc
      • M chrome/browser/task_manager/providers/web_contents/tab_contents_tag_browsertest.cc
      • M chrome/browser/ui/views/bookmarks/bookmark_bar_view_browsertest.cc
      • M chrome/browser/ui/views/location_bar/custom_tab_bar_view_browsertest.cc
      • M chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc
      • M chrome/browser/ui/views/site_data/page_specific_site_data_dialog_interactive_uitest.cc
      • M chrome/browser/ui/web_applications/app_browser_document_picture_in_picture_browsertest.cc
      • M chrome/browser/ui/web_applications/web_app_browsertest_base.h
      Change size: M
      Delta: 25 files changed, 150 insertions(+), 7 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by David Roger, +1 by Jiacheng Guo
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I2d315ec966e2190cf086bc0f38b11a6c2c19ccc1
      Gerrit-Change-Number: 6700901
      Gerrit-PatchSet: 31
      Gerrit-Owner: Takashi Toyoshima <toyo...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: David Roger <dro...@chromium.org>
      Gerrit-Reviewer: Jiacheng Guo <g...@google.com>
      Gerrit-Reviewer: Nico Weber <tha...@google.com>
      Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
      Gerrit-CC: Andrew Rayskiy <green...@google.com>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages