Revert "media: Fix non-standard url parameter in provisioning" [chromium/src : main]

0 views
Skip to first unread message

Xiaohan Wang (Gerrit)

unread,
Nov 12, 2025, 11:36:19 PM (6 hours ago) Nov 12
to Vikram Pasupathy, Chromium LUCI CQ, Vikram Pasupathy, AyeAye, feature-me...@chromium.org
Attention needed from Vikram Pasupathy and Vikram Pasupathy

Xiaohan Wang voted and added 2 comments

Votes added by Xiaohan Wang

Code-Review+1

2 comments

Commit Message
Line 11, Patchset 1 (Latest):Reason for revert: This modifies the non finch gated feature. Although
Xiaohan Wang . unresolved

This comment is odd to read. I don't know why "finch gated feature" matters here. Also, "finch" is an internal term.

Line 24, Patchset 1 (Latest):> Tested manually with flag enabled to verify it worked.
Xiaohan Wang . unresolved

I wonder how it worked and what we missed. Would be great to get to the bottom of the issue.

Open in Gerrit

Related details

Attention is currently required from:
  • Vikram Pasupathy
  • Vikram Pasupathy
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9a1835e28d888bfd7ce32c167404e4ea57b933fc
Gerrit-Change-Number: 7148942
Gerrit-PatchSet: 1
Gerrit-Owner: Vikram Pasupathy <vpasu...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Vikram Pasupathy <vpasu...@chromium.org>
Gerrit-Reviewer: Xiaohan Wang <xhw...@chromium.org>
Gerrit-Attention: Vikram Pasupathy <vpasu...@google.com>
Gerrit-Attention: Vikram Pasupathy <vpasu...@chromium.org>
Gerrit-Comment-Date: Thu, 13 Nov 2025 04:36:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages