[IAMF] Add IAMF support to MP4 parse and MIME types [chromium/src : main]

0 views
Skip to first unread message

Syed AbuTalib (Gerrit)

unread,
Jan 20, 2026, 6:07:02 PM (8 hours ago) Jan 20
to Thomas Guilbert, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Thomas Guilbert

Syed AbuTalib added 1 comment

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Syed AbuTalib . unresolved

Do not submit until ATL approval.

Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Guilbert
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4a61720fa6d84b242649e4547eeab301caf39cbd
Gerrit-Change-Number: 7452318
Gerrit-PatchSet: 6
Gerrit-Owner: Syed AbuTalib <low...@google.com>
Gerrit-Reviewer: Thomas Guilbert <tgui...@chromium.org>
Gerrit-Attention: Thomas Guilbert <tgui...@chromium.org>
Gerrit-Comment-Date: Tue, 20 Jan 2026 23:06:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Thomas Guilbert (Gerrit)

unread,
Jan 20, 2026, 6:34:22 PM (8 hours ago) Jan 20
to Syed AbuTalib, Thomas Guilbert, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Syed AbuTalib

Thomas Guilbert added 2 comments

File media/base/audio_codecs.h
Line 79, Patchset 6 (Latest):#if BUILDFLAG(ENABLE_PLATFORM_IAMF_AUDIO) || BUILDFLAG(ENABLE_IAMF_TOOLS)
Thomas Guilbert . unresolved

You could create a single flag which is enabled when either of these build arguments are enabled. We'd just have to make sure to not break downstream code in doing so.

Areas that are truly "platform IAMF"-only could still use `ENABLE_PLATFORM_IAMF_AUDIO` when needed.

File media/base/supported_types.cc
Line 413, Patchset 6 (Latest):bool IsDecoderIamfBuiltInAudioType() {
#if BUILDFLAG(ENABLE_PLATFORM_IAMF_AUDIO) || BUILDFLAG(ENABLE_IAMF_TOOLS)
return true;
#else
return false;
#endif // BUILDFLAG(ENABLE_PLATFORM_IAMF_AUDIO) || BUILDFLAG(ENABLE_IAMF_TOOLS)
}
Thomas Guilbert . unresolved

NIT: Could be `constexpr`

Open in Gerrit

Related details

Attention is currently required from:
  • Syed AbuTalib
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4a61720fa6d84b242649e4547eeab301caf39cbd
Gerrit-Change-Number: 7452318
Gerrit-PatchSet: 6
Gerrit-Owner: Syed AbuTalib <low...@google.com>
Gerrit-Reviewer: Thomas Guilbert <tgui...@chromium.org>
Gerrit-Attention: Syed AbuTalib <low...@google.com>
Gerrit-Comment-Date: Tue, 20 Jan 2026 23:34:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Syed AbuTalib (Gerrit)

unread,
Jan 20, 2026, 7:19:24 PM (7 hours ago) Jan 20
to Thomas Guilbert, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Thomas Guilbert

Syed AbuTalib added 2 comments

File media/base/audio_codecs.h
Line 79, Patchset 6:#if BUILDFLAG(ENABLE_PLATFORM_IAMF_AUDIO) || BUILDFLAG(ENABLE_IAMF_TOOLS)
Thomas Guilbert . resolved

You could create a single flag which is enabled when either of these build arguments are enabled. We'd just have to make sure to not break downstream code in doing so.

Areas that are truly "platform IAMF"-only could still use `ENABLE_PLATFORM_IAMF_AUDIO` when needed.

Syed AbuTalib

Created a single flag for this case. There was one specific case where `ENABLE_PLATFORM_IAMF_AUDIO` had to stay (mass prependingIADescriptors). Done.

File media/base/supported_types.cc
Line 413, Patchset 6:bool IsDecoderIamfBuiltInAudioType() {

#if BUILDFLAG(ENABLE_PLATFORM_IAMF_AUDIO) || BUILDFLAG(ENABLE_IAMF_TOOLS)
return true;
#else
return false;
#endif // BUILDFLAG(ENABLE_PLATFORM_IAMF_AUDIO) || BUILDFLAG(ENABLE_IAMF_TOOLS)
}
Thomas Guilbert . resolved

NIT: Could be `constexpr`

Syed AbuTalib

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Guilbert
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4a61720fa6d84b242649e4547eeab301caf39cbd
Gerrit-Change-Number: 7452318
Gerrit-PatchSet: 7
Gerrit-Owner: Syed AbuTalib <low...@google.com>
Gerrit-Reviewer: Thomas Guilbert <tgui...@chromium.org>
Gerrit-Attention: Thomas Guilbert <tgui...@chromium.org>
Gerrit-Comment-Date: Wed, 21 Jan 2026 00:19:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Guilbert <tgui...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Thomas Guilbert (Gerrit)

unread,
Jan 20, 2026, 8:43:19 PM (5 hours ago) Jan 20
to Syed AbuTalib, Thomas Guilbert, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Syed AbuTalib

Thomas Guilbert added 2 comments

File media/formats/mp4/mp4_stream_parser.cc
Line 546, Patchset 7 (Latest): channel_layout = CHANNEL_LAYOUT_DISCRETE;
Thomas Guilbert . unresolved

I know we added this for the prototype. I'm not sure that we want to default to DISCRETE without the rest of the prototype's code.

Leave as STEREO, and re-add as needed?

File media/media_options.gni
Line 167, Patchset 7 (Latest): enable_iamf_audio = enable_platform_iamf_audio || media_use_iamf
Thomas Guilbert . unresolved

Here, `use_iamf_tools` might be helpful, in letting us know that this is using `third_party/iamf_tools`, versus whatever the OS/Platform is already providing.

Open in Gerrit

Related details

Attention is currently required from:
  • Syed AbuTalib
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4a61720fa6d84b242649e4547eeab301caf39cbd
Gerrit-Change-Number: 7452318
Gerrit-PatchSet: 7
Gerrit-Owner: Syed AbuTalib <low...@google.com>
Gerrit-Reviewer: Thomas Guilbert <tgui...@chromium.org>
Gerrit-Attention: Syed AbuTalib <low...@google.com>
Gerrit-Comment-Date: Wed, 21 Jan 2026 01:43:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages