Create an interface for BwgService to allow for dependency injection. [chromium/src : main]

0 views
Skip to first unread message

Sebastien S-G (Gerrit)

unread,
10:13 AM (9 hours ago) 10:13 AM
to Yasaman Sedaghat, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Yasaman Sedaghat

Sebastien S-G added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Sebastien S-G . resolved

PTAL? First CL in the chain to add new tests

Open in Gerrit

Related details

Attention is currently required from:
  • Yasaman Sedaghat
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib8b529a0f15166bf8019687af1e7bceacb46eb58
Gerrit-Change-Number: 7725075
Gerrit-PatchSet: 4
Gerrit-Owner: Sebastien S-G <se...@chromium.org>
Gerrit-Reviewer: Sebastien S-G <se...@chromium.org>
Gerrit-Reviewer: Yasaman Sedaghat <yasa...@google.com>
Gerrit-Attention: Yasaman Sedaghat <yasa...@google.com>
Gerrit-Comment-Date: Thu, 02 Apr 2026 14:13:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Yasaman Sedaghat (Gerrit)

unread,
3:09 PM (5 hours ago) 3:09 PM
to Sebastien S-G, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Sebastien S-G

Yasaman Sedaghat voted and added 1 comment

Votes added by Yasaman Sedaghat

Code-Review+1

1 comment

File ios/chrome/browser/app_bar/coordinator/app_bar_mediator_unittest.mm
Line 122, Patchset 4 (Latest): gemini_service_ptr_ = std::make_unique<BwgServiceImpl>(
Yasaman Sedaghat . unresolved

shouldn't this be using the fake impl? are you planning to do it in a follow up cl?

Open in Gerrit

Related details

Attention is currently required from:
  • Sebastien S-G
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib8b529a0f15166bf8019687af1e7bceacb46eb58
    Gerrit-Change-Number: 7725075
    Gerrit-PatchSet: 4
    Gerrit-Owner: Sebastien S-G <se...@chromium.org>
    Gerrit-Reviewer: Sebastien S-G <se...@chromium.org>
    Gerrit-Reviewer: Yasaman Sedaghat <yasa...@google.com>
    Gerrit-Attention: Sebastien S-G <se...@chromium.org>
    Gerrit-Comment-Date: Thu, 02 Apr 2026 19:09:04 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Sebastien S-G (Gerrit)

    unread,
    3:24 PM (4 hours ago) 3:24 PM
    to Yasaman Sedaghat, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

    Sebastien S-G added 2 comments

    Patchset-level comments
    Sebastien S-G . resolved

    Thanks!

    File ios/chrome/browser/app_bar/coordinator/app_bar_mediator_unittest.mm
    Line 122, Patchset 4 (Latest): gemini_service_ptr_ = std::make_unique<BwgServiceImpl>(
    Yasaman Sedaghat . resolved

    shouldn't this be using the fake impl? are you planning to do it in a follow up cl?

    Sebastien S-G

    Yes I wanted to make this CL just about creating the interface, and then add the fake in the next CL and start using it.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ib8b529a0f15166bf8019687af1e7bceacb46eb58
      Gerrit-Change-Number: 7725075
      Gerrit-PatchSet: 4
      Gerrit-Owner: Sebastien S-G <se...@chromium.org>
      Gerrit-Reviewer: Sebastien S-G <se...@chromium.org>
      Gerrit-Reviewer: Yasaman Sedaghat <yasa...@google.com>
      Gerrit-Comment-Date: Thu, 02 Apr 2026 19:24:31 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Yasaman Sedaghat <yasa...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Rohit Rao (Gerrit)

      unread,
      4:48 PM (3 hours ago) 4:48 PM
      to Sebastien S-G, Rohit Rao, Yasaman Sedaghat, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
      Attention needed from Sebastien S-G

      Rohit Rao voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Sebastien S-G
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ib8b529a0f15166bf8019687af1e7bceacb46eb58
      Gerrit-Change-Number: 7725075
      Gerrit-PatchSet: 4
      Gerrit-Owner: Sebastien S-G <se...@chromium.org>
      Gerrit-Reviewer: Rohit Rao <rohi...@chromium.org>
      Gerrit-Reviewer: Sebastien S-G <se...@chromium.org>
      Gerrit-Reviewer: Yasaman Sedaghat <yasa...@google.com>
      Gerrit-Attention: Sebastien S-G <se...@chromium.org>
      Gerrit-Comment-Date: Thu, 02 Apr 2026 20:48:40 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages