[Discovery] Record MediaRouter.Ui.Dialog.LoadedWithData for Cast and GMC [chromium/src : main]
0 views
Skip to first unread message
Takumi Fujimoto (Gerrit)
Jul 4, 2024, 3:42:32 AM (yesterday) Jul 4
to Muyao Xu, AyeAye, Tricium, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, mfoltz...@chromium.org, asvitkine...@chromium.org, blundell+...@chromium.org, feature-me...@chromium.org, steimel+...@chromium.org
Attention needed from Muyao Xu
Takumi Fujimoto voted and added 1 comment![]( "Open in Gerrit")
Votes added by Takumi Fujimoto
| Code-Review | +1 |
1 comment
File chrome/browser/ui/global_media_controls/cast_device_list_host.cc
Line 197, Patchset 4 (Latest):
base::Time sinks_load_time = base::Time::Now();Takumi Fujimoto . unresolved
Nit: Is there any reason why we're not setting `sinks_load_time_` directly here?
Related details
Attention is currently required from:
- Muyao Xu
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Muyao Xu (Gerrit)
Jul 4, 2024, 10:17:43 AM (18 hours ago) Jul 4
to Takashi Toyoshima, Takumi Fujimoto, AyeAye, Tricium, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, mfoltz...@chromium.org, asvitkine...@chromium.org, blundell+...@chromium.org, feature-me...@chromium.org, steimel+...@chromium.org
Attention needed from Takashi Toyoshima
Muyao Xu added 1 comment![]( "Open in Gerrit")
File chrome/browser/ui/global_media_controls/cast_device_list_host.cc
Nit: Is there any reason why we're not setting `sinks_load_time_` directly here?
Attention is currently required from:
- Takashi Toyoshima
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Takashi Toyoshima (Gerrit)
2:00 AM (2 hours ago) 2:00 AM
to Muyao Xu, Takumi Fujimoto, AyeAye, Tricium, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, mfoltz...@chromium.org, asvitkine...@chromium.org, blundell+...@chromium.org, feature-me...@chromium.org, steimel+...@chromium.org
Attention needed from Muyao Xu
Takashi Toyoshima added 1 comment![]( "Open in Gerrit")
File components/media_router/browser/media_router_metrics.cc
Line 121, Patchset 5 (Latest):
UMA_HISTOGRAM_TIMES(kHistogramUiCastDialogLoadedWithData, delta);Takashi Toyoshima . unresolved
Can you check the histogram guideline to ensure if the macro version APIs are reasonable for your use cases?
Usually function versions are fast enough unless we call them inside a tight loop.
Maybe good to check other calls in this file
Related details
Attention is currently required from:
- Muyao Xu
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages