Don't issue ::Resume seeks to nonseekable demuxers [chromium/src : main]

0 views
Skip to first unread message

Dale Curtis (Gerrit)

unread,
Feb 11, 2026, 6:57:40 PM (9 hours ago) Feb 11
to Ted (Chromium) Meyer, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Ted (Chromium) Meyer

Dale Curtis added 2 comments

Patchset-level comments
File-level comment, Patchset 1:
Dale Curtis . unresolved

Is it possible to add an integration test for this behavior?

File media/base/pipeline_impl.cc
Line 553, Patchset 1: if (demuxer_->IsSeekable()) {
Dale Curtis . unresolved

Lets add a brief comment here explaining that non-seekable demuxers must issue a seek internally to resume playback. Should we short circuit anything in CompleteSeek too?

Open in Gerrit

Related details

Attention is currently required from:
  • Ted (Chromium) Meyer
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I35b388d5df8867827942db3f6165f0f250d55546
Gerrit-Change-Number: 7568459
Gerrit-PatchSet: 1
Gerrit-Owner: Ted (Chromium) Meyer <tmath...@chromium.org>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
Gerrit-Attention: Ted (Chromium) Meyer <tmath...@chromium.org>
Gerrit-Comment-Date: Wed, 11 Feb 2026 23:57:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages