[M143] Fix for optional video types in H.264 encoding on Android [chromium/src : refs/branch-heads/7499]

0 views
Skip to first unread message

Chrome Cherry Picker (Gerrit)

unread,
Nov 12, 2025, 5:31:07 PM (12 hours ago) Nov 12
to Mosa Morosev, AyeAye, feature-me...@chromium.org

Chrome Cherry Picker voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedLint
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7499
Gerrit-Change-Id: If2c8115b7a48ad11e2f532ef5af9a1fd6c4f2f50
Gerrit-Change-Number: 7147700
Gerrit-PatchSet: 2
Gerrit-Reviewer: Chrome Cherry Picker <chrome-che...@chops-service-accounts.iam.gserviceaccount.com>
Gerrit-CC: Mosa Morosev <mosam...@microsoft.com>
Gerrit-Comment-Date: Wed, 12 Nov 2025 22:31:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Nov 12, 2025, 5:32:17 PM (12 hours ago) Nov 12
to Chrome Cherry Picker, Mosa Morosev, AyeAye, feature-me...@chromium.org

Rubber Stamper voted

Bot-Commit+1
Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedLint
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7499
Gerrit-Change-Id: If2c8115b7a48ad11e2f532ef5af9a1fd6c4f2f50
Gerrit-Change-Number: 7147700
Gerrit-PatchSet: 2
Gerrit-Reviewer: Chrome Cherry Picker <chrome-che...@chops-service-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-CC: Mosa Morosev <mosam...@microsoft.com>
Gerrit-Comment-Date: Wed, 12 Nov 2025 22:32:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Nov 12, 2025, 7:01:16 PM (11 hours ago) Nov 12
to Chrome Cherry Picker, Mosa Morosev, AyeAye, feature-me...@chromium.org

Rubber Stamper voted

Bot-Commit+1
Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedLint
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7499
Gerrit-Change-Id: If2c8115b7a48ad11e2f532ef5af9a1fd6c4f2f50
Gerrit-Change-Number: 7147943
Gerrit-PatchSet: 2
Gerrit-Reviewer: Chrome Cherry Picker <chrome-che...@chops-service-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-CC: Mosa Morosev <mosam...@microsoft.com>
Gerrit-Comment-Date: Thu, 13 Nov 2025 00:01:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Nov 12, 2025, 8:43:44 PM (9 hours ago) Nov 12
to Chrome Cherry Picker, Mosa Morosev, Rubber Stamper, AyeAye, feature-me...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[M143] Fix for optional video types in H.264 encoding on Android

Original change's description:
> Fix for optional video types in H.264 encoding on Android
>
> A recent change disallowed optional video types for H.264 encoding,
> which introduced a regression in the MediaRecording API on Android.
> This CL restores the previous logic for optional video type checks.
>
> Bug: 458101572, 40519162
> Change-Id: If2c8115b7a48ad11e2f532ef5af9a1fd6c4f2f50
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7123961
> Reviewed-by: Hirokazu Honda <hi...@chromium.org>
> Reviewed-by: Dale Curtis <dalec...@chromium.org>
> Commit-Queue: Mosa Morosev <mosam...@microsoft.com>
> Cr-Commit-Position: refs/heads/main@{#1542831}

(cherry picked from commit fe859e0c9f9e8388fe9ec15bc85eeed391880e46)
Bug: 460090710,458101572,40519162
Change-Id: If2c8115b7a48ad11e2f532ef5af9a1fd6c4f2f50
Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7499@{#1545}
Cr-Branched-From: b30439823e5177773584139e72e0593e36863899-refs/heads/main@{#1536371}
Files:
  • M media/base/supported_types.cc
  • M media/base/supported_types_unittest.cc
Change size: S
Delta: 2 files changed, 9 insertions(+), 10 deletions(-)
Branch: refs/branch-heads/7499
Submit Requirements:
  • requirement satisfiedCode-Review: Bot-Commit+1 by Rubber Stamper
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7499
Gerrit-Change-Id: If2c8115b7a48ad11e2f532ef5af9a1fd6c4f2f50
Gerrit-Change-Number: 7147943
Gerrit-PatchSet: 3
Gerrit-Reviewer: Chrome Cherry Picker <chrome-che...@chops-service-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages