Update Actor Prototype page in ai_prototyping to use identifiers [chromium/src : main]
0 views
Skip to first unread message
Kirubel Aklilu (Gerrit)
Apr 1, 2026, 5:41:55 PM (yesterday) Apr 1
to Fikre Mengistu, Chromium LUCI CQ, AyeAye, feature-me...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Fikre Mengistu
Kirubel Aklilu added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Fikre Mengistu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fikre Mengistu (Gerrit)
1:26 PM (6 hours ago) 1:26 PM
to Kirubel Aklilu, Fikre Mengistu, Chromium LUCI CQ, AyeAye, feature-me...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Kirubel Aklilu
Fikre Mengistu voted and added 2 comments![]( "Open in Gerrit")
Votes added by Fikre Mengistu
| Code-Review | +1 |
2 comments
Patchset-level comments
File ios/chrome/browser/ai_prototyping/coordinator/ai_prototyping_mediator.mm
Line 629, Patchset 6 (Latest):
includeDebugData:(BOOL)includeDebugData {Fikre Mengistu . unresolved
Wrap the getFramesAndContentNodes call below in an `if (includeDebugData)` check.
Related details
Attention is currently required from:
- Kirubel Aklilu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kirubel Aklilu (Gerrit)
1:40 PM (6 hours ago) 1:40 PM
to Fikre Mengistu, Chromium LUCI CQ, AyeAye, feature-me...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Kirubel Aklilu added 1 comment![]( "Open in Gerrit")
File ios/chrome/browser/ai_prototyping/coordinator/ai_prototyping_mediator.mm
Wrap the getFramesAndContentNodes call below in an `if (includeDebugData)` check.
Kirubel Aklilu
Great catch! I forgot to actually use this param.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kirubel Aklilu (Gerrit)
1:40 PM (6 hours ago) 1:40 PM
to Fikre Mengistu, Chromium LUCI CQ, AyeAye, feature-me...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Kirubel Aklilu voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
2:46 PM (5 hours ago) 2:46 PM
to Kirubel Aklilu, Fikre Mengistu, AyeAye, feature-me...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
6 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: ios/chrome/browser/ai_prototyping/coordinator/ai_prototyping_mediator.mm
Insertions: 4, Deletions: 2.
@@ -657,8 +657,10 @@
std::unique_ptr<optimization_guide::proto::PageContext> page_context =
std::move(response.value());
- [weakSelf getFramesAndContentNodes:*page_context
- forConsumer:weakSelf.consumer];
+ if (includeDebugData) {
+ [weakSelf getFramesAndContentNodes:*page_context
+ forConsumer:weakSelf.consumer];
+ }
std::string serialized_proto = page_context->SerializeAsString();
```
Change information
Commit message:
Update Actor Prototype page in ai_prototyping to use identifiers
This will facilitate testing actuation on elements targeted by
(document_identifier, content_node_id).
Bug: b:498616729
Change-Id: I1a9c7ae066d6ab0f21f8925d49e264036a6a6964
Reviewed-by: Fikre Mengistu <fikrem...@chromium.org>
Commit-Queue: Kirubel Aklilu <kak...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1609395}
Files:
- M ios/chrome/browser/ai_prototyping/coordinator/ai_prototyping_mediator.mm
- M ios/chrome/browser/ai_prototyping/ui/ai_prototyping_actor_view_controller.h
- M ios/chrome/browser/ai_prototyping/ui/ai_prototyping_actor_view_controller.mm
- M ios/chrome/browser/ai_prototyping/ui/ai_prototyping_apc_view_controller.mm
- M ios/chrome/browser/ai_prototyping/ui/ai_prototyping_consumer.h
- M ios/chrome/browser/ai_prototyping/ui/ai_prototyping_mutator.h
- M ios/chrome/browser/ai_prototyping/ui/ai_prototyping_view_controller.mm
- M ios/chrome/browser/ai_prototyping/utils/json_action_parser.mm
Change size: L
Delta: 8 files changed, 546 insertions(+), 74 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Fikre Mengistu
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages