MFClear Deprecation: Remove MediaFoundation rendering FrameServer mode [chromium/src : main]
0 views
Skip to first unread message
Piet Schouten (Gerrit)
Oct 6, 2025, 5:23:28 PM (4 days ago) Oct 6
to Nic Williamson, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, asvitki...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org
Attention needed from Nic Williamson
Piet Schouten voted and added 1 comment![]( "Open in Gerrit")
Votes added by Piet Schouten
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Nic Williamson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nic Williamson (Gerrit)
Oct 7, 2025, 2:26:59 PM (3 days ago) Oct 7
to Dale Curtis, Sangbaek Park, Piet Schouten, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, asvitki...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org
Attention needed from Dale Curtis and Sangbaek Park
Nic Williamson added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Nic Williamson . resolved
Hey Dale/Sangbaek - This is the first (and likely largest) change to remove FrameServer mode from MFRenderer playback. Of note, I want to make sure I'm not breaking anything that might be used by PlayReady or DComp mode in general, but testing with Netflix and EME test pages seem to be working as expected.
Related details
Attention is currently required from:
- Dale Curtis
- Sangbaek Park
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Oct 7, 2025, 4:04:20 PM (3 days ago) Oct 7
to Nic Williamson, Sangbaek Park, Piet Schouten, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, asvitki...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org
Attention needed from Nic Williamson and Sangbaek Park
Dale Curtis added 4 comments![]( "Open in Gerrit")
Patchset-level comments
Dale Curtis . resolved
Thanks!
File media/mojo/clients/win/media_foundation_renderer_client.h
Line 105, Patchset 4 (Latest):
// media::VideoRendererSink::RenderCallback implementation.Dale Curtis . unresolved
Is this impl needed for the non frame server mode?
File media/mojo/mojom/renderer_extensions.mojom
Related details
Attention is currently required from:
- Nic Williamson
- Sangbaek Park
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Oct 7, 2025, 4:04:54 PM (3 days ago) Oct 7
to Nic Williamson, Sangbaek Park, Piet Schouten, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, asvitki...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org
Attention needed from Nic Williamson and Sangbaek Park
Dale Curtis voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dale Curtis
| Code-Review | +1 |
1 comment
Patchset-level comments
Dale Curtis . resolved
lgtm % comments. If you want to remove in a follow-up, use the TODO(crbug): Syntax.
Related details
Attention is currently required from:
- Nic Williamson
- Sangbaek Park
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sangbaek Park (Gerrit)
Oct 7, 2025, 7:44:05 PM (3 days ago) Oct 7
to Nic Williamson, Dale Curtis, Piet Schouten, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, asvitki...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org
Attention needed from Nic Williamson and Piet Schouten
Sangbaek Park voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Nic Williamson
- Piet Schouten
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nic Williamson (Gerrit)
Oct 8, 2025, 1:59:47 PM (2 days ago) Oct 8
to Sangbaek Park, Dale Curtis, Piet Schouten, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, asvitki...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org
Attention needed from Dale Curtis and Piet Schouten
Nic Williamson added 4 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 7 (Latest):
Nic Williamson . resolved
Thanks for taking a look! I've resolved comments.
File media/mojo/clients/win/media_foundation_renderer_client.h
Line 105, Patchset 4:
// media::VideoRendererSink::RenderCallback implementation.Dale Curtis . resolved
Is this impl needed for the non frame server mode?
Attention is currently required from:
- Dale Curtis
- Piet Schouten
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Oct 8, 2025, 2:35:07 PM (2 days ago) Oct 8
to Nic Williamson, Sangbaek Park, Piet Schouten, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, asvitki...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org
Attention needed from Nic Williamson and Piet Schouten
Dale Curtis voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Nic Williamson
- Piet Schouten
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sangbaek Park (Gerrit)
Oct 8, 2025, 2:49:59 PM (2 days ago) Oct 8
to Nic Williamson, Dale Curtis, Piet Schouten, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, asvitki...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org
Attention needed from Nic Williamson and Piet Schouten
Sangbaek Park voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Nic Williamson
- Piet Schouten
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Oct 9, 2025, 12:46:07 PM (2 days ago) Oct 9
to Nic Williamson, Sangbaek Park, Piet Schouten, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, asvitki...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org
Attention needed from Nic Williamson, Piet Schouten and Sangbaek Park
Dale Curtis voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Nic Williamson
- Piet Schouten
- Sangbaek Park
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Oct 9, 2025, 12:46:18 PM (2 days ago) Oct 9
to Nic Williamson, Sangbaek Park, Piet Schouten, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, asvitki...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org
Attention needed from Nic Williamson, Piet Schouten and Sangbaek Park
Dale Curtis added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Sangbaek Park (Gerrit)
Oct 9, 2025, 12:52:29 PM (2 days ago) Oct 9
to Nic Williamson, Chromium IPC Reviews, Dale Curtis, Piet Schouten, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, asvitki...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org
Attention needed from Chromium IPC Reviews, Nic Williamson and Piet Schouten
Sangbaek Park voted and added 1 comment![]( "Open in Gerrit")
Votes added by Sangbaek Park
| Code-Review | +1 |
1 comment
Patchset-level comments
Sangbaek Park . resolved
lgtm, thank you for doing this, Nic! I've added Chromium IPC reviewers for media/mojo/* paths.
Related details
Attention is currently required from:
- Chromium IPC Reviews
- Nic Williamson
- Piet Schouten
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Oct 9, 2025, 1:00:11 PM (2 days ago) Oct 9
to Nic Williamson, Chromium IPC Reviews, Camille Lamy, Sangbaek Park, Dale Curtis, Piet Schouten, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, asvitki...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org
Attention needed from Camille Lamy, Nic Williamson and Piet Schouten
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: cl...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): cl...@chromium.org
Reviewer source(s):
cl...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
Attention is currently required from:
- Camille Lamy
- Nic Williamson
- Piet Schouten
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Camille Lamy (Gerrit)
Oct 10, 2025, 5:47:54 AM (20 hours ago) Oct 10
to Nic Williamson, Chromium IPC Reviews, Sangbaek Park, Dale Curtis, Piet Schouten, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, asvitki...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org
Attention needed from Nic Williamson and Piet Schouten
Camille Lamy voted and added 1 comment![]( "Open in Gerrit")
Votes added by Camille Lamy
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Nic Williamson
- Piet Schouten
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nic Williamson (Gerrit)
Oct 10, 2025, 1:56:38 PM (12 hours ago) Oct 10
to Camille Lamy, Chromium IPC Reviews, Sangbaek Park, Dale Curtis, Piet Schouten, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, asvitki...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org
Attention needed from Piet Schouten
Nic Williamson voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Piet Schouten
Chromium LUCI CQ (Gerrit)
Oct 10, 2025, 3:52:08 PM (10 hours ago) Oct 10
to Nic Williamson, Camille Lamy, Chromium IPC Reviews, Sangbaek Park, Dale Curtis, Piet Schouten, chromium...@chromium.org, Rijubrata Bhaumik, asvitki...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
MFClear Deprecation: Remove MediaFoundation rendering FrameServer mode
This is the first major part of removing MediaFoundation for
Clear content support. This removes the bulk of the FrameServer
MF rendering mode, which is only used for clear content. DComp mode
is used for both MF Clear and MF PlayReady (DRM protected content)
support.
High-level changes:
* Removes the feature flags and about flags for choosing rendering mode.
* Removes the media_foundation_texture_pool and FramePool functions, which were used to provide shared textures for FrameServer mode.
* Removes media_foundation_rendering_mode and related mojo and functions.
* Simplifies media_foundation_renderer(_client) to assume DComp mode.
* Removes OverlayState observation code used for dynamically switching
between FrameServer and DComp modes.
* Removes code for reading frames from MF Renderer.
* Removes rendering code from MF RendererClient.
Bug: 448103582
Change-Id: I45802facb5796affd9ed81959c2c66e2563c30eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7008120
Reviewed-by: Dale Curtis <dalec...@chromium.org>
Reviewed-by: Sangbaek Park <sangba...@chromium.org>
Reviewed-by: Camille Lamy <cl...@chromium.org>
Commit-Queue: Nic Williamson <cham...@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1528310}
Files:
- M chrome/browser/about_flags.cc
- M content/renderer/media/media_factory.cc
- M media/base/media_switches.cc
- M media/base/media_switches.h
- M media/mojo/clients/win/media_foundation_renderer_client.cc
- M media/mojo/clients/win/media_foundation_renderer_client.h
- M media/mojo/clients/win/media_foundation_renderer_client_factory.cc
- M media/mojo/clients/win/media_foundation_renderer_client_factory.h
- M media/mojo/clients/win/media_foundation_renderer_client_unittest.cc
- M media/mojo/mojom/BUILD.gn
- D media/mojo/mojom/media_foundation_rendering_mode_mojom_traits.h
- M media/mojo/mojom/renderer_extensions.mojom
- M media/mojo/services/media_foundation_renderer_wrapper.cc
- M media/mojo/services/media_foundation_renderer_wrapper.h
- M media/renderers/BUILD.gn
- M media/renderers/win/media_foundation_renderer.cc
- M media/renderers/win/media_foundation_renderer.h
- M media/renderers/win/media_foundation_renderer_extension.h
- M media/renderers/win/media_foundation_renderer_unittest.cc
- D media/renderers/win/media_foundation_rendering_mode.cc
- D media/renderers/win/media_foundation_rendering_mode.h
- D media/renderers/win/media_foundation_texture_pool.cc
- D media/renderers/win/media_foundation_texture_pool.h
- D media/renderers/win/media_foundation_texture_pool_unittest.cc
Change size: XL
Delta: 24 files changed, 23 insertions(+), 1823 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dale Curtis, +1 by Sangbaek Park, +1 by Camille Lamy
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages