[DebugUITabStrip] TabStripInternals UI state storage [chromium/src : main]

0 views

Skip to first unread message

Brijesh Giri (Gerrit)

unread,

Jan 16, 2026, 6:59:05 PM (2 days ago) Jan 16

to Jerome Jiang, Mirko Bonadei, AyeAye, Darryl James, Atharv Maan, Chromium LUCI CQ, chromium...@chromium.org, penghuan...@chromium.org, cblume...@chromium.org, chrome-intelligence-te...@google.com, mar...@chromium.org, eme-r...@chromium.org, net-r...@chromium.org, jz...@chromium.org, chrome-intell...@chromium.org, fgal...@chromium.org, fuzzin...@chromium.org, feature-me...@chromium.org, devtools...@chromium.org

Attention needed from Atharv Maan

Brijesh Giri added 2 comments

File chrome/browser/resources/tab_strip_internals/tab_strip_internals_view.ts

Line 149, Patchset 6: private handleDividerKeydown_(e: KeyboardEvent) {

Atharv Maan . unresolved

I wonder what should be a good place to explain the keyboard shortcuts used for resizing, along with other ways of interacting with the UI?

Brijesh Giri

As of now, the only keyboard shortcuts supported are to move the divider of our split pane to the left or to the right via keyboard, assuming it is the currently selected element.

In future, we could potentially document it with an information icon that lets the user know about all the available shortcuts, in-case we do end-up adding more.

However, given that our UI is just a read-only view, I do not forsee us adding more shortcuts. Please let me know in-case my assumption is incorrect.

File chrome/browser/resources/tab_strip_internals/tab_strip_internals_viewmodel.ts

Line 147, Patchset 6: observer(change);

Atharv Maan . resolved

same comment as the previous CL, this is essentially a callback being run, not a Observer class.

Brijesh Giri

Have updated it.

Open in Gerrit

Related details

Attention is currently required from:

Atharv Maan

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Darryl James (Gerrit)

unread,

Jan 16, 2026, 7:14:14 PM (2 days ago) Jan 16

to net-r...@chromium.org, feature-me...@chromium.org, chrome-intell...@chromium.org, fgal...@chromium.org, penghuan...@chromium.org, fuzzin...@chromium.org, jz...@chromium.org, eme-r...@chromium.org, mar...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Atharv Maan and Brijesh Giri

Brijesh Giri has uploaded the change for review

Darryl James removed net-r...@chromium.org, feature-me...@chromium.org, chrome-intell...@chromium.org, fgal...@chromium.org, penghuan...@chromium.org, fuzzin...@chromium.org, jz...@chromium.org, eme-r...@chromium.org, mar...@chromium.org and chrome-intelligence-te...@google.com from reviewers of this change.

Commit message

[DebugUITabStrip] TabStripInternals UI state storage

This CL introduces Phase 3 of the 'tab-strip-internals' page, a debug
WebUI intended to visualize the live state of the TabStrip model.

Changes:
- Updated `tab_strip_internals_view.ts` to add event listeners
  for resizing the left/right pane
- Updated `tab_strip_internals_viewmodel.ts` to add support for
  savinga and restoring UI state from local storage
- Updated `tab-strip-internals.html` with new CSS styles

Project doc:
https://docs.google.com/document/d/1EKJicM4grBpp2nA4SOPzUvsKVLa_Ndj5L0HrIsGJNUI

Bug: 427204855

Change-Id: Ic2794020ca97baf3861dd8570e8610b6392b3bcd

Change diff

Change information

Files:

M chrome/browser/resources/tab_strip_internals/tab_strip_internals.html
M chrome/browser/resources/tab_strip_internals/tab_strip_internals_view.ts
M chrome/browser/resources/tab_strip_internals/tab_strip_internals_viewmodel.ts

Change size: L

Delta: 3 files changed, 249 insertions(+), 17 deletions(-)