[IOS][AIM] Add invocation source to the search url request info [chromium/src : main]

0 views
Skip to first unread message

Ameur Hosni (Gerrit)

unread,
Dec 23, 2025, 5:56:03 AM (5 days ago) Dec 23
to Jason Hu, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Jason Hu

Ameur Hosni voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jason Hu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifd21699f4c194db9b9eea220f650700daa8e0a8c
Gerrit-Change-Number: 7309365
Gerrit-PatchSet: 1
Gerrit-Owner: Ameur Hosni <ameur...@google.com>
Gerrit-Reviewer: Ameur Hosni <ameur...@google.com>
Gerrit-Reviewer: Jason Hu <huja...@google.com>
Gerrit-Attention: Jason Hu <huja...@google.com>
Gerrit-Comment-Date: Tue, 23 Dec 2025 10:55:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Ameur Hosni (Gerrit)

unread,
Dec 23, 2025, 6:00:11 AM (5 days ago) Dec 23
to Chromium LUCI CQ, Jason Hu, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Jason Hu

Ameur Hosni added 1 comment

File ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator.mm
Line 439, Patchset 1 (Latest): isNTP ? lens::LensOverlayInvocationSource::kNtpContextualQuery
: lens::LensOverlayInvocationSource::kOmniboxContextualQuery;
Ameur Hosni . unresolved

Jason, based on the naming here I'm not sure, should those be set only if there are attachments or should they always be set?

Open in Gerrit

Related details

Attention is currently required from:
  • Jason Hu
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifd21699f4c194db9b9eea220f650700daa8e0a8c
    Gerrit-Change-Number: 7309365
    Gerrit-PatchSet: 1
    Gerrit-Owner: Ameur Hosni <ameur...@google.com>
    Gerrit-Reviewer: Ameur Hosni <ameur...@google.com>
    Gerrit-Reviewer: Jason Hu <huja...@google.com>
    Gerrit-Attention: Jason Hu <huja...@google.com>
    Gerrit-Comment-Date: Tue, 23 Dec 2025 10:59:57 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Jason Hu (Gerrit)

    unread,
    Dec 23, 2025, 1:04:55 PM (4 days ago) Dec 23
    to Ameur Hosni, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
    Attention needed from Ameur Hosni

    Jason Hu voted and added 1 comment

    Votes added by Jason Hu

    Code-Review+1

    1 comment

    File ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator.mm
    Line 439, Patchset 1 (Latest): isNTP ? lens::LensOverlayInvocationSource::kNtpContextualQuery
    : lens::LensOverlayInvocationSource::kOmniboxContextualQuery;
    Ameur Hosni . resolved

    Jason, based on the naming here I'm not sure, should those be set only if there are attachments or should they always be set?

    Jason Hu

    Hey Ameur, good question - it's fine though! the invocation source will only attach the contextual source param to the search url if there is actually context. So this is correct. Thank you so much!!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ameur Hosni
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ifd21699f4c194db9b9eea220f650700daa8e0a8c
      Gerrit-Change-Number: 7309365
      Gerrit-PatchSet: 1
      Gerrit-Owner: Ameur Hosni <ameur...@google.com>
      Gerrit-Reviewer: Ameur Hosni <ameur...@google.com>
      Gerrit-Reviewer: Jason Hu <huja...@google.com>
      Gerrit-Attention: Ameur Hosni <ameur...@google.com>
      Gerrit-Comment-Date: Tue, 23 Dec 2025 18:04:47 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Ameur Hosni <ameur...@google.com>
      satisfied_requirement
      open
      diffy

      Ameur Hosni (Gerrit)

      unread,
      Dec 23, 2025, 1:37:46 PM (4 days ago) Dec 23
      to Jason Hu, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

      Ameur Hosni voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ifd21699f4c194db9b9eea220f650700daa8e0a8c
      Gerrit-Change-Number: 7309365
      Gerrit-PatchSet: 1
      Gerrit-Owner: Ameur Hosni <ameur...@google.com>
      Gerrit-Reviewer: Ameur Hosni <ameur...@google.com>
      Gerrit-Reviewer: Jason Hu <huja...@google.com>
      Gerrit-Comment-Date: Tue, 23 Dec 2025 18:37:24 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Dec 23, 2025, 1:44:14 PM (4 days ago) Dec 23
      to Ameur Hosni, Jason Hu, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      [IOS][AIM] Add invocation source to the search url request info
      Bug: 470999521
      Change-Id: Ifd21699f4c194db9b9eea220f650700daa8e0a8c
      Commit-Queue: Ameur Hosni <ameur...@google.com>
      Reviewed-by: Jason Hu <huja...@google.com>
      Cr-Commit-Position: refs/heads/main@{#1562249}
      Files:
      Change size: XS
      Delta: 1 file changed, 7 insertions(+), 0 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Jason Hu
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ifd21699f4c194db9b9eea220f650700daa8e0a8c
      Gerrit-Change-Number: 7309365
      Gerrit-PatchSet: 2
      Gerrit-Owner: Ameur Hosni <ameur...@google.com>
      Gerrit-Reviewer: Ameur Hosni <ameur...@google.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Jason Hu <huja...@google.com>
      open
      diffy
      satisfied_requirement

      Ameur Hosni (Gerrit)

      unread,
      Dec 24, 2025, 4:25:30 AM (4 days ago) Dec 24
      to Chromium LUCI CQ, Jason Hu, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

      Ameur Hosni has created a revert of this change

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: revert
      satisfied_requirement
      open
      diffy

      Ameur Hosni (Gerrit)

      unread,
      Dec 24, 2025, 4:32:11 AM (4 days ago) Dec 24
      to Radu Nitescu, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
      Attention needed from Radu Nitescu

      Ameur Hosni voted

      Auto-Submit+1
      Commit-Queue+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Radu Nitescu
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: If156dac0eabdce5fe0efd677603f2f101095de99
        Gerrit-Change-Number: 7320259
        Gerrit-PatchSet: 1
        Gerrit-Owner: Ameur Hosni <ameur...@google.com>
        Gerrit-Reviewer: Ameur Hosni <ameur...@google.com>
        Gerrit-Reviewer: Radu Nitescu <radun...@google.com>
        Gerrit-Attention: Radu Nitescu <radun...@google.com>
        Gerrit-Comment-Date: Wed, 24 Dec 2025 09:31:58 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Radu Nitescu (Gerrit)

        unread,
        Dec 24, 2025, 4:32:43 AM (4 days ago) Dec 24
        to Ameur Hosni, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
        Attention needed from Ameur Hosni

        Radu Nitescu voted Code-Review+1

        Code-Review+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Ameur Hosni
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: If156dac0eabdce5fe0efd677603f2f101095de99
          Gerrit-Change-Number: 7320259
          Gerrit-PatchSet: 1
          Gerrit-Owner: Ameur Hosni <ameur...@google.com>
          Gerrit-Reviewer: Ameur Hosni <ameur...@google.com>
          Gerrit-Reviewer: Radu Nitescu <radun...@google.com>
          Gerrit-Attention: Ameur Hosni <ameur...@google.com>
          Gerrit-Comment-Date: Wed, 24 Dec 2025 09:32:25 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy

          Ameur Hosni (Gerrit)

          unread,
          Dec 24, 2025, 5:42:13 AM (4 days ago) Dec 24
          to Radu Nitescu, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

          Ameur Hosni voted Commit-Queue+2

          Commit-Queue+2
          Open in Gerrit

          Related details

          Attention set is empty
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: If156dac0eabdce5fe0efd677603f2f101095de99
          Gerrit-Change-Number: 7320259
          Gerrit-PatchSet: 1
          Gerrit-Owner: Ameur Hosni <ameur...@google.com>
          Gerrit-Reviewer: Ameur Hosni <ameur...@google.com>
          Gerrit-Reviewer: Radu Nitescu <radun...@google.com>
          Gerrit-Comment-Date: Wed, 24 Dec 2025 10:41:51 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy

          Chromium LUCI CQ (Gerrit)

          unread,
          Dec 24, 2025, 5:45:32 AM (4 days ago) Dec 24
          to Ameur Hosni, Radu Nitescu, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

          Chromium LUCI CQ submitted the change

          Change information

          Commit message:
          [IOS][AIM] Add invocation source to the search url request info
          Bug: 470999521
          Change-Id: If156dac0eabdce5fe0efd677603f2f101095de99
          Auto-Submit: Ameur Hosni <ameur...@google.com>
          Commit-Queue: Ameur Hosni <ameur...@google.com>
          Reviewed-by: Radu Nitescu <radun...@google.com>
          Cr-Commit-Position: refs/heads/main@{#1562464}
          Files:
          Change size: XS
          Delta: 1 file changed, 2 insertions(+), 0 deletions(-)
          Branch: refs/heads/main
          Submit Requirements:
          • requirement satisfiedCode-Review: +1 by Radu Nitescu
          Open in Gerrit
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: merged
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: If156dac0eabdce5fe0efd677603f2f101095de99
          Gerrit-Change-Number: 7320259
          Gerrit-PatchSet: 2
          Gerrit-Owner: Ameur Hosni <ameur...@google.com>
          Gerrit-Reviewer: Ameur Hosni <ameur...@google.com>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-Reviewer: Radu Nitescu <radun...@google.com>
          open
          diffy
          satisfied_requirement
          Reply all
          Reply to author
          Forward
          0 new messages