[iOS] Add accessibility label and accessibility value in preset gallery [chromium/src : main]

0 views
Skip to first unread message

Robbie Gibson (Gerrit)

unread,
Sep 19, 2025, 6:37:25 PM (yesterday) Sep 19
to Pier-Alexandre Bouchard, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, srahim...@chromium.org
Attention needed from Pier-Alexandre Bouchard

Robbie Gibson added 1 comment

File ios/chrome/browser/home_customization/coordinator/home_customization_background_configuration_mediator.mm
Line 411, Patchset 2 (Latest): NSString* accessibilityName =
Robbie Gibson . unresolved

This mostly looks good. The only part I'm not sure about is the "selected" part. If the user selects an option after loading, what happens? Would the accessibility values be re-generated?

Do we need "selected" in the accessibility value if it's also in the cell's accessibility traits?

Open in Gerrit

Related details

Attention is currently required from:
  • Pier-Alexandre Bouchard
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id25a60f1f96bf8af5f9ff297e0f4418e2e0bd7df
Gerrit-Change-Number: 6970033
Gerrit-PatchSet: 2
Gerrit-Owner: Pier-Alexandre Bouchard <pabou...@google.com>
Gerrit-Reviewer: Robbie Gibson <rkgi...@google.com>
Gerrit-Attention: Pier-Alexandre Bouchard <pabou...@google.com>
Gerrit-Comment-Date: Fri, 19 Sep 2025 22:37:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages