IOSurface: Unify pixel format handling [chromium/src : main]
0 views
Skip to first unread message
ccameron chromium (Gerrit)
Jun 22, 2026, 2:37:23 PM (5 days ago) Jun 22
to ccameron chromium, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, media-cro...@chromium.org
Attention needed from Xiaohan Wang
ccameron chromium added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 11 (Latest):
ccameron chromium . resolved
ptal -- this is taking over some IOSurface work that dale started before break
Related details
Attention is currently required from:
- Xiaohan Wang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xiaohan Wang (Gerrit)
Jun 22, 2026, 3:39:32 PM (5 days ago) Jun 22
to ccameron chromium, Eugene Zemtsov, Sangwhan Moon, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, media-cro...@chromium.org
Attention needed from Eugene Zemtsov and ccameron chromium
Xiaohan Wang added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Eugene Zemtsov
- ccameron chromium
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eugene Zemtsov (Gerrit)
Jun 22, 2026, 11:03:54 PM (4 days ago) Jun 22
to ccameron chromium, Eugene Zemtsov, Sangwhan Moon, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, media-cro...@chromium.org
Attention needed from ccameron chromium
Eugene Zemtsov added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- ccameron chromium
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eugene Zemtsov (Gerrit)
Jun 23, 2026, 10:53:41 PM (3 days ago) Jun 23
to ccameron chromium, Eugene Zemtsov, Sangwhan Moon, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, media-cro...@chromium.org
Attention needed from ccameron chromium
Eugene Zemtsov added 3 comments![]( "Open in Gerrit")
File ui/gfx/mac/io_surface.cc
Line 54, Patchset 11 (Latest):
std::initializer_list<viz::SharedImageFormat> formats;Eugene Zemtsov . unresolved
I don't think `initializer_list` is intended to be used this way
Line 69, Patchset 11 (Latest):
const IOSurfaceFormatInfo kIOSurfaceFormats[] = {Eugene Zemtsov . unresolved
`base::MakeFixedFlatMap`?
Line 322, Patchset 11 (Latest):
CHECK(pixel_format);Eugene Zemtsov . unresolved
can this be triggered via GPU mojo interfaces?
Related details
Attention is currently required from:
- ccameron chromium
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
ccameron chromium (Gerrit)
Jun 25, 2026, 9:52:08 AM (2 days ago) Jun 25
to ccameron chromium, Eugene Zemtsov, Sangwhan Moon, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, media-cro...@chromium.org
Attention needed from Eugene Zemtsov
ccameron chromium added 4 comments![]( "Open in Gerrit")
Patchset-level comments
File ui/gfx/mac/io_surface.cc
Line 54, Patchset 11:
std::initializer_list<viz::SharedImageFormat> formats;Eugene Zemtsov . resolved
I don't think `initializer_list` is intended to be used this way
ccameron chromium
Changed to static array of std::optionals.
Line 69, Patchset 11:
const IOSurfaceFormatInfo kIOSurfaceFormats[] = {Eugene Zemtsov . resolved
ccameron chromium`base::MakeFixedFlatMap`?
Done
can this be triggered via GPU mojo interfaces?
ccameron chromium
The [previous implementation](https://source.chromium.org/chromium/chromium/src/+/main:ui/gfx/mac/io_surface.cc;l=80;drc=bb29301d3c4454339c59a0d00e65367347cf91f7) would CHECK more aggressively, so I didn't want to change existing behavior (beyond supporting more formats).
I added some debugging info in case this is hit inappropriately.
Related details
Attention is currently required from:
- Eugene Zemtsov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
ccameron chromium (Gerrit)
Jun 25, 2026, 10:06:58 AM (2 days ago) Jun 25
to ccameron chromium, Eugene Zemtsov, Sangwhan Moon, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, media-cro...@chromium.org
Attention needed from Eugene Zemtsov
ccameron chromium added 1 comment![]( "Open in Gerrit")
File ui/gfx/mac/io_surface.cc
Line 69, Patchset 11:
const IOSurfaceFormatInfo kIOSurfaceFormats[] = {Eugene Zemtsov . resolved
ccameron chromium`base::MakeFixedFlatMap`?
Done
ccameron chromium
These are listed in an order of priority, so that when asking "what IOSurface format corresponds to `viz::MultiPlaneFormat::kNV12`, you get the first one to show up (kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange), not kCVPixelFormatType_Lossless_420YpCbCr8BiPlanarVideoRange).
Related details
Attention is currently required from:
- Eugene Zemtsov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eugene Zemtsov (Gerrit)
Jun 25, 2026, 4:00:14 PM (2 days ago) Jun 25
to ccameron chromium, Eugene Zemtsov, Sangwhan Moon, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, media-cro...@chromium.org
Attention needed from ccameron chromium
Eugene Zemtsov voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- ccameron chromium
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
ccameron chromium (Gerrit)
Jun 26, 2026, 4:43:31 AM (yesterday) Jun 26
to ccameron chromium, Chromium IPC Reviews, Corentin Wallez, Eugene Zemtsov, Sangwhan Moon, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, media-cro...@chromium.org
Attention needed from Chromium IPC Reviews and Corentin Wallez
ccameron chromium added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Chromium IPC Reviews
- Corentin Wallez
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
ccameron chromium (Gerrit)
Jun 26, 2026, 4:44:39 AM (yesterday) Jun 26
to ccameron chromium, Khushal Sagar, Chromium IPC Reviews, Corentin Wallez, Eugene Zemtsov, Sangwhan Moon, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, media-cro...@chromium.org
Attention needed from Chromium IPC Reviews, Corentin Wallez and Khushal Sagar
ccameron chromium added 1 comment![]( "Open in Gerrit")
Patchset-level comments
ccameron chromium . resolved
+khushalsagar for third_party/blink OWNERship
Related details
Attention is currently required from:
- Chromium IPC Reviews
- Corentin Wallez
- Khushal Sagar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Jun 26, 2026, 4:46:50 AM (yesterday) Jun 26
to ccameron chromium, Chromium IPC Reviews, Kinuko Yasuda, Khushal Sagar, Corentin Wallez, Eugene Zemtsov, Sangwhan Moon, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, media-cro...@chromium.org
Attention needed from Corentin Wallez, Khushal Sagar and Kinuko Yasuda
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: kin...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): kin...@chromium.org
Reviewer source(s):
kin...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
Attention is currently required from:
- Corentin Wallez
- Khushal Sagar
- Kinuko Yasuda
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Corentin Wallez (Gerrit)
Jun 26, 2026, 6:05:24 AM (yesterday) Jun 26
to ccameron chromium, Chromium IPC Reviews, Kinuko Yasuda, Khushal Sagar, Eugene Zemtsov, Sangwhan Moon, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, media-cro...@chromium.org
Attention needed from Khushal Sagar, Kinuko Yasuda and ccameron chromium
Corentin Wallez voted and added 1 comment![]( "Open in Gerrit")
Votes added by Corentin Wallez
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Khushal Sagar
- Kinuko Yasuda
- ccameron chromium
ccameron chromium (Gerrit)
Jun 26, 2026, 6:06:41 AM (yesterday) Jun 26
to ccameron chromium, Corentin Wallez, Chromium IPC Reviews, Kinuko Yasuda, Khushal Sagar, Eugene Zemtsov, Sangwhan Moon, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, media-cro...@chromium.org
Attention needed from Khushal Sagar and Kinuko Yasuda
ccameron chromium added 1 comment![]( "Open in Gerrit")
Patchset-level comments
ccameron chromium . resolved
+dcheng for gpu/command_buffer/client/internal/mappable_buffer_io_surface.cc
Related details
Attention is currently required from:
- Khushal Sagar
- Kinuko Yasuda
ccameron chromium (Gerrit)
Jun 26, 2026, 6:06:58 AM (yesterday) Jun 26
to ccameron chromium, Daniel Cheng, Corentin Wallez, Chromium IPC Reviews, Khushal Sagar, Eugene Zemtsov, Sangwhan Moon, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, media-cro...@chromium.org
Attention needed from Daniel Cheng and Khushal Sagar
ccameron chromium added 1 comment![]( "Open in Gerrit")
Patchset-level comments
ccameron chromium . resolved
+dcheng for gpu/command_buffer/client/internal/mappable_buffer_io_surface.cc OWNERship
Related details
Attention is currently required from:
- Daniel Cheng
- Khushal Sagar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Khushal Sagar (Gerrit)
Jun 26, 2026, 5:15:05 PM (16 hours ago) Jun 26
to ccameron chromium, Daniel Cheng, Corentin Wallez, Chromium IPC Reviews, Eugene Zemtsov, Sangwhan Moon, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, media-cro...@chromium.org
Attention needed from Daniel Cheng and ccameron chromium
Khushal Sagar voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Daniel Cheng
- ccameron chromium
Reply all
Reply to author
Forward
0 new messages