[iOS][QD] Remove obsolete TODOs [chromium/src : main]

0 views
Skip to first unread message

Filipa Senra (Gerrit)

unread,
Dec 23, 2025, 10:08:32 AM (4 days ago) Dec 23
to Jérôme Lebel, AyeAye, ios-r...@chromium.org, marq+...@chromium.org, feature-me...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org, ios-revie...@chromium.org
Attention needed from Jérôme Lebel

Filipa Senra voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jérôme Lebel
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic953a806e490c466bc8fe72a6e03b282a4e6f0fb
Gerrit-Change-Number: 7310245
Gerrit-PatchSet: 2
Gerrit-Owner: Filipa Senra <fse...@google.com>
Gerrit-Reviewer: Filipa Senra <fse...@google.com>
Gerrit-Reviewer: Jérôme Lebel <jle...@chromium.org>
Gerrit-Attention: Jérôme Lebel <jle...@chromium.org>
Gerrit-Comment-Date: Tue, 23 Dec 2025 15:08:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jérôme Lebel (Gerrit)

unread,
Dec 23, 2025, 10:09:19 AM (4 days ago) Dec 23
to Filipa Senra, Chromium LUCI CQ, AyeAye, ios-r...@chromium.org, marq+...@chromium.org, feature-me...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org, ios-revie...@chromium.org
Attention needed from Filipa Senra

Jérôme Lebel voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Filipa Senra
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic953a806e490c466bc8fe72a6e03b282a4e6f0fb
    Gerrit-Change-Number: 7310245
    Gerrit-PatchSet: 2
    Gerrit-Owner: Filipa Senra <fse...@google.com>
    Gerrit-Reviewer: Filipa Senra <fse...@google.com>
    Gerrit-Reviewer: Jérôme Lebel <jle...@chromium.org>
    Gerrit-Attention: Filipa Senra <fse...@google.com>
    Gerrit-Comment-Date: Tue, 23 Dec 2025 15:09:04 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Jérôme Lebel (Gerrit)

    unread,
    Dec 23, 2025, 10:10:10 AM (4 days ago) Dec 23
    to Filipa Senra, Chromium LUCI CQ, AyeAye, ios-r...@chromium.org, marq+...@chromium.org, feature-me...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org, ios-revie...@chromium.org
    Attention needed from Filipa Senra

    Jérôme Lebel added 1 comment

    Commit Message
    Line 10, Patchset 2 (Latest):Fixed: 335387869, 365776279, 1026442
    Jérôme Lebel . unresolved

    This can be replaced with 40659754

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Filipa Senra
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ic953a806e490c466bc8fe72a6e03b282a4e6f0fb
      Gerrit-Change-Number: 7310245
      Gerrit-PatchSet: 2
      Gerrit-Owner: Filipa Senra <fse...@google.com>
      Gerrit-Reviewer: Filipa Senra <fse...@google.com>
      Gerrit-Reviewer: Jérôme Lebel <jle...@chromium.org>
      Gerrit-Attention: Filipa Senra <fse...@google.com>
      Gerrit-Comment-Date: Tue, 23 Dec 2025 15:09:48 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Jérôme Lebel (Gerrit)

      unread,
      Dec 23, 2025, 10:11:18 AM (4 days ago) Dec 23
      to Filipa Senra, Chromium LUCI CQ, AyeAye, ios-r...@chromium.org, marq+...@chromium.org, feature-me...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org, ios-revie...@chromium.org
      Attention needed from Filipa Senra

      Jérôme Lebel added 1 comment

      Commit Message
      Line 10, Patchset 2 (Latest):Fixed: 335387869, 365776279, 1026442
      Jérôme Lebel . unresolved

      This can be replaced with 40659754

      Jérôme Lebel

      Is there a reason to mention this bug? I don't see a todo about it, and this bug is already closed.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Filipa Senra
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ic953a806e490c466bc8fe72a6e03b282a4e6f0fb
      Gerrit-Change-Number: 7310245
      Gerrit-PatchSet: 2
      Gerrit-Owner: Filipa Senra <fse...@google.com>
      Gerrit-Reviewer: Filipa Senra <fse...@google.com>
      Gerrit-Reviewer: Jérôme Lebel <jle...@chromium.org>
      Gerrit-Attention: Filipa Senra <fse...@google.com>
      Gerrit-Comment-Date: Tue, 23 Dec 2025 15:10:58 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Jérôme Lebel <jle...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Filipa Senra (Gerrit)

      unread,
      Dec 23, 2025, 10:17:36 AM (4 days ago) Dec 23
      to Jérôme Lebel, Chromium LUCI CQ, AyeAye, ios-r...@chromium.org, marq+...@chromium.org, feature-me...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org, ios-revie...@chromium.org

      Filipa Senra voted and added 1 comment

      Votes added by Filipa Senra

      Auto-Submit+1
      Commit-Queue+1

      1 comment

      Commit Message
      Line 10, Patchset 2:Fixed: 335387869, 365776279, 1026442
      Jérôme Lebel . resolved

      This can be replaced with 40659754

      Jérôme Lebel

      Is there a reason to mention this bug? I don't see a todo about it, and this bug is already closed.

      Filipa Senra

      This was a typo, thanks!

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ic953a806e490c466bc8fe72a6e03b282a4e6f0fb
        Gerrit-Change-Number: 7310245
        Gerrit-PatchSet: 3
        Gerrit-Owner: Filipa Senra <fse...@google.com>
        Gerrit-Reviewer: Filipa Senra <fse...@google.com>
        Gerrit-Reviewer: Jérôme Lebel <jle...@chromium.org>
        Gerrit-Comment-Date: Tue, 23 Dec 2025 15:17:16 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Comment-In-Reply-To: Jérôme Lebel <jle...@chromium.org>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Christian Dullweber (Gerrit)

        unread,
        Dec 24, 2025, 5:37:50 AM (4 days ago) Dec 24
        to Filipa Senra, Jérôme Lebel, Chromium LUCI CQ, AyeAye, ios-r...@chromium.org, marq+...@chromium.org, feature-me...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org, ios-revie...@chromium.org
        Attention needed from Filipa Senra

        Christian Dullweber voted

        Code-Review+1
        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Filipa Senra
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ic953a806e490c466bc8fe72a6e03b282a4e6f0fb
        Gerrit-Change-Number: 7310245
        Gerrit-PatchSet: 3
        Gerrit-Owner: Filipa Senra <fse...@google.com>
        Gerrit-Reviewer: Christian Dullweber <dull...@chromium.org>
        Gerrit-Reviewer: Filipa Senra <fse...@google.com>
        Gerrit-Reviewer: Jérôme Lebel <jle...@chromium.org>
        Gerrit-Attention: Filipa Senra <fse...@google.com>
        Gerrit-Comment-Date: Wed, 24 Dec 2025 10:37:28 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        Dec 24, 2025, 5:41:08 AM (4 days ago) Dec 24
        to Filipa Senra, Christian Dullweber, Jérôme Lebel, AyeAye, ios-r...@chromium.org, marq+...@chromium.org, feature-me...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org, ios-revie...@chromium.org

        Chromium LUCI CQ submitted the change

        Change information

        Commit message:
        [iOS][QD] Remove obsolete TODOs
        Bug: 471197613
        Fixed: 335387869, 365776279, 40659754
        Change-Id: Ic953a806e490c466bc8fe72a6e03b282a4e6f0fb
        Auto-Submit: Filipa Senra <fse...@google.com>
        Reviewed-by: Christian Dullweber <dull...@chromium.org>
        Reviewed-by: Jérôme Lebel <jle...@chromium.org>
        Commit-Queue: Christian Dullweber <dull...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#1562463}
        Files:
        • M components/browsing_data/core/pref_names.cc
        • M components/browsing_data/core/pref_names.h
        • M ios/chrome/browser/browsing_data/model/browsing_data_remover_impl.h
        • M ios/chrome/browser/settings/ui_bundled/clear_browsing_data/coordinator/quick_delete_coordinator.mm
        • M ios/chrome/browser/settings/ui_bundled/clear_browsing_data/coordinator/quick_delete_mediator.mm
        Change size: S
        Delta: 5 files changed, 3 insertions(+), 10 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Jérôme Lebel, +1 by Christian Dullweber
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ic953a806e490c466bc8fe72a6e03b282a4e6f0fb
        Gerrit-Change-Number: 7310245
        Gerrit-PatchSet: 4
        Gerrit-Owner: Filipa Senra <fse...@google.com>
        Gerrit-Reviewer: Christian Dullweber <dull...@chromium.org>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages