Fix more IWYU issues [chromium/src : main]

0 views
Skip to first unread message

Victor Vianna (Gerrit)

unread,
Dec 5, 2025, 6:10:07 PM (2 days ago) Dec 5
to Daniel Cheng, AyeAye, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Hongchan Choi, Kaan Icer, Nate Chapin, (Julie)Jeongeun Kim, Hiroki Nakagawa, Hu, Ningxin, Permissions Reviews, Peter Beverloo, Peter Williamson, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Simon Hangl, James Maclean, Chromium LUCI CQ, agriev...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, lizeb...@chromium.org, yfriedm...@chromium.org, torne...@chromium.org, abigailbk...@google.com, alexmo...@chromium.org, amaliev+...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, antoniosarto...@chromium.org, apaselti...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, arthursonzog...@chromium.org, asumane...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chrome-waff...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-timi...@chromium.org, creis...@chromium.org, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-setti...@google.com, cros-system-ui-prod...@google.com, crostin...@chromium.org, csharris...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, dmurph+watc...@chromium.org, dmurph+watch...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, eic+...@google.com, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, giovax...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, horo+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdh+wa...@chromium.org, jdonnel...@chromium.org, jimmyxgong+f...@chromium.org, jkeitel+watch-...@google.com, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, lingqi...@chromium.org, liu+wa...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, marimatthew+watc...@google.com, marinacio...@chromium.org, marq+...@chromium.org, mdjone...@chromium.org, media-cro...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, michaelcheco+...@google.com, minap+watch-p...@google.com, mkwst+w...@chromium.org, mreichhoff+watc...@chromium.org, mtomas...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, njeunje+...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, olka+...@chromium.org, omnibox-...@chromium.org, ortuno+w...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, pmonett...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, storage...@chromium.org, suzukike...@chromium.org, svend+w...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tmartino+tran...@chromium.org, tote-eng...@google.com, tracing...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiaohui...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Daniel Cheng

Victor Vianna voted and added 1 comment

Votes added by Victor Vianna

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 16 (Latest):
Victor Vianna . resolved

ptal

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I490cd1630d813dd6f07e57fe31f7677076597884
Gerrit-Change-Number: 7228863
Gerrit-PatchSet: 16
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Hu, Ningxin <ningx...@intel.com>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Peter Williamson <pet...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Fri, 05 Dec 2025 23:10:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Dec 5, 2025, 8:48:53 PM (2 days ago) Dec 5
to Victor Vianna, Lei Zhang, Daniel Cheng, AyeAye, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Hongchan Choi, Kaan Icer, Nate Chapin, (Julie)Jeongeun Kim, Hiroki Nakagawa, Hu, Ningxin, Permissions Reviews, Peter Beverloo, Peter Williamson, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Simon Hangl, James Maclean, Chromium LUCI CQ, agriev...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, lizeb...@chromium.org, yfriedm...@chromium.org, torne...@chromium.org, abigailbk...@google.com, alexmo...@chromium.org, amaliev+...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, antoniosarto...@chromium.org, apaselti...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, arthursonzog...@chromium.org, asumane...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chrome-waff...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-timi...@chromium.org, creis...@chromium.org, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-setti...@google.com, cros-system-ui-prod...@google.com, crostin...@chromium.org, csharris...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, dmurph+watc...@chromium.org, dmurph+watch...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, eic+...@google.com, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, giovax...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, horo+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdh+wa...@chromium.org, jdonnel...@chromium.org, jimmyxgong+f...@chromium.org, jkeitel+watch-...@google.com, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, lingqi...@chromium.org, liu+wa...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, marimatthew+watc...@google.com, marinacio...@chromium.org, marq+...@chromium.org, mdjone...@chromium.org, media-cro...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, michaelcheco+...@google.com, minap+watch-p...@google.com, mkwst+w...@chromium.org, mreichhoff+watc...@chromium.org, mtomas...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, njeunje+...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, olka+...@chromium.org, omnibox-...@chromium.org, ortuno+w...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, pmonett...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, storage...@chromium.org, suzukike...@chromium.org, svend+w...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tmartino+tran...@chromium.org, tote-eng...@google.com, tracing...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiaohui...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Daniel Cheng and Victor Vianna

Lei Zhang added 2 comments

Patchset-level comments
File-level comment, Patchset 17 (Latest):
Lei Zhang . resolved

Just randomly looking around.

FWIW, if you want to split this CL and only do one include in 1 CL. e.g. All strcat.h, I can review some of these too.

File chrome/browser/glic/fre/glic_fre_controller_interactive_uitest.cc
Line 5, Patchset 17 (Latest):
Lei Zhang . unresolved

Extra newline here?

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
  • Victor Vianna
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I490cd1630d813dd6f07e57fe31f7677076597884
    Gerrit-Change-Number: 7228863
    Gerrit-PatchSet: 17
    Gerrit-Owner: Victor Vianna <victor...@google.com>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Victor Vianna <victor...@google.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Hongchan Choi <hong...@chromium.org>
    Gerrit-CC: Hu, Ningxin <ningx...@intel.com>
    Gerrit-CC: James Maclean <wjma...@chromium.org>
    Gerrit-CC: Jiewei Qian <q...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-CC: Lei Zhang <the...@chromium.org>
    Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Peter Williamson <pet...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Victor Vianna <victor...@google.com>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Sat, 06 Dec 2025 01:48:39 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Lei Zhang (Gerrit)

    unread,
    Dec 5, 2025, 8:50:02 PM (2 days ago) Dec 5
    to Victor Vianna, Lei Zhang, Daniel Cheng, AyeAye, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Hongchan Choi, Kaan Icer, Nate Chapin, (Julie)Jeongeun Kim, Hiroki Nakagawa, Hu, Ningxin, Permissions Reviews, Peter Beverloo, Peter Williamson, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Simon Hangl, James Maclean, Chromium LUCI CQ, agriev...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, lizeb...@chromium.org, yfriedm...@chromium.org, torne...@chromium.org, abigailbk...@google.com, alexmo...@chromium.org, amaliev+...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, antoniosarto...@chromium.org, apaselti...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, arthursonzog...@chromium.org, asumane...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chrome-waff...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-timi...@chromium.org, creis...@chromium.org, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-setti...@google.com, cros-system-ui-prod...@google.com, crostin...@chromium.org, csharris...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, dmurph+watc...@chromium.org, dmurph+watch...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, eic+...@google.com, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, giovax...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, horo+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdh+wa...@chromium.org, jdonnel...@chromium.org, jimmyxgong+f...@chromium.org, jkeitel+watch-...@google.com, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, lingqi...@chromium.org, liu+wa...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, marimatthew+watc...@google.com, marinacio...@chromium.org, marq+...@chromium.org, mdjone...@chromium.org, media-cro...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, michaelcheco+...@google.com, minap+watch-p...@google.com, mkwst+w...@chromium.org, mreichhoff+watc...@chromium.org, mtomas...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, njeunje+...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, olka+...@chromium.org, omnibox-...@chromium.org, ortuno+w...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, pmonett...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, storage...@chromium.org, suzukike...@chromium.org, svend+w...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tmartino+tran...@chromium.org, tote-eng...@google.com, tracing...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiaohui...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org
    Attention needed from Daniel Cheng and Victor Vianna

    Lei Zhang added 1 comment

    Patchset-level comments
    Lei Zhang . resolved

    Also, I see a red bot, but that may be due to one of my CLs that just got reverted.

    Gerrit-Comment-Date: Sat, 06 Dec 2025 01:49:49 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages