[Signin][Android] Rename WebSignin-related classes. [chromium/src : main]

0 views
Skip to first unread message

Samar Chehade (Gerrit)

unread,
May 13, 2026, 5:08:05 AM (5 days ago) May 13
to Chrome Signin Android Reviews, Jérôme Lebel, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, marq+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org
Attention needed from Chrome Signin Android Reviews and Jérôme Lebel

Samar Chehade added 3 comments

File chrome/browser/signin/android/signin_tracker_bridge.h
File-level comment, Patchset 15:
Samar Chehade . unresolved

To help with review: there is no logic change here, this is just a rename of web_signin_bridge.h, I'm not sure why it didn't get marked as such.

[Difftool](https://diff.googleplex.com/#key=rFwJI4o1ZjXw)

File chrome/browser/signin/android/signin_tracker_bridge.cc
File-level comment, Patchset 15:
Samar Chehade . unresolved

Ditto, this is a rename of web_signin_bridge.cc.

[Difftool for easier review](https://diff.googleplex.com/#key=tvukoUTbTOuk)

File chrome/browser/signin/services/android/java/src/org/chromium/chrome/browser/signin/services/SigninTrackerBridge.java
File-level comment, Patchset 15:
Samar Chehade . unresolved

Same here, this is a rename of WebSigninBridge.

[Difftool](https://diff.googleplex.com/#key=8fhSwA4knqkW)

Open in Gerrit

Related details

Attention is currently required from:
  • Chrome Signin Android Reviews
  • Jérôme Lebel
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ieaba3ec885fff79a8a1479693f188748750e9ca2
Gerrit-Change-Number: 7828692
Gerrit-PatchSet: 21
Gerrit-Owner: Samar Chehade <samarc...@google.com>
Gerrit-Reviewer: Chrome Signin Android Reviews <chrome-signin-...@google.com>
Gerrit-Reviewer: Jérôme Lebel <jle...@chromium.org>
Gerrit-Reviewer: Samar Chehade <samarc...@google.com>
Gerrit-Attention: Jérôme Lebel <jle...@chromium.org>
Gerrit-Attention: Chrome Signin Android Reviews <chrome-signin-...@google.com>
Gerrit-Comment-Date: Wed, 13 May 2026 09:07:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
May 13, 2026, 5:11:20 AM (5 days ago) May 13
to Samar Chehade, Chrome Signin Android Reviews, Lucia Giorgi, Liza Bipin, Jérôme Lebel, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, marq+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org
Attention needed from Jérôme Lebel, Liza Bipin and Lucia Giorgi

Message from gwsq

Shadowed: quac...@google.com

Reviewer source(s):
mlb...@google.com, quac...@google.com is from context(googleclient/chrome/chromium_gwsq/chrome/browser/signin/android/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Jérôme Lebel
  • Liza Bipin
  • Lucia Giorgi
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ieaba3ec885fff79a8a1479693f188748750e9ca2
Gerrit-Change-Number: 7828692
Gerrit-PatchSet: 21
Gerrit-Owner: Samar Chehade <samarc...@google.com>
Gerrit-Reviewer: Jérôme Lebel <jle...@chromium.org>
Gerrit-Reviewer: Liza Bipin <mlb...@google.com>
Gerrit-Reviewer: Lucia Giorgi <quac...@google.com>
Gerrit-Reviewer: Samar Chehade <samarc...@google.com>
Gerrit-CC: Chrome Signin Android Reviews <chrome-signin-...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Liza Bipin <mlb...@google.com>
Gerrit-Attention: Lucia Giorgi <quac...@google.com>
Gerrit-Attention: Jérôme Lebel <jle...@chromium.org>
Gerrit-Comment-Date: Wed, 13 May 2026 09:11:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Lucia Giorgi (Gerrit)

unread,
May 13, 2026, 7:08:25 AM (5 days ago) May 13
to Samar Chehade, Chrome Signin Android Reviews, Liza Bipin, Jérôme Lebel, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, marq+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org
Attention needed from Jérôme Lebel and Samar Chehade

Lucia Giorgi voted and added 1 comment

Votes added by Lucia Giorgi

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 21 (Latest):
Lucia Giorgi . resolved

LGTM!

Open in Gerrit

Related details

Attention is currently required from:
  • Jérôme Lebel
  • Samar Chehade
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ieaba3ec885fff79a8a1479693f188748750e9ca2
    Gerrit-Change-Number: 7828692
    Gerrit-PatchSet: 21
    Gerrit-Owner: Samar Chehade <samarc...@google.com>
    Gerrit-Reviewer: Jérôme Lebel <jle...@chromium.org>
    Gerrit-Reviewer: Liza Bipin <mlb...@google.com>
    Gerrit-Reviewer: Lucia Giorgi <quac...@google.com>
    Gerrit-Reviewer: Samar Chehade <samarc...@google.com>
    Gerrit-CC: Chrome Signin Android Reviews <chrome-signin-...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Samar Chehade <samarc...@google.com>
    Gerrit-Attention: Jérôme Lebel <jle...@chromium.org>
    Gerrit-Comment-Date: Wed, 13 May 2026 11:08:04 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Jérôme Lebel (Gerrit)

    unread,
    May 13, 2026, 7:56:47 AM (5 days ago) May 13
    to Samar Chehade, Lucia Giorgi, Chrome Signin Android Reviews, Liza Bipin, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, marq+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org
    Attention needed from Samar Chehade

    Jérôme Lebel voted and added 3 comments

    Votes added by Jérôme Lebel

    Code-Review+1

    3 comments

    File ios/chrome/browser/authentication/consistency_promo_signin/coordinator/consistency_promo_signin_mediator.h
    Line 89, Patchset 21 (Parent): trackWebSigninWithIdentityManager:(signin::IdentityManager*)identityManager
    Jérôme Lebel . unresolved

    Ideally this method should be renamed to `trackSigninWithIdentityManager:accountReconcilor:signinAccount:withCallback:withTimeout:.`

    File ios/chrome/browser/authentication/consistency_promo_signin/coordinator/consistency_promo_signin_mediator.mm
    Line 66, Patchset 21 (Latest): std::unique_ptr<signin::SigninTracker> _webSigninTracker;
    Jérôme Lebel . unresolved

    Please fix this WARNING reported by ios reviewer: Consider renaming the instance variable _webSigninTracker to _signinTracker to align with the new accessPoint-agnostic class name.

    Line 305, Patchset 21 (Latest):- (void)webSigninFinishedWithResult:(signin::SigninTracker::Result)result {
    Jérôme Lebel . unresolved

    Ideally, this should be renamed to `signinFinishedWithResult:`

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Samar Chehade
    Gerrit-Comment-Date: Wed, 13 May 2026 11:56:29 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Samar Chehade (Gerrit)

    unread,
    May 13, 2026, 9:26:13 AM (5 days ago) May 13
    to Chrome Signin Team, Jérôme Lebel, Lucia Giorgi, Chrome Signin Android Reviews, Liza Bipin, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, marq+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org
    Attention needed from Chrome Signin Team and Liza Bipin

    Samar Chehade added 4 comments

    Patchset-level comments
    File-level comment, Patchset 22 (Latest):
    Samar Chehade . resolved

    Adding chrome-signin-team@ for the components/ files.

    File ios/chrome/browser/authentication/consistency_promo_signin/coordinator/consistency_promo_signin_mediator.h
    Line 89, Patchset 21 (Parent): trackWebSigninWithIdentityManager:(signin::IdentityManager*)identityManager
    Jérôme Lebel . resolved

    Ideally this method should be renamed to `trackSigninWithIdentityManager:accountReconcilor:signinAccount:withCallback:withTimeout:.`

    Samar Chehade

    Done

    File ios/chrome/browser/authentication/consistency_promo_signin/coordinator/consistency_promo_signin_mediator.mm
    Line 66, Patchset 21: std::unique_ptr<signin::SigninTracker> _webSigninTracker;
    Jérôme Lebel . resolved

    Please fix this WARNING reported by ios reviewer: Consider renaming the instance variable _webSigninTracker to _signinTracker to align with the new accessPoint-agnostic class name.

    Samar Chehade

    Done

    Line 305, Patchset 21:- (void)webSigninFinishedWithResult:(signin::SigninTracker::Result)result {
    Jérôme Lebel . resolved

    Ideally, this should be renamed to `signinFinishedWithResult:`

    Samar Chehade

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Chrome Signin Team
    • Liza Bipin
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ieaba3ec885fff79a8a1479693f188748750e9ca2
    Gerrit-Change-Number: 7828692
    Gerrit-PatchSet: 22
    Gerrit-Owner: Samar Chehade <samarc...@google.com>
    Gerrit-Reviewer: Chrome Signin Team <chrome-sig...@google.com>
    Gerrit-Reviewer: Jérôme Lebel <jle...@chromium.org>
    Gerrit-Reviewer: Liza Bipin <mlb...@google.com>
    Gerrit-Reviewer: Lucia Giorgi <quac...@google.com>
    Gerrit-Reviewer: Samar Chehade <samarc...@google.com>
    Gerrit-CC: Chrome Signin Android Reviews <chrome-signin-...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Liza Bipin <mlb...@google.com>
    Gerrit-Attention: Chrome Signin Team <chrome-sig...@google.com>
    Gerrit-Comment-Date: Wed, 13 May 2026 13:25:53 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Jérôme Lebel <jle...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    gwsq (Gerrit)

    unread,
    May 13, 2026, 9:27:34 AM (5 days ago) May 13
    to Samar Chehade, Chrome Signin Team, Mihai Sardarescu, Jérôme Lebel, Lucia Giorgi, Chrome Signin Android Reviews, Liza Bipin, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, marq+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org
    Attention needed from Liza Bipin and Mihai Sardarescu

    Message from gwsq

    Shadowed: mlb...@google.com

    Reviewer source(s):
    mlb...@google.com, msa...@chromium.org is from context(googleclient/chrome/chromium_gwsq/components/signin/config.gwsq)

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Liza Bipin
    • Mihai Sardarescu
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ieaba3ec885fff79a8a1479693f188748750e9ca2
    Gerrit-Change-Number: 7828692
    Gerrit-PatchSet: 22
    Gerrit-Owner: Samar Chehade <samarc...@google.com>
    Gerrit-Reviewer: Jérôme Lebel <jle...@chromium.org>
    Gerrit-Reviewer: Liza Bipin <mlb...@google.com>
    Gerrit-Reviewer: Lucia Giorgi <quac...@google.com>
    Gerrit-Reviewer: Mihai Sardarescu <msa...@chromium.org>
    Gerrit-Reviewer: Samar Chehade <samarc...@google.com>
    Gerrit-CC: Chrome Signin Android Reviews <chrome-signin-...@google.com>
    Gerrit-CC: Chrome Signin Team <chrome-sig...@google.com>
    Gerrit-Attention: Mihai Sardarescu <msa...@chromium.org>
    Gerrit-Comment-Date: Wed, 13 May 2026 13:27:23 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Liza Bipin (Gerrit)

    unread,
    May 13, 2026, 11:30:50 AM (5 days ago) May 13
    to Samar Chehade, Chrome Signin Team, Mihai Sardarescu, Jérôme Lebel, Lucia Giorgi, Chrome Signin Android Reviews, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, marq+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org
    Attention needed from Mihai Sardarescu and Samar Chehade

    Liza Bipin added 1 comment

    File components/signin/public/browser/signin_tracker.h
    Line 23, Patchset 21:class SigninTracker : public IdentityManager::Observer,
    Liza Bipin . unresolved
    I feel this name is a bit too generic as "sign in" could refer to adding a primary account or web sign in. This class waits for cookies to be minted so `web_signin_tracker` seems accurate. 
     
    Do you have a particular use case for this class? Maybe we could come up with a different name based on that otherwise I think we should stick with `web_signin_tracker`
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Mihai Sardarescu
    • Samar Chehade
    Gerrit-Attention: Mihai Sardarescu <msa...@chromium.org>
    Gerrit-Attention: Samar Chehade <samarc...@google.com>
    Gerrit-Comment-Date: Wed, 13 May 2026 15:30:34 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Mihai Sardarescu (Gerrit)

    unread,
    May 13, 2026, 11:43:22 AM (5 days ago) May 13
    to Samar Chehade, Chrome Signin Team, Jérôme Lebel, Lucia Giorgi, Chrome Signin Android Reviews, Liza Bipin, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, marq+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org
    Attention needed from Samar Chehade

    Mihai Sardarescu added 1 comment

    Patchset-level comments
    Mihai Sardarescu . resolved

    As discussed offline, some renames in the components seem undesired (Liza already flagged them as well).

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Samar Chehade
    Gerrit-Attention: Samar Chehade <samarc...@google.com>
    Gerrit-Comment-Date: Wed, 13 May 2026 15:43:09 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Samar Chehade (Gerrit)

    unread,
    7:43 AM (2 hours ago) 7:43 AM
    to Jérôme Lebel, Chrome Signin Team, Mihai Sardarescu, Lucia Giorgi, Chrome Signin Android Reviews, Liza Bipin, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, marq+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org
    Attention needed from Samar Chehade

    Samar Chehade removed Jérôme Lebel from this change

    Deleted Reviewers:
    • Jérôme Lebel
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Samar Chehade
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: deleteReviewer
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ieaba3ec885fff79a8a1479693f188748750e9ca2
      Gerrit-Change-Number: 7828692
      Gerrit-PatchSet: 25
      Gerrit-Owner: Samar Chehade <samarc...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Samar Chehade (Gerrit)

      unread,
      8:14 AM (1 hour ago) 8:14 AM
      to Chrome Signin Team, Lucia Giorgi, Chrome Signin Android Reviews, Liza Bipin, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, marq+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org
      Attention needed from Liza Bipin

      Samar Chehade added 5 comments

      Patchset-level comments
      File-level comment, Patchset 27 (Latest):
      Samar Chehade . resolved

      Removing Mihai from reviewers as I think his ownership is no longer needed. Liza, would you mind taking a new look?

      File chrome/browser/signin/android/signin_tracker_bridge.h
      File-level comment, Patchset 15:
      Samar Chehade . resolved

      To help with review: there is no logic change here, this is just a rename of web_signin_bridge.h, I'm not sure why it didn't get marked as such.

      [Difftool](https://diff.googleplex.com/#key=rFwJI4o1ZjXw)

      Samar Chehade

      Acknowledged

      File chrome/browser/signin/android/signin_tracker_bridge.cc
      File-level comment, Patchset 15:
      Samar Chehade . resolved

      Ditto, this is a rename of web_signin_bridge.cc.

      [Difftool for easier review](https://diff.googleplex.com/#key=tvukoUTbTOuk)

      Samar Chehade

      Acknowledged

      File chrome/browser/signin/services/android/java/src/org/chromium/chrome/browser/signin/services/SigninTrackerBridge.java
      File-level comment, Patchset 15:
      Samar Chehade . resolved

      Same here, this is a rename of WebSigninBridge.

      [Difftool](https://diff.googleplex.com/#key=8fhSwA4knqkW)

      Samar Chehade

      Acknowledged

      File components/signin/public/browser/signin_tracker.h
      Line 23, Patchset 21:class SigninTracker : public IdentityManager::Observer,
      Liza Bipin . resolved
      I feel this name is a bit too generic as "sign in" could refer to adding a primary account or web sign in. This class waits for cookies to be minted so `web_signin_tracker` seems accurate. 
       
      Do you have a particular use case for this class? Maybe we could come up with a different name based on that otherwise I think we should stick with `web_signin_tracker`
      Samar Chehade

      Done

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Liza Bipin
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ieaba3ec885fff79a8a1479693f188748750e9ca2
        Gerrit-Change-Number: 7828692
        Gerrit-PatchSet: 27
        Gerrit-Owner: Samar Chehade <samarc...@google.com>
        Gerrit-Reviewer: Liza Bipin <mlb...@google.com>
        Gerrit-Reviewer: Lucia Giorgi <quac...@google.com>
        Gerrit-Reviewer: Samar Chehade <samarc...@google.com>
        Gerrit-CC: Chrome Signin Android Reviews <chrome-signin-...@google.com>
        Gerrit-CC: Chrome Signin Team <chrome-sig...@google.com>
        Gerrit-CC: gwsq
        Gerrit-Attention: Liza Bipin <mlb...@google.com>
        Gerrit-Comment-Date: Mon, 18 May 2026 12:13:49 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        Comment-In-Reply-To: Liza Bipin <mlb...@google.com>
        Comment-In-Reply-To: Samar Chehade <samarc...@google.com>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages