[//media] Add kHardwareVideoDevicePath to process switch propagation [chromium/src : main]
0 views
Skip to first unread message
Kramer Ge (Gerrit)
Feb 10, 2026, 4:45:21 PM (2 days ago) Feb 10
to Dale Curtis, Tom Sepez, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Colin Blundell, Dale Curtis and Tom Sepez
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Colin Blundell
- Dale Curtis
- Tom Sepez
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Feb 10, 2026, 4:53:08 PM (2 days ago) Feb 10
to Kramer Ge, Tom Sepez, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Colin Blundell, Kramer Ge and Tom Sepez
Dale Curtis voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Colin Blundell
- Kramer Ge
- Tom Sepez
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Feb 11, 2026, 3:12:35 AM (yesterday) Feb 11
to Kramer Ge, Colin Blundell, Dale Curtis, Tom Sepez, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Kramer Ge and Tom Sepez
Colin Blundell voted and added 2 comments![]( "Open in Gerrit")
Votes added by Colin Blundell
| Code-Review | +1 |
2 comments
Patchset-level comments
File media/gpu/chromeos/platform_video_frame_utils.cc
Line 175, Patchset 2 (Latest):
switches::kHardwareVideoDevicePath),Colin Blundell . unresolved
Could you add a comment about why the separate switch is necessary/what purpose it serves for Vaapi?
Related details
Attention is currently required from:
- Kramer Ge
- Tom Sepez
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Feb 11, 2026, 1:03:00 PM (15 hours ago) Feb 11
to Kramer Ge, Colin Blundell, Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Kramer Ge
Tom Sepez voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Kramer Ge
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Feb 11, 2026, 3:20:29 PM (12 hours ago) Feb 11
to Tom Sepez, Colin Blundell, Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Kramer Ge voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kramer Ge
| Commit-Queue | +2 |
1 comment
File media/gpu/chromeos/platform_video_frame_utils.cc
Could you add a comment about why the separate switch is necessary/what purpose it serves for Vaapi?
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 11, 2026, 5:05:18 PM (10 hours ago) Feb 11
to Kramer Ge, Tom Sepez, Colin Blundell, Dale Curtis, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: media/gpu/chromeos/platform_video_frame_utils.cc
Insertions: 1, Deletions: 0.
@@ -171,6 +171,7 @@
GbmDeviceWrapper() {
const auto dev_paths = std::to_array<base::FilePath>({
#if BUILDFLAG(USE_VAAPI)
+ // This switch only affects VAAPI, V4L2 does not use a unified device.
base::CommandLine::ForCurrentProcess()->GetSwitchValuePath(
switches::kHardwareVideoDevicePath),
#endif
```
Change information
Commit message:
[//media] Add kHardwareVideoDevicePath to process switch propagation
For gpu process and utility process to use the switch
--hardware-video-device-path to specify a different decode/encode device
than --render-node-override.
Fixed: 479126815
Change-Id: I82d75d46337a23d413bcab7c718932e4feabb3ac
Commit-Queue: Kramer Ge <fang...@chromium.org>
Reviewed-by: Tom Sepez <tse...@chromium.org>
Reviewed-by: Dale Curtis <dalec...@chromium.org>
Reviewed-by: Colin Blundell <blun...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1583508}
Files:
- M chrome/browser/ash/login/chrome_restart_request.cc
- M content/browser/gpu/gpu_process_host.cc
- M content/browser/service_host/utility_process_host.cc
- M media/gpu/chromeos/platform_video_frame_utils.cc
Change size: M
Delta: 4 files changed, 42 insertions(+), 27 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dale Curtis, +1 by Tom Sepez, +1 by Colin Blundell
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages