[Omnibox Next] Add min width to context menu [chromium/src : main]
0 views
Skip to first unread message
Marlon Facey (Gerrit)
Feb 6, 2026, 11:20:17 AM (6 days ago) Feb 6
to Khalid Peer, AyeAye, chromium...@chromium.org, chrome-intelligence-te...@google.com, chrome-intell...@chromium.org, cblume...@chromium.org, feature-me...@chromium.org, penghuan...@chromium.org, devtools...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Khalid Peer
Marlon Facey voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Khalid Peer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marlon Facey (Gerrit)
Feb 6, 2026, 11:22:15 AM (6 days ago) Feb 6
to Chromium LUCI CQ, Khalid Peer, AyeAye, chromium...@chromium.org, chrome-intelligence-te...@google.com, chrome-intell...@chromium.org, cblume...@chromium.org, feature-me...@chromium.org, penghuan...@chromium.org, devtools...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Khalid Peer
Marlon Facey voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Khalid Peer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Khalid Peer (Gerrit)
Feb 6, 2026, 12:29:47 PM (6 days ago) Feb 6
to Marlon Facey, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chrome-intelligence-te...@google.com, chrome-intell...@chromium.org, cblume...@chromium.org, feature-me...@chromium.org, penghuan...@chromium.org, devtools...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Marlon Facey
Khalid Peer added 1 comment![]( "Open in Gerrit")
File chrome/browser/ui/views/omnibox/omnibox_context_menu.cc
Line 52, Patchset 4 (Latest):
menu_->GetSubmenu()->set_minimum_preferred_width(320);Khalid Peer . unresolved
Do you know why we're seeing a segmentation fault in some of the tests?
Related details
Attention is currently required from:
- Marlon Facey
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Khalid Peer (Gerrit)
Feb 6, 2026, 12:38:39 PM (6 days ago) Feb 6
to Marlon Facey, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chrome-intelligence-te...@google.com, chrome-intell...@chromium.org, cblume...@chromium.org, feature-me...@chromium.org, penghuan...@chromium.org, devtools...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Marlon Facey
Khalid Peer added 1 comment![]( "Open in Gerrit")
File chrome/browser/ui/views/omnibox/omnibox_context_menu.cc
Line 52, Patchset 4 (Latest):
menu_->GetSubmenu()->set_minimum_preferred_width(320);Khalid Peer . unresolved
Do you know why we're seeing a segmentation fault in some of the tests?
Khalid Peer
Here's a potential alternative approach suggested by Duckie: http://shortn/_VvxBSdYN5B (not sure if it will work though...)
Khalid Peer (Gerrit)
Feb 11, 2026, 1:19:30 PM (14 hours ago) Feb 11
to Marlon Facey, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chrome-intelligence-te...@google.com, chrome-intell...@chromium.org, cblume...@chromium.org, feature-me...@chromium.org, penghuan...@chromium.org, devtools...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Marlon Facey
Khalid Peer added 1 comment![]( "Open in Gerrit")
File chrome/browser/ui/views/omnibox/omnibox_context_menu.cc
Line 56, Patchset 4 (Latest):
return 400;Khalid Peer . unresolved
Should we also update this to `320` while we're at it (since the menu needs to be **exactly** 320 px wide as far as UX is concerned)?
Marlon Facey (Gerrit)
Feb 11, 2026, 1:23:19 PM (14 hours ago) Feb 11
to Chromium LUCI CQ, Khalid Peer, AyeAye, chromium...@chromium.org, chrome-intelligence-te...@google.com, chrome-intell...@chromium.org, cblume...@chromium.org, feature-me...@chromium.org, penghuan...@chromium.org, devtools...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Khalid Peer
Marlon Facey added 2 comments![]( "Open in Gerrit")
File chrome/browser/ui/views/omnibox/omnibox_context_menu.cc
Line 52, Patchset 4 (Latest):
menu_->GetSubmenu()->set_minimum_preferred_width(320);Khalid Peer . unresolved
Khalid PeerDo you know why we're seeing a segmentation fault in some of the tests?
Here's a potential alternative approach suggested by Duckie: http://shortn/_VvxBSdYN5B (not sure if it will work though...)
Marlon Facey
Ahh ok that seems like a possibility. Let me try Duckie's suggestion.
Line 56, Patchset 4 (Latest):
return 400;Khalid Peer . unresolved
Should we also update this to `320` while we're at it (since the menu needs to be **exactly** 320 px wide as far as UX is concerned)?
Marlon Facey
Oh I didn't realize they wanted exactly 320. Yup I'll update that as well.
Related details
Attention is currently required from:
- Khalid Peer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marlon Facey (Gerrit)
Feb 11, 2026, 4:20:27 PM (11 hours ago) Feb 11
to Chromium LUCI CQ, Khalid Peer, AyeAye, chromium...@chromium.org, chrome-intelligence-te...@google.com, chrome-intell...@chromium.org, cblume...@chromium.org, feature-me...@chromium.org, penghuan...@chromium.org, devtools...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Khalid Peer
Marlon Facey voted and added 2 comments![]( "Open in Gerrit")
Votes added by Marlon Facey
| Commit-Queue | +1 |
2 comments
File chrome/browser/ui/views/omnibox/omnibox_context_menu.cc
Khalid PeerDo you know why we're seeing a segmentation fault in some of the tests?
Marlon FaceyHere's a potential alternative approach suggested by Duckie: http://shortn/_VvxBSdYN5B (not sure if it will work though...)
Ahh ok that seems like a possibility. Let me try Duckie's suggestion.
Marlon Facey
Done
Marlon FaceyShould we also update this to `320` while we're at it (since the menu needs to be **exactly** 320 px wide as far as UX is concerned)?
Oh I didn't realize they wanted exactly 320. Yup I'll update that as well.
Marlon Facey
Done
Related details
Attention is currently required from:
- Khalid Peer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Khalid Peer (Gerrit)
Feb 11, 2026, 4:29:10 PM (11 hours ago) Feb 11
to Marlon Facey, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, chrome-intelligence-te...@google.com, chrome-intell...@chromium.org, cblume...@chromium.org, feature-me...@chromium.org, penghuan...@chromium.org, devtools...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Marlon Facey
Khalid Peer voted and added 1 comment![]( "Open in Gerrit")
Votes added by Khalid Peer
| Code-Review | +1 |
1 comment
File ui/views/controls/menu/menu_item_view.h
Line 446, Patchset 5 (Latest):
static std::u16string GetNewBadgeAccessibleDescription();Khalid Peer . unresolved
Is this necessary for the sake of this CL?
Related details
Attention is currently required from:
- Marlon Facey
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marlon Facey (Gerrit)
Feb 11, 2026, 4:41:13 PM (11 hours ago) Feb 11
to Khalid Peer, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, chrome-intelligence-te...@google.com, chrome-intell...@chromium.org, cblume...@chromium.org, feature-me...@chromium.org, penghuan...@chromium.org, devtools...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Khalid Peer
Marlon Facey voted and added 1 comment![]( "Open in Gerrit")
Votes added by Marlon Facey
| Commit-Queue | +1 |
1 comment
File ui/views/controls/menu/menu_item_view.h
Line 446, Patchset 5:
static std::u16string GetNewBadgeAccessibleDescription();Khalid Peer . resolved
Is this necessary for the sake of this CL?
Marlon Facey
Oh woops. This is from rebasing. I guess it remained in this CL. Removing.
Related details
Attention is currently required from:
- Khalid Peer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Khalid Peer (Gerrit)
Feb 11, 2026, 4:42:29 PM (11 hours ago) Feb 11
to Marlon Facey, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, chrome-intelligence-te...@google.com, chrome-intell...@chromium.org, cblume...@chromium.org, feature-me...@chromium.org, penghuan...@chromium.org, devtools...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Marlon Facey
Khalid Peer voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Marlon Facey
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marlon Facey (Gerrit)
Feb 11, 2026, 6:04:10 PM (9 hours ago) Feb 11
to Khalid Peer, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, chrome-intelligence-te...@google.com, chrome-intell...@chromium.org, cblume...@chromium.org, feature-me...@chromium.org, penghuan...@chromium.org, devtools...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Marlon Facey voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 11, 2026, 6:08:53 PM (9 hours ago) Feb 11
to Marlon Facey, Khalid Peer, AyeAye, chromium...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, chrome-intelligence-te...@google.com, chrome-intell...@chromium.org, cblume...@chromium.org, feature-me...@chromium.org, penghuan...@chromium.org, devtools...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Omnibox Next] Add min width to context menu
Make the min width of the context menu 320px.
Screenshot: http://screenshot/5CXCnjebYFtAuFt
Bug: 482076292
Change-Id: I1193ac5b918da8b6e3aea984e2c59cd1bbbc1bad
Reviewed-by: Khalid Peer <khali...@chromium.org>
Commit-Queue: Marlon Facey <mfa...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1583555}
Files:
- M chrome/browser/ui/views/omnibox/omnibox_context_menu.cc
Change size: XS
Delta: 1 file changed, 5 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Khalid Peer
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages