Settings Lit: Migrate performance_page/, part 7. [chromium/src : main]

0 views
Skip to first unread message

Demetrios Papadopoulos (Gerrit)

unread,
Aug 4, 2026, 2:01:57 PM (17 hours ago) Aug 4
to Rebekah Potter, Charles Meng, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, feature-me...@chromium.org, steimel+...@chromium.org
Attention needed from Rebekah Potter

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Rebekah Potter
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I69d5395d9ab9f217459661145a5fef3ce669f25d
Gerrit-Change-Number: 8190160
Gerrit-PatchSet: 8
Gerrit-Owner: Demetrios Papadopoulos <dpa...@chromium.org>
Gerrit-Reviewer: Demetrios Papadopoulos <dpa...@chromium.org>
Gerrit-Reviewer: Rebekah Potter <rbpo...@chromium.org>
Gerrit-CC: Charles Meng <charl...@chromium.org>
Gerrit-Attention: Rebekah Potter <rbpo...@chromium.org>
Gerrit-Comment-Date: Tue, 04 Aug 2026 18:01:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Rebekah Potter (Gerrit)

unread,
Aug 4, 2026, 7:20:38 PM (12 hours ago) Aug 4
to Demetrios Papadopoulos, Charles Meng, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, feature-me...@chromium.org, steimel+...@chromium.org
Attention needed from Demetrios Papadopoulos

Rebekah Potter voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Demetrios Papadopoulos
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I69d5395d9ab9f217459661145a5fef3ce669f25d
    Gerrit-Change-Number: 8190160
    Gerrit-PatchSet: 8
    Gerrit-Owner: Demetrios Papadopoulos <dpa...@chromium.org>
    Gerrit-Reviewer: Demetrios Papadopoulos <dpa...@chromium.org>
    Gerrit-Reviewer: Rebekah Potter <rbpo...@chromium.org>
    Gerrit-CC: Charles Meng <charl...@chromium.org>
    Gerrit-Attention: Demetrios Papadopoulos <dpa...@chromium.org>
    Gerrit-Comment-Date: Tue, 04 Aug 2026 23:20:25 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Demetrios Papadopoulos (Gerrit)

    unread,
    5:26 AM (2 hours ago) 5:26 AM
    to Rebekah Potter, Charles Meng, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, feature-me...@chromium.org, steimel+...@chromium.org

    Demetrios Papadopoulos voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I69d5395d9ab9f217459661145a5fef3ce669f25d
    Gerrit-Change-Number: 8190160
    Gerrit-PatchSet: 10
    Gerrit-Owner: Demetrios Papadopoulos <dpa...@chromium.org>
    Gerrit-Reviewer: Demetrios Papadopoulos <dpa...@chromium.org>
    Gerrit-Reviewer: Rebekah Potter <rbpo...@chromium.org>
    Gerrit-CC: Charles Meng <charl...@chromium.org>
    Gerrit-Comment-Date: Wed, 05 Aug 2026 09:26:14 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    5:37 AM (2 hours ago) 5:37 AM
    to Demetrios Papadopoulos, Rebekah Potter, Charles Meng, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, feature-me...@chromium.org, steimel+...@chromium.org

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    8 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    Settings Lit: Migrate performance_page/, part 7.

    In this part migrating exception_list.ts and exception_current_sites_list.ts.
    Bug: 393471368
    Change-Id: I69d5395d9ab9f217459661145a5fef3ce669f25d
    Commit-Queue: Demetrios Papadopoulos <dpa...@chromium.org>
    Reviewed-by: Rebekah Potter <rbpo...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1673993}
    Files:
    • M chrome/browser/resources/settings/BUILD.gn
    • A chrome/browser/resources/settings/performance_page/tab_discard/exception_current_sites_list.css
    • M chrome/browser/resources/settings/performance_page/tab_discard/exception_current_sites_list.html
    • M chrome/browser/resources/settings/performance_page/tab_discard/exception_current_sites_list.ts
    • A chrome/browser/resources/settings/performance_page/tab_discard/exception_list.css
    • M chrome/browser/resources/settings/performance_page/tab_discard/exception_list.html
    • M chrome/browser/resources/settings/performance_page/tab_discard/exception_list.ts
    • A chrome/browser/resources/settings/tooltip_mixin_lit.ts
    • M chrome/test/data/webui/settings/performance_page_test.ts
    Change size: L
    Delta: 9 files changed, 270 insertions(+), 218 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Rebekah Potter
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I69d5395d9ab9f217459661145a5fef3ce669f25d
    Gerrit-Change-Number: 8190160
    Gerrit-PatchSet: 11
    Gerrit-Owner: Demetrios Papadopoulos <dpa...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Demetrios Papadopoulos <dpa...@chromium.org>
    Gerrit-Reviewer: Rebekah Potter <rbpo...@chromium.org>
    Gerrit-CC: Charles Meng <charl...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages