[143][context-input] Update cluster info lifecycle for query controller [chromium/src : refs/branch-heads/7499]
0 views
Skip to first unread message
manuk hovanesian (Gerrit)
Nov 12, 2025, 3:02:16 PM (15 hours ago) Nov 12
to Justin Donnelly, Chromium LUCI CQ, chromium...@chromium.org, ananyasee...@google.com, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, niharm...@google.com, omnibox-...@chromium.org
Attention needed from Justin Donnelly
manuk hovanesian voted and added 1 comment![]( "Open in Gerrit")
Votes added by manuk hovanesian
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Justin Donnelly
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Duncan Mercer (Gerrit)
Nov 12, 2025, 3:02:19 PM (15 hours ago) Nov 12
to Justin Donnelly, manuk hovanesian, Chromium LUCI CQ, chromium...@chromium.org, ananyasee...@google.com, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, niharm...@google.com, omnibox-...@chromium.org
Attention needed from Justin Donnelly
Duncan Mercer voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Justin Donnelly
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Nov 12, 2025, 3:07:10 PM (14 hours ago) Nov 12
to Justin Donnelly, Lei Zhang, Duncan Mercer, manuk hovanesian, Chromium LUCI CQ, chromium...@chromium.org, ananyasee...@google.com, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, niharm...@google.com, omnibox-...@chromium.org
Attention needed from Justin Donnelly
Lei Zhang voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Justin Donnelly
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Justin Donnelly (Gerrit)
Nov 12, 2025, 11:27:18 PM (6 hours ago) Nov 12
to Justin Donnelly, Lei Zhang, Duncan Mercer, manuk hovanesian, Chromium LUCI CQ, chromium...@chromium.org, ananyasee...@google.com, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, niharm...@google.com, omnibox-...@chromium.org
Justin Donnelly voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 12, 2025, 11:30:38 PM (6 hours ago) Nov 12
to Justin Donnelly, Lei Zhang, Duncan Mercer, manuk hovanesian, chromium...@chromium.org, ananyasee...@google.com, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, niharm...@google.com, omnibox-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[143][context-input] Update cluster info lifecycle for query controller
The query controller may be controlled by multiple UIs at the same time,
so the UI should no longer be in charge of managing the lifecycle of the
query controller. This cl moves the session initialization flow (i.e.
fetching cluster info) to a InitializeIfNeeded method.
Since the cluster info is no longer cleared upon session end, this cl
removes the clear-on-session-start flag and behaviour. It also fixes the
BUILD config for the query controller unit tests and updates some
constants there.
(cherry picked from commit f74cd402a89f61ea2b34efff4586acf97053f7e6)
Bug: b:457472466, b:452118691, 460125833
Change-Id: If3af72c16a90a69ca955eeb802a66bd5fd6bf097
Reviewed-by: Christian Xu <chris...@chromium.org>
Commit-Queue: Jason Hu <huja...@google.com>
Reviewed-by: Moe Ahmadi <mah...@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1540243}
Reviewed-by: Lei Zhang <the...@chromium.org>
Commit-Queue: Justin Donnelly <jdon...@chromium.org>
Reviewed-by: manuk hovanesian <man...@chromium.org>
Owners-Override: Lei Zhang <the...@chromium.org>
Reviewed-by: Duncan Mercer <mer...@google.com>
Cr-Commit-Position: refs/branch-heads/7499@{#1574}
Cr-Branched-From: b30439823e5177773584139e72e0593e36863899-refs/heads/main@{#1536371}
Files:
- M chrome/browser/android/omnibox/composebox_query_controller_bridge.cc
- M chrome/browser/ui/webui/new_tab_page/composebox/composebox_handler_unittest.cc
- M chrome/browser/ui/webui/new_tab_page/composebox/variations/composebox_fieldtrial.cc
- M chrome/browser/ui/webui/searchbox/contextual_searchbox_handler.cc
- M chrome/browser/ui/webui/searchbox/contextual_searchbox_handler_unittest.cc
- M chrome/browser/ui/webui/searchbox/contextual_searchbox_test_utils.cc
- M chrome/browser/ui/webui/searchbox/contextual_searchbox_test_utils.h
- M components/BUILD.gn
- M components/contextual_search/contextual_search_context_controller.h
- M components/contextual_search/internal/composebox_query_controller.cc
- M components/contextual_search/internal/composebox_query_controller.h
- M components/contextual_search/internal/composebox_query_controller_unittest.cc
- M components/contextual_search/internal/test_composebox_query_controller.cc
- M components/contextual_search/internal/test_composebox_query_controller.h
- M ios/chrome/browser/aim/prototype/coordinator/aim_prototype_composebox_mediator.mm
Change size: L
Delta: 15 files changed, 120 insertions(+), 311 deletions(-)
Branch: refs/branch-heads/7499
Submit Requirements:
Code-Review: +1 by Lei Zhang, +1 by manuk hovanesian, +1 by Duncan Mercer
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages