Use variant for insert media request unit test test case [chromium/src : main]
0 views
Skip to first unread message
Michael Cui (Gerrit)
Jul 4, 2024, 1:44:30 AM (yesterday) Jul 4
to Michael Cui, Darren Shen, AyeAye, feature-me...@chromium.org
Attention needed from Darren Shen
Michael Cui voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Cui
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Michael Cui . unresolved
Is this worth keeping around? I feel like this is a bit overkill for a test.
Related details
Attention is currently required from:
- Darren Shen
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darren Shen (Gerrit)
Jul 4, 2024, 6:44:56 PM (10 hours ago) Jul 4
to Michael Cui, Chromium LUCI CQ, AyeAye, feature-me...@chromium.org
Attention needed from Michael Cui
Darren Shen voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darren Shen
| Code-Review | +1 |
1 comment
Patchset-level comments
Michael Cui . resolved
Is this worth keeping around? I feel like this is a bit overkill for a test.
Darren Shen
feels borderline? I don't think it steps into the "too much logic in a test" but it's getting close :/
Related details
Attention is currently required from:
- Michael Cui
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Cui (Gerrit)
Jul 4, 2024, 8:33:44 PM (8 hours ago) Jul 4
to Michael Cui, Darren Shen, Chromium LUCI CQ, AyeAye, feature-me...@chromium.org
Michael Cui abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages