[Fuchsia] Add raster and GLES2 read usage to FuchsiaVideoDecoder output shared images. [chromium/src : main]

0 views
Skip to first unread message

Zijie He (Gerrit)

unread,
Jun 26, 2026, 5:37:11 PM (6 days ago) Jun 26
to David Song, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, feature-me...@chromium.org, fuchsia...@chromium.org
Attention needed from David Song

Zijie He voted and added 1 comment

Votes added by Zijie He

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2:
Zijie He . resolved

Please take a look, thank you.

Open in Gerrit

Related details

Attention is currently required from:
  • David Song
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6d35a27d3dbeab9b287e366db4e8dc3db36aa57a
Gerrit-Change-Number: 8012655
Gerrit-PatchSet: 2
Gerrit-Owner: Zijie He <zij...@google.com>
Gerrit-Reviewer: David Song <winter...@google.com>
Gerrit-Reviewer: Zijie He <zij...@google.com>
Gerrit-Attention: David Song <winter...@google.com>
Gerrit-Comment-Date: Fri, 26 Jun 2026 21:36:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Zijie He (Gerrit)

unread,
Jun 29, 2026, 1:35:46 PM (3 days ago) Jun 29
to Guocheng Wei, David Song, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, feature-me...@chromium.org, fuchsia...@chromium.org
Attention needed from David Song and Guocheng Wei

Zijie He voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • David Song
  • Guocheng Wei
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6d35a27d3dbeab9b287e366db4e8dc3db36aa57a
Gerrit-Change-Number: 8012655
Gerrit-PatchSet: 3
Gerrit-Owner: Zijie He <zij...@google.com>
Gerrit-Reviewer: David Song <winter...@google.com>
Gerrit-Reviewer: Guocheng Wei <guoch...@chromium.org>
Gerrit-Attention: Guocheng Wei <guoch...@chromium.org>
Gerrit-Attention: David Song <winter...@google.com>
Gerrit-Comment-Date: Mon, 29 Jun 2026 17:35:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Guocheng Wei (Gerrit)

unread,
Jun 29, 2026, 1:48:06 PM (3 days ago) Jun 29
to Zijie He, David Song, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, feature-me...@chromium.org, fuchsia...@chromium.org
Attention needed from David Song and Zijie He

Guocheng Wei voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • David Song
  • Zijie He
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6d35a27d3dbeab9b287e366db4e8dc3db36aa57a
    Gerrit-Change-Number: 8012655
    Gerrit-PatchSet: 3
    Gerrit-Owner: Zijie He <zij...@google.com>
    Gerrit-Reviewer: David Song <winter...@google.com>
    Gerrit-Reviewer: Guocheng Wei <guoch...@chromium.org>
    Gerrit-Reviewer: Zijie He <zij...@google.com>
    Gerrit-Attention: Zijie He <zij...@google.com>
    Gerrit-Attention: David Song <winter...@google.com>
    Gerrit-Comment-Date: Mon, 29 Jun 2026 17:47:53 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jun 29, 2026, 2:57:48 PM (3 days ago) Jun 29
    to Zijie He, Guocheng Wei, David Song, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, feature-me...@chromium.org, fuchsia...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [Fuchsia] Add raster and GLES2 read usage to FuchsiaVideoDecoder output shared images.

    FuchsiaVideoDecoder creates shared images for decoded frames.
    When these frames are copied/drawn (e.g. into a canvas), they are
    accessed via the raster interface, which requires SHARED_IMAGE_USAGE_RASTER_READ.
    They might also be accessed via GLES2 in some fallback paths, so add
    SHARED_IMAGE_USAGE_GLES2_READ as well.

    Without these flags, ClientSharedImage::BeginRasterAccess asserts and crashes.
    Bug: 525137354
    Change-Id: I6d35a27d3dbeab9b287e366db4e8dc3db36aa57a
    Reviewed-by: Guocheng Wei <guoch...@chromium.org>
    Auto-Submit: Zijie He <zij...@google.com>
    Commit-Queue: Guocheng Wei <guoch...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1654239}
    Files:
    • M media/fuchsia/video/fuchsia_video_decoder.cc
    Change size: XS
    Delta: 1 file changed, 3 insertions(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Guocheng Wei
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6d35a27d3dbeab9b287e366db4e8dc3db36aa57a
    Gerrit-Change-Number: 8012655
    Gerrit-PatchSet: 4
    Gerrit-Owner: Zijie He <zij...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: David Song <winter...@google.com>
    Gerrit-Reviewer: Guocheng Wei <guoch...@chromium.org>
    Gerrit-Reviewer: Zijie He <zij...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages