[iOS] Prevent input plate from adding the same asset multiple times [chromium/src : main]
0 views
Skip to first unread message
Radu Nitescu (Gerrit)
3:59 AM (14 hours ago) 3:59 AM
to Christian Xu, Ameur Hosni, chromium...@chromium.org, Peter Williamson, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Ameur Hosni and Christian Xu
Radu Nitescu voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Ameur Hosni
- Christian Xu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ameur Hosni (Gerrit)
4:20 AM (14 hours ago) 4:20 AM
to Radu Nitescu, Chromium LUCI CQ, Christian Xu, chromium...@chromium.org, Peter Williamson, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Christian Xu and Radu Nitescu
Ameur Hosni voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Christian Xu
- Radu Nitescu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Radu Nitescu (Gerrit)
4:29 AM (14 hours ago) 4:29 AM
to Ameur Hosni, Chromium LUCI CQ, Christian Xu, chromium...@chromium.org, Peter Williamson, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Christian Xu
Radu Nitescu voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Christian Xu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Radu Nitescu (Gerrit)
4:29 AM (14 hours ago) 4:29 AM
to Ameur Hosni, Chromium LUCI CQ, Christian Xu, chromium...@chromium.org, Peter Williamson, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Christian Xu
Radu Nitescu voted and added 1 comment![]( "Open in Gerrit")
Votes added by Radu Nitescu
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Nit: Add a bug number
Radu Nitescu
Done
Chromium LUCI CQ (Gerrit)
4:58 AM (13 hours ago) 4:58 AM
to Radu Nitescu, Ameur Hosni, Christian Xu, chromium...@chromium.org, Peter Williamson, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[iOS] Prevent input plate from adding the same asset multiple times
Fixed: 460023492
Change-Id: I51f82ec8fa4f776a96c7f77fd965784fb2a64a27
Reviewed-by: Ameur Hosni <ameur...@google.com>
Auto-Submit: Radu Nitescu <radun...@google.com>
Commit-Queue: Radu Nitescu <radun...@google.com>
Cr-Commit-Position: refs/heads/main@{#1543612}
Files:
- M ios/chrome/browser/composebox/coordinator/composebox_input_plate_coordinator.mm
- M ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator.h
- M ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator.mm
- M ios/chrome/browser/composebox/ui/composebox_input_item.h
- M ios/chrome/browser/composebox/ui/composebox_input_item.mm
Change size: M
Delta: 5 files changed, 45 insertions(+), 10 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ameur Hosni
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages