[global media controls] Delete kGlobalMediaControlsPictureInPicture flag [chromium/src : main]
0 views
Skip to first unread message
Tommy Steimel (Gerrit)
Nov 12, 2025, 5:50:56 PM (12 hours ago) Nov 12
to Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Frank Liberato
Tommy Steimel voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tommy Steimel
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Frank Liberato
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Frank Liberato (Gerrit)
Nov 12, 2025, 6:13:41 PM (11 hours ago) Nov 12
to Tommy Steimel, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Tommy Steimel
Frank Liberato voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Tommy Steimel
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tommy Steimel (Gerrit)
Nov 12, 2025, 7:40:35 PM (10 hours ago) Nov 12
to Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Tommy Steimel voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 12, 2025, 7:43:39 PM (10 hours ago) Nov 12
to Tommy Steimel, chromium...@chromium.org, feature-me...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[global media controls] Delete kGlobalMediaControlsPictureInPicture flag
This CL deletes the kGlobalMediaControlsPictureInPicture flag, as the
feature was launched a long time ago. The feature flag has technically
been turned off on Android this whole time, but turning it on on
Android has no actual effect, since the MediaNotificationController
already filters the given Chrome MediaSessionActions into allowlisted
Android MediaSessionActions:
https://source.chromium.org/chromium/chromium/src/+/main:components/browser_ui/media/android/java/src/org/chromium/components/browser_ui/media/MediaNotificationController.java;l=886;drc=8e3c3db1bd3da6c8949c40f2ad673183457cdbe2
Bug: 40181326
Change-Id: I0239c9ef0ace9a918ed1394a9a8d34206736a225
Reviewed-by: Frank Liberato <libe...@chromium.org>
Commit-Queue: Tommy Steimel <ste...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1544050}
Files:
- M content/browser/media/session/media_session_controllers_manager_unittest.cc
- M content/browser/media/session/media_session_impl.cc
- M content/browser/media/session/media_session_impl_unittest.cc
- M media/base/media_switches.cc
- M media/base/media_switches.h
Change size: S
Delta: 5 files changed, 11 insertions(+), 29 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Frank Liberato
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages