[ImmersivePlayer] Update list of immersive formats [chromium/src : main]

0 views
Skip to first unread message

Gurmeet Kalra (Gerrit)

unread,
Jun 26, 2026, 1:10:02 PM (2 days ago) Jun 26
to Oleh Desiatyrikov (xWF), Nick Mondello, chromium...@chromium.org, feature-me...@chromium.org, srahim...@chromium.org
Attention needed from Nick Mondello and Oleh Desiatyrikov (xWF)

Gurmeet Kalra voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Nick Mondello
  • Oleh Desiatyrikov (xWF)
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Icb5657ddb52d13d53c8c5cd86457987fd290b4c8
Gerrit-Change-Number: 8012273
Gerrit-PatchSet: 1
Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
Gerrit-Reviewer: Nick Mondello <mond...@google.com>
Gerrit-Attention: Nick Mondello <mond...@google.com>
Gerrit-Attention: Oleh Desiatyrikov (xWF) <desiat...@google.com>
Gerrit-Comment-Date: Fri, 26 Jun 2026 17:09:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Nick Mondello (Gerrit)

unread,
Jun 26, 2026, 1:41:01 PM (2 days ago) Jun 26
to Oleh Desiatyrikov (xWF), Gurmeet Kalra, chromium...@chromium.org, feature-me...@chromium.org, srahim...@chromium.org
Attention needed from Oleh Desiatyrikov (xWF)

Nick Mondello voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Oleh Desiatyrikov (xWF)
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Icb5657ddb52d13d53c8c5cd86457987fd290b4c8
    Gerrit-Change-Number: 8012273
    Gerrit-PatchSet: 1
    Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
    Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
    Gerrit-Reviewer: Nick Mondello <mond...@google.com>
    Gerrit-Attention: Oleh Desiatyrikov (xWF) <desiat...@google.com>
    Gerrit-Comment-Date: Fri, 26 Jun 2026 17:40:49 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Oleh Desiatyrikov (xWF) (Gerrit)

    unread,
    Jun 26, 2026, 1:54:20 PM (2 days ago) Jun 26
    to Nick Mondello, Gurmeet Kalra, chromium...@chromium.org, feature-me...@chromium.org, srahim...@chromium.org

    Oleh Desiatyrikov (xWF) voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Icb5657ddb52d13d53c8c5cd86457987fd290b4c8
    Gerrit-Change-Number: 8012273
    Gerrit-PatchSet: 1
    Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
    Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
    Gerrit-Reviewer: Nick Mondello <mond...@google.com>
    Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>
    Gerrit-Comment-Date: Fri, 26 Jun 2026 17:54:08 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Gurmeet Kalra (Gerrit)

    unread,
    Jun 26, 2026, 8:38:29 PM (2 days ago) Jun 26
    to Oleh Desiatyrikov (xWF), Chromium LUCI CQ, Nick Mondello, chromium...@chromium.org, feature-me...@chromium.org, srahim...@chromium.org
    Attention needed from Nick Mondello and Oleh Desiatyrikov (xWF)

    Gurmeet Kalra voted and added 1 comment

    Votes added by Gurmeet Kalra

    Code-Review+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 2 (Latest):
    Gurmeet Kalra . resolved

    slgtm

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Nick Mondello
    • Oleh Desiatyrikov (xWF)
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Icb5657ddb52d13d53c8c5cd86457987fd290b4c8
      Gerrit-Change-Number: 8012273
      Gerrit-PatchSet: 2
      Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
      Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
      Gerrit-Reviewer: Nick Mondello <mond...@google.com>
      Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>
      Gerrit-Attention: Nick Mondello <mond...@google.com>
      Gerrit-Attention: Oleh Desiatyrikov (xWF) <desiat...@google.com>
      Gerrit-Comment-Date: Sat, 27 Jun 2026 00:38:16 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Nick Mondello (Gerrit)

      unread,
      Jun 26, 2026, 10:08:10 PM (2 days ago) Jun 26
      to Oleh Desiatyrikov (xWF), Gurmeet Kalra, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, srahim...@chromium.org
      Attention needed from Oleh Desiatyrikov (xWF)

      Nick Mondello voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Oleh Desiatyrikov (xWF)
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Icb5657ddb52d13d53c8c5cd86457987fd290b4c8
        Gerrit-Change-Number: 8012273
        Gerrit-PatchSet: 2
        Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
        Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
        Gerrit-Reviewer: Nick Mondello <mond...@google.com>
        Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>
        Gerrit-Attention: Oleh Desiatyrikov (xWF) <desiat...@google.com>
        Gerrit-Comment-Date: Sat, 27 Jun 2026 02:07:57 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Oleh Desiatyrikov (xWF) (Gerrit)

        unread,
        Jun 27, 2026, 10:55:46 AM (15 hours ago) Jun 27
        to Nick Mondello, Gurmeet Kalra, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, srahim...@chromium.org

        Oleh Desiatyrikov (xWF) voted Commit-Queue+2

        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Icb5657ddb52d13d53c8c5cd86457987fd290b4c8
        Gerrit-Change-Number: 8012273
        Gerrit-PatchSet: 2
        Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
        Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
        Gerrit-Reviewer: Nick Mondello <mond...@google.com>
        Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>
        Gerrit-Comment-Date: Sat, 27 Jun 2026 14:55:30 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        Jun 27, 2026, 12:03:50 PM (14 hours ago) Jun 27
        to Oleh Desiatyrikov (xWF), Nick Mondello, Gurmeet Kalra, chromium...@chromium.org, feature-me...@chromium.org, srahim...@chromium.org

        Chromium LUCI CQ submitted the change

        Change information

        Commit message:
        [ImmersivePlayer] Update list of immersive formats

        This CL updates the list of supported immersive formats to match the spec.
        Bug: 528328447
        Change-Id: Icb5657ddb52d13d53c8c5cd86457987fd290b4c8
        Reviewed-by: Gurmeet Kalra <gurm...@google.com>
        Commit-Queue: Oleh Desiatyrikov (xWF) <desiat...@google.com>
        Reviewed-by: Nick Mondello <mond...@google.com>
        Cr-Commit-Position: refs/heads/main@{#1653679}
        Files:
        • M chrome/android/java/src/org/chromium/chrome/browser/media/immersive_playback/ImmersiveVideoFormatRadioGroup.java
        • M chrome/android/junit/src/org/chromium/chrome/browser/media/immersive_playback/ImmersiveVideoFormatSelectionDialogTest.java
        • M chrome/browser/ui/android/strings/android_chrome_strings.grd
        Change size: S
        Delta: 3 files changed, 35 insertions(+), 10 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Gurmeet Kalra, +1 by Nick Mondello
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Icb5657ddb52d13d53c8c5cd86457987fd290b4c8
        Gerrit-Change-Number: 8012273
        Gerrit-PatchSet: 3
        Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
        Gerrit-Reviewer: Nick Mondello <mond...@google.com>
        Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages