[m143] media: Fix non-standard url parameter in provisioning [chromium/src : refs/branch-heads/7499]
0 views
Skip to first unread message
Xiaohan Wang (Gerrit)
Oct 30, 2025, 11:04:01 PM (13 days ago) Oct 30
to Vikram Pasupathy, AyeAye, Chromium LUCI CQ, feature-me...@chromium.org
Attention needed from Vikram Pasupathy
Xiaohan Wang voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Vikram Pasupathy
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Feras Aldahlawi (Gerrit)
Nov 3, 2025, 11:31:23 AM (10 days ago) Nov 3
to Vikram Pasupathy, AyeAye, Chromium LUCI CQ, feature-me...@chromium.org
Attention needed from Vikram Pasupathy
Feras Aldahlawi voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Vikram Pasupathy
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vikram Pasupathy (Gerrit)
Nov 3, 2025, 11:35:38 AM (10 days ago) Nov 3
to AyeAye, Chromium LUCI CQ, feature-me...@chromium.org
Vikram Pasupathy voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 3, 2025, 1:42:57 PM (10 days ago) Nov 3
to Vikram Pasupathy, AyeAye, feature-me...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[m143] media: Fix non-standard url parameter in provisioning
Cherry-pick to M143.
The url parameter was added via an ampersand, when the start of
parameters should actually include a question mark. This worked because
of lenient parsing, but should be fixed to match the standard, as the
question mark is recognized as the start of the query string by all
servers.
Tested manually with flag enabled to verify it worked.
Media.EME.MediaDrm.Provisioning returns success each time.
Media.EME.UrlProvisionFetcher.ResponseCode returns 200 each time.
(cherry picked from commit bf3874fe28522965231961d42ce7591df15ed20c)
Bug: 456186326, 456250902
Change-Id: I21cc325a03d30328cc6b00bb03508e4c18977877
Reviewed-by: Xiaohan Wang <xhw...@chromium.org>
Commit-Queue: Vikram Pasupathy <vpasu...@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1537542}
Reviewed-by: Feras Aldahlawi <f...@chromium.org>
Cr-Commit-Position: refs/branch-heads/7499@{#527}
Cr-Branched-From: b30439823e5177773584139e72e0593e36863899-refs/heads/main@{#1536371}
Files:
- M content/browser/media/url_provision_fetcher.cc
- M content/browser/media/url_provision_fetcher_unittest.cc
Change size: XS
Delta: 2 files changed, 2 insertions(+), 2 deletions(-)
Branch: refs/branch-heads/7499
Submit Requirements:
Code-Review: +1 by Xiaohan Wang, +1 by Feras Aldahlawi
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vikram Pasupathy (Gerrit)
Nov 12, 2025, 7:31:09 PM (10 hours ago) Nov 12
to Chromium LUCI CQ, Vikram Pasupathy, AyeAye, feature-me...@chromium.org
Vikram Pasupathy has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages