Move FirstLevel check to SysInfo [chromium/src : main]
Vikram Pasupathy (Gerrit)
New activity on the change![]( "Open in Gerrit")
Related details
- Andrew Grieve
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrew Grieve (Gerrit)
Andrew Grieve voted Code-Review+1![]( "Open in Gerrit")
- Vikram Pasupathy
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vikram Pasupathy (Gerrit)
Vikram Pasupathy voted Commit-Queue+1![]( "Open in Gerrit")
- Xiaohan Wang
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xiaohan Wang (Gerrit)
Xiaohan Wang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Xiaohan Wang
| Code-Review | +1 |
1 comment
Related details
- Vikram Pasupathy
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Weber (Gerrit)
Nico Weber voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nico Weber
| Code-Review | +1 |
1 comment
// Returns the first Android level the device had.What does "first android level the device had" mean? Like, the version it gets when its factory reset? Something else?
Related details
- Vikram Pasupathy
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vikram Pasupathy (Gerrit)
Vikram Pasupathy added 1 comment![]( "Open in Gerrit")
// Returns the first Android level the device had.What does "first android level the device had" mean? Like, the version it gets when its factory reset? Something else?
Updated the wording. For more info, you can follow the path from http://shortn/_tonWP0thCA, (Google internal)
Related details
- Nico Weber
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Weber (Gerrit)
Nico Weber voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nico Weber
| Code-Review | +1 |
1 comment
base::android::android_info::SDK_VERSION_OREO;Hm, the only user of this function checks for oreo, which per https://support.google.com/chrome/thread/352616098/sunsetting-chrome-support-for-android-8-0-oreo-and-android-9-0-pie?hl=en&sjid=4708975472713495052-NA we no longer support for chrome. Do we still support it for webview?
Related details
- Vikram Pasupathy
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vikram Pasupathy (Gerrit)
Vikram Pasupathy added 1 comment![]( "Open in Gerrit")
base::android::android_info::SDK_VERSION_OREO;Hm, the only user of this function checks for oreo, which per https://support.google.com/chrome/thread/352616098/sunsetting-chrome-support-for-android-8-0-oreo-and-android-9-0-pie?hl=en&sjid=4708975472713495052-NA we no longer support for chrome. Do we still support it for webview?
https://chromium-review.googlesource.com/c/chromium/src/+/7137302/comment/41cc2766_985d3757/
This comment should answer that first part of this question.
To see users and safety, we introduced this UMA, https://chromium-review.googlesource.com/c/chromium/src/+/7146728 and we still see users who have a first level pre Oreo.
Related details
- Nico Weber
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xiaohan Wang (Gerrit)
Xiaohan Wang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Xiaohan Wang
| Code-Review | +1 |
1 comment
// Returns the first Android level the device had.Vikram PasupathyWhat does "first android level the device had" mean? Like, the version it gets when its factory reset? Something else?
Updated the wording. For more info, you can follow the path from http://shortn/_tonWP0thCA, (Google internal)
It's "The SDK API level that the device is initially launched with." I'd suggest let's just use that official wording as is.
Related details
- Nico Weber
- Vikram Pasupathy
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vikram Pasupathy (Gerrit)
Vikram Pasupathy added 1 comment![]( "Open in Gerrit")
// Returns the first Android level the device had.Vikram PasupathyWhat does "first android level the device had" mean? Like, the version it gets when its factory reset? Something else?
Xiaohan WangUpdated the wording. For more info, you can follow the path from http://shortn/_tonWP0thCA, (Google internal)
It's "The SDK API level that the device is initially launched with." I'd suggest let's just use that official wording as is.
Thank you! Updated.
Related details
- Nico Weber
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vikram Pasupathy (Gerrit)
Vikram Pasupathy added 1 comment![]( "Open in Gerrit")
base::android::android_info::SDK_VERSION_OREO;Vikram PasupathyHm, the only user of this function checks for oreo, which per https://support.google.com/chrome/thread/352616098/sunsetting-chrome-support-for-android-8-0-oreo-and-android-9-0-pie?hl=en&sjid=4708975472713495052-NA we no longer support for chrome. Do we still support it for webview?
https://chromium-review.googlesource.com/c/chromium/src/+/7137302/comment/41cc2766_985d3757/
This comment should answer that first part of this question.
To see users and safety, we introduced this UMA, https://chromium-review.googlesource.com/c/chromium/src/+/7146728 and we still see users who have a first level pre Oreo.
Added b:459977924 for more information and prior discussion with Android owners.
If that's fine, I can resolve this comment.
Related details
- Nico Weber
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vikram Pasupathy (Gerrit)
Vikram Pasupathy added 1 comment![]( "Open in Gerrit")
Nico Weber (Gerrit)
Nico Weber voted and added 3 comments![]( "Open in Gerrit")
Votes added by Nico Weber
| Code-Review | +1 |
3 comments
Sorry, I didn't realize you were waiting for me here
// Returns the SDK API level that the device is initially launched with.nit: "that the device initially launched with" or "was initially launched with"
base::android::android_info::SDK_VERSION_OREO;Vikram PasupathyHm, the only user of this function checks for oreo, which per https://support.google.com/chrome/thread/352616098/sunsetting-chrome-support-for-android-8-0-oreo-and-android-9-0-pie?hl=en&sjid=4708975472713495052-NA we no longer support for chrome. Do we still support it for webview?
Vikram Pasupathyhttps://chromium-review.googlesource.com/c/chromium/src/+/7137302/comment/41cc2766_985d3757/
This comment should answer that first part of this question.
To see users and safety, we introduced this UMA, https://chromium-review.googlesource.com/c/chromium/src/+/7146728 and we still see users who have a first level pre Oreo.
Added b:459977924 for more information and prior discussion with Android owners.
If that's fine, I can resolve this comment.
- Vikram Pasupathy
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vikram Pasupathy (Gerrit)
Vikram Pasupathy voted and added 1 comment![]( "Open in Gerrit")
Votes added by Vikram Pasupathy
| Commit-Queue | +2 |
1 comment
// Returns the SDK API level that the device is initially launched with.nit: "that the device initially launched with" or "was initially launched with"
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vikram Pasupathy (Gerrit)
Vikram Pasupathy voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
9 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: base/system/sys_info.h
Insertions: 1, Deletions: 1.
@@ -324,7 +324,7 @@
// devices with similar hardware components.
static std::string GetAndroidHardwareClass();
- // Returns the SDK API level that the device is initially launched with.
+ // Returns the SDK API level that the device initially launched with.
static std::string GetAndroidFirstApiLevel();
#endif // BUILDFLAG(IS_ANDROID)
```
Change information
Move FirstLevel check to SysInfo
By putting the first level check to the SysInfo, we avoid a JNI jump.
This matches the work done in MediaCodecUtil to GetAndroidHardware to
detect MediaTek devices, in
https://chromium.googlesource.com/chromium/src/+/6c1b4b93191cd5d4598ceab394a62e5d765.
Verified by logging the FirstApiLevel with and without my change on a
Pixel 5. Both reported the same ApiLevel of 30.
- M base/system/sys_info.h
- M base/system/sys_info_android.cc
- M media/base/android/java/src/org/chromium/media/MediaDrmBridge.java
- M media/base/android/media_drm_bridge.cc
Code-Review: +1 by Nico Weber, +1 by Andrew Grieve, +1 by Xiaohan Wang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |