Reland "[Media] Return boolean from audio device enumeration to track outcomes" [chromium/src : main]

0 views
Skip to first unread message

rubber-stamper@appspot.gserviceaccount.com (Gerrit)

unread,
May 6, 2026, 9:40:15 AM (12 days ago) May 6
to Frederik Hermans, Olga Sharonova, Henrik Andreasson, luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, Bruno Braga, Johannes Kron, android-bu...@system.gserviceaccount.com, Rijubrata Bhaumik, Zijie He, Chromium Metrics Reviews, alexmo...@chromium.org, creis...@chromium.org, fuchsia...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, chfreme...@chromium.org, asvitkine...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Bruno Braga, Henrik Andreasson, Johannes Kron and Olga Sharonova

rubber-...@appspot.gserviceaccount.com voted Bot-Commit+1

Bot-Commit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Bruno Braga
  • Henrik Andreasson
  • Johannes Kron
  • Olga Sharonova
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I19b2ecffd1eb169cf1de85bc48198f1c954dc246
Gerrit-Change-Number: 7820568
Gerrit-PatchSet: 1
Gerrit-Owner: Frederik Hermans <fred...@google.com>
Gerrit-Reviewer: Bruno Braga <bruno...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Henrik Andreasson <hen...@chromium.org>
Gerrit-Reviewer: Johannes Kron <kr...@chromium.org>
Gerrit-Reviewer: Olga Sharonova <ol...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Olga Sharonova <ol...@chromium.org>
Gerrit-Attention: Henrik Andreasson <hen...@chromium.org>
Gerrit-Attention: Johannes Kron <kr...@chromium.org>
Gerrit-Attention: Bruno Braga <bruno...@google.com>
Gerrit-Comment-Date: Wed, 06 May 2026 13:40:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

rubber-stamper@appspot.gserviceaccount.com (Gerrit)

unread,
May 12, 2026, 2:58:21 AM (6 days ago) May 12
to Frederik Hermans, Sandeep Vijayasekar, Olga Sharonova, Henrik Andreasson, luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, Bruno Braga, Johannes Kron, android-bu...@system.gserviceaccount.com, Rijubrata Bhaumik, Zijie He, Chromium Metrics Reviews, halliwe...@chromium.org, ios-r...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, fuchsia...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, chfreme...@chromium.org, asvitkine...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Bruno Braga, Henrik Andreasson, Johannes Kron, Olga Sharonova and Sandeep Vijayasekar

Message from rubber-...@appspot.gserviceaccount.com

Gerrit GetPureRevert API does not mark this CL as a pure revert. Learn more: go/rubber-stamper-user-guide.

Open in Gerrit

Related details

Attention is currently required from:
  • Bruno Braga
  • Henrik Andreasson
  • Johannes Kron
  • Olga Sharonova
  • Sandeep Vijayasekar
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I19b2ecffd1eb169cf1de85bc48198f1c954dc246
    Gerrit-Change-Number: 7820568
    Gerrit-PatchSet: 6
    Gerrit-Owner: Frederik Hermans <fred...@google.com>
    Gerrit-Reviewer: Bruno Braga <bruno...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Frederik Hermans <fred...@google.com>
    Gerrit-Reviewer: Henrik Andreasson <hen...@chromium.org>
    Gerrit-Reviewer: Johannes Kron <kr...@chromium.org>
    Gerrit-Reviewer: Olga Sharonova <ol...@chromium.org>
    Gerrit-Reviewer: Sandeep Vijayasekar <sa...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Zijie He <zij...@google.com>
    Gerrit-Attention: Olga Sharonova <ol...@chromium.org>
    Gerrit-Attention: Henrik Andreasson <hen...@chromium.org>
    Gerrit-Attention: Sandeep Vijayasekar <sa...@google.com>
    Gerrit-Attention: Johannes Kron <kr...@chromium.org>
    Gerrit-Attention: Bruno Braga <bruno...@google.com>
    Gerrit-Comment-Date: Tue, 12 May 2026 06:58:12 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Frederik Hermans (Gerrit)

    unread,
    May 12, 2026, 2:58:25 AM (6 days ago) May 12
    to Sandeep Vijayasekar, rubber-...@appspot.gserviceaccount.com, Olga Sharonova, Henrik Andreasson, luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, Bruno Braga, Johannes Kron, android-bu...@system.gserviceaccount.com, Rijubrata Bhaumik, Zijie He, Chromium Metrics Reviews, halliwe...@chromium.org, ios-r...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, fuchsia...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, chfreme...@chromium.org, asvitkine...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, mfoltz+wa...@chromium.org
    Attention needed from Bruno Braga, Henrik Andreasson, Johannes Kron, Olga Sharonova and Sandeep Vijayasekar

    New activity on the change

    Gerrit-Comment-Date: Tue, 12 May 2026 06:57:58 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Johannes Kron (Gerrit)

    unread,
    May 12, 2026, 4:13:51 AM (6 days ago) May 12
    to Frederik Hermans, Sandeep Vijayasekar, Olga Sharonova, Henrik Andreasson, luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, Bruno Braga, android-bu...@system.gserviceaccount.com, Rijubrata Bhaumik, Zijie He, Chromium Metrics Reviews, halliwe...@chromium.org, ios-r...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, fuchsia...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, chfreme...@chromium.org, asvitkine...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, mfoltz+wa...@chromium.org
    Attention needed from Bruno Braga, Frederik Hermans, Henrik Andreasson, Olga Sharonova and Sandeep Vijayasekar

    Johannes Kron voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Bruno Braga
    • Frederik Hermans
    • Henrik Andreasson
    • Olga Sharonova
    • Sandeep Vijayasekar
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I19b2ecffd1eb169cf1de85bc48198f1c954dc246
      Gerrit-Change-Number: 7820568
      Gerrit-PatchSet: 7
      Gerrit-Owner: Frederik Hermans <fred...@google.com>
      Gerrit-Reviewer: Bruno Braga <bruno...@google.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Frederik Hermans <fred...@google.com>
      Gerrit-Reviewer: Henrik Andreasson <hen...@chromium.org>
      Gerrit-Reviewer: Johannes Kron <kr...@chromium.org>
      Gerrit-Reviewer: Olga Sharonova <ol...@chromium.org>
      Gerrit-Reviewer: Sandeep Vijayasekar <sa...@google.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
      Gerrit-CC: Zijie He <zij...@google.com>
      Gerrit-Attention: Olga Sharonova <ol...@chromium.org>
      Gerrit-Attention: Henrik Andreasson <hen...@chromium.org>
      Gerrit-Attention: Frederik Hermans <fred...@google.com>
      Gerrit-Attention: Sandeep Vijayasekar <sa...@google.com>
      Gerrit-Attention: Bruno Braga <bruno...@google.com>
      Gerrit-Comment-Date: Tue, 12 May 2026 08:13:34 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Olga Sharonova (Gerrit)

      unread,
      May 12, 2026, 4:52:59 AM (6 days ago) May 12
      to Frederik Hermans, Johannes Kron, Sandeep Vijayasekar, Henrik Andreasson, luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, Bruno Braga, android-bu...@system.gserviceaccount.com, Rijubrata Bhaumik, Zijie He, Chromium Metrics Reviews, halliwe...@chromium.org, ios-r...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, fuchsia...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, chfreme...@chromium.org, asvitkine...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, mfoltz+wa...@chromium.org
      Attention needed from Bruno Braga, Frederik Hermans, Henrik Andreasson and Sandeep Vijayasekar

      Olga Sharonova added 1 comment

      File chromecast/media/audio/cast_audio_manager_android.cc
      Line 128, Patchset 7 (Latest): device_names->push_back(::media::AudioDeviceName::CreateCommunications());
      Olga Sharonova . unresolved

      This is changing the behavior, which may potentially lead to regressions. Also it does not match what is done in GetAudioInputDeviceNames() where communication device is created unconditionally.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Bruno Braga
      • Frederik Hermans
      • Henrik Andreasson
      • Sandeep Vijayasekar
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I19b2ecffd1eb169cf1de85bc48198f1c954dc246
        Gerrit-Change-Number: 7820568
        Gerrit-PatchSet: 7
        Gerrit-Owner: Frederik Hermans <fred...@google.com>
        Gerrit-Reviewer: Bruno Braga <bruno...@google.com>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Frederik Hermans <fred...@google.com>
        Gerrit-Reviewer: Henrik Andreasson <hen...@chromium.org>
        Gerrit-Reviewer: Johannes Kron <kr...@chromium.org>
        Gerrit-Reviewer: Olga Sharonova <ol...@chromium.org>
        Gerrit-Reviewer: Sandeep Vijayasekar <sa...@google.com>
        Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
        Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
        Gerrit-CC: Zijie He <zij...@google.com>
        Gerrit-Attention: Henrik Andreasson <hen...@chromium.org>
        Gerrit-Attention: Frederik Hermans <fred...@google.com>
        Gerrit-Attention: Sandeep Vijayasekar <sa...@google.com>
        Gerrit-Attention: Bruno Braga <bruno...@google.com>
        Gerrit-Comment-Date: Tue, 12 May 2026 08:52:39 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Frederik Hermans (Gerrit)

        unread,
        May 12, 2026, 6:10:12 AM (6 days ago) May 12
        to Johannes Kron, Sandeep Vijayasekar, Olga Sharonova, Henrik Andreasson, luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, Bruno Braga, android-bu...@system.gserviceaccount.com, Rijubrata Bhaumik, Zijie He, Chromium Metrics Reviews, halliwe...@chromium.org, ios-r...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, fuchsia...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, chfreme...@chromium.org, asvitkine...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, mfoltz+wa...@chromium.org
        Attention needed from Bruno Braga, Henrik Andreasson, Johannes Kron, Olga Sharonova and Sandeep Vijayasekar

        Frederik Hermans added 1 comment

        File chromecast/media/audio/cast_audio_manager_android.cc
        Line 128, Patchset 7: device_names->push_back(::media::AudioDeviceName::CreateCommunications());
        Olga Sharonova . resolved

        This is changing the behavior, which may potentially lead to regressions. Also it does not match what is done in GetAudioInputDeviceNames() where communication device is created unconditionally.

        Frederik Hermans

        Yeah, sorry about this. Should be done unconditionally.

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Bruno Braga
        • Henrik Andreasson
        • Johannes Kron
        • Olga Sharonova
        • Sandeep Vijayasekar
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement is not satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I19b2ecffd1eb169cf1de85bc48198f1c954dc246
          Gerrit-Change-Number: 7820568
          Gerrit-PatchSet: 8
          Gerrit-Owner: Frederik Hermans <fred...@google.com>
          Gerrit-Reviewer: Bruno Braga <bruno...@google.com>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-Reviewer: Frederik Hermans <fred...@google.com>
          Gerrit-Reviewer: Henrik Andreasson <hen...@chromium.org>
          Gerrit-Reviewer: Johannes Kron <kr...@chromium.org>
          Gerrit-Reviewer: Olga Sharonova <ol...@chromium.org>
          Gerrit-Reviewer: Sandeep Vijayasekar <sa...@google.com>
          Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
          Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
          Gerrit-CC: Zijie He <zij...@google.com>
          Gerrit-Attention: Olga Sharonova <ol...@chromium.org>
          Gerrit-Attention: Henrik Andreasson <hen...@chromium.org>
          Gerrit-Attention: Sandeep Vijayasekar <sa...@google.com>
          Gerrit-Attention: Johannes Kron <kr...@chromium.org>
          Gerrit-Attention: Bruno Braga <bruno...@google.com>
          Gerrit-Comment-Date: Tue, 12 May 2026 10:09:56 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          Comment-In-Reply-To: Olga Sharonova <ol...@chromium.org>
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Olga Sharonova (Gerrit)

          unread,
          May 12, 2026, 8:16:29 AM (6 days ago) May 12
          to Frederik Hermans, Johannes Kron, Sandeep Vijayasekar, Henrik Andreasson, luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, Bruno Braga, android-bu...@system.gserviceaccount.com, Rijubrata Bhaumik, Zijie He, Chromium Metrics Reviews, halliwe...@chromium.org, ios-r...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, fuchsia...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, chfreme...@chromium.org, asvitkine...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, mfoltz+wa...@chromium.org
          Attention needed from Bruno Braga, Frederik Hermans, Henrik Andreasson, Johannes Kron and Sandeep Vijayasekar

          Olga Sharonova voted and added 1 comment

          Votes added by Olga Sharonova

          Code-Review+1

          1 comment

          Patchset-level comments
          File-level comment, Patchset 8 (Latest):
          Olga Sharonova . resolved

          LGTM

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Bruno Braga
          • Frederik Hermans
          • Henrik Andreasson
          • Johannes Kron
          • Sandeep Vijayasekar
          Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement is not satisfiedCode-Owners
            • requirement is not satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: I19b2ecffd1eb169cf1de85bc48198f1c954dc246
            Gerrit-Change-Number: 7820568
            Gerrit-PatchSet: 8
            Gerrit-Owner: Frederik Hermans <fred...@google.com>
            Gerrit-Reviewer: Bruno Braga <bruno...@google.com>
            Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
            Gerrit-Reviewer: Frederik Hermans <fred...@google.com>
            Gerrit-Reviewer: Henrik Andreasson <hen...@chromium.org>
            Gerrit-Reviewer: Johannes Kron <kr...@chromium.org>
            Gerrit-Reviewer: Olga Sharonova <ol...@chromium.org>
            Gerrit-Reviewer: Sandeep Vijayasekar <sa...@google.com>
            Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
            Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
            Gerrit-CC: Zijie He <zij...@google.com>
            Gerrit-Attention: Henrik Andreasson <hen...@chromium.org>
            Gerrit-Attention: Frederik Hermans <fred...@google.com>
            Gerrit-Attention: Sandeep Vijayasekar <sa...@google.com>
            Gerrit-Attention: Johannes Kron <kr...@chromium.org>
            Gerrit-Attention: Bruno Braga <bruno...@google.com>
            Gerrit-Comment-Date: Tue, 12 May 2026 12:16:10 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy

            Johannes Kron (Gerrit)

            unread,
            May 13, 2026, 3:32:48 AM (5 days ago) May 13
            to Frederik Hermans, Olga Sharonova, Sandeep Vijayasekar, Henrik Andreasson, luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, Bruno Braga, android-bu...@system.gserviceaccount.com, Rijubrata Bhaumik, Zijie He, Chromium Metrics Reviews, halliwe...@chromium.org, ios-r...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, fuchsia...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, chfreme...@chromium.org, asvitkine...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, mfoltz+wa...@chromium.org
            Attention needed from Bruno Braga, Frederik Hermans, Henrik Andreasson and Sandeep Vijayasekar

            Johannes Kron voted Code-Review+1

            Code-Review+1
            Open in Gerrit

            Related details

            Attention is currently required from:
            • Bruno Braga
            • Frederik Hermans
            • Henrik Andreasson
            • Sandeep Vijayasekar
            Submit Requirements:
              • requirement satisfiedCode-Coverage
              • requirement is not satisfiedCode-Owners
              • requirement satisfiedCode-Review
              • requirement satisfiedReview-Enforcement
              Gerrit-Attention: Bruno Braga <bruno...@google.com>
              Gerrit-Comment-Date: Wed, 13 May 2026 07:32:28 +0000
              Gerrit-HasComments: No
              Gerrit-Has-Labels: Yes
              satisfied_requirement
              unsatisfied_requirement
              open
              diffy

              Henrik Andreasson (Gerrit)

              unread,
              May 13, 2026, 3:41:13 AM (5 days ago) May 13
              to Frederik Hermans, Johannes Kron, Olga Sharonova, Sandeep Vijayasekar, luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, Bruno Braga, android-bu...@system.gserviceaccount.com, Rijubrata Bhaumik, Zijie He, Chromium Metrics Reviews, halliwe...@chromium.org, ios-r...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, fuchsia...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, chfreme...@chromium.org, asvitkine...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, mfoltz+wa...@chromium.org
              Attention needed from Bruno Braga, Frederik Hermans and Sandeep Vijayasekar

              Henrik Andreasson voted Code-Review+1

              Code-Review+1
              Open in Gerrit

              Related details

              Attention is currently required from:
              • Bruno Braga
              • Frederik Hermans
              • Sandeep Vijayasekar
              Gerrit-Attention: Frederik Hermans <fred...@google.com>
              Gerrit-Attention: Sandeep Vijayasekar <sa...@google.com>
              Gerrit-Attention: Bruno Braga <bruno...@google.com>
              Gerrit-Comment-Date: Wed, 13 May 2026 07:40:57 +0000
              Gerrit-HasComments: No
              Gerrit-Has-Labels: Yes
              satisfied_requirement
              unsatisfied_requirement
              open
              diffy

              Sandeep Vijayasekar (Gerrit)

              unread,
              May 13, 2026, 11:18:26 AM (5 days ago) May 13
              to Frederik Hermans, Henrik Andreasson, Johannes Kron, Olga Sharonova, luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, Bruno Braga, android-bu...@system.gserviceaccount.com, Rijubrata Bhaumik, Zijie He, Chromium Metrics Reviews, halliwe...@chromium.org, ios-r...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, fuchsia...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, chfreme...@chromium.org, asvitkine...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, mfoltz+wa...@chromium.org
              Attention needed from Bruno Braga and Frederik Hermans

              Sandeep Vijayasekar voted Code-Review+1

              Code-Review+1
              Open in Gerrit

              Related details

              Attention is currently required from:
              • Bruno Braga
              • Frederik Hermans
              Submit Requirements:
              • requirement satisfiedCode-Coverage
              • requirement satisfiedCode-Owners
              • requirement satisfiedCode-Review
              • requirement satisfiedReview-Enforcement
              Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
              Gerrit-MessageType: comment
              Gerrit-Project: chromium/src
              Gerrit-Branch: main
              Gerrit-Change-Id: I19b2ecffd1eb169cf1de85bc48198f1c954dc246
              Gerrit-Change-Number: 7820568
              Gerrit-PatchSet: 8
              Gerrit-Owner: Frederik Hermans <fred...@google.com>
              Gerrit-Reviewer: Bruno Braga <bruno...@google.com>
              Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
              Gerrit-Reviewer: Frederik Hermans <fred...@google.com>
              Gerrit-Reviewer: Henrik Andreasson <hen...@chromium.org>
              Gerrit-Reviewer: Johannes Kron <kr...@chromium.org>
              Gerrit-Reviewer: Olga Sharonova <ol...@chromium.org>
              Gerrit-Reviewer: Sandeep Vijayasekar <sa...@google.com>
              Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
              Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
              Gerrit-CC: Zijie He <zij...@google.com>
              Gerrit-Attention: Frederik Hermans <fred...@google.com>
              Gerrit-Attention: Bruno Braga <bruno...@google.com>
              Gerrit-Comment-Date: Wed, 13 May 2026 15:18:13 +0000
              Gerrit-HasComments: No
              Gerrit-Has-Labels: Yes
              satisfied_requirement
              open
              diffy

              Frederik Hermans (Gerrit)

              unread,
              May 13, 2026, 11:31:57 AM (5 days ago) May 13
              to Sandeep Vijayasekar, Henrik Andreasson, Johannes Kron, Olga Sharonova, luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, Bruno Braga, android-bu...@system.gserviceaccount.com, Rijubrata Bhaumik, Zijie He, Chromium Metrics Reviews, halliwe...@chromium.org, ios-r...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, fuchsia...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, chfreme...@chromium.org, asvitkine...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, mfoltz+wa...@chromium.org
              Attention needed from Bruno Braga

              Frederik Hermans voted Commit-Queue+2

              Commit-Queue+2
              Open in Gerrit

              Related details

              Attention is currently required from:
              • Bruno Braga
              Gerrit-Attention: Bruno Braga <bruno...@google.com>
              Gerrit-Comment-Date: Wed, 13 May 2026 15:31:36 +0000
              Gerrit-HasComments: No
              Gerrit-Has-Labels: Yes
              satisfied_requirement
              open
              diffy

              Johannes Kron (Gerrit)

              unread,
              May 15, 2026, 3:54:49 AM (3 days ago) May 15
              to Frederik Hermans, Sandeep Vijayasekar, Henrik Andreasson, Olga Sharonova, luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, Bruno Braga, android-bu...@system.gserviceaccount.com, Rijubrata Bhaumik, Zijie He, Chromium Metrics Reviews, halliwe...@chromium.org, ios-r...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, fuchsia...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, chfreme...@chromium.org, asvitkine...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, mfoltz+wa...@chromium.org
              Attention needed from Bruno Braga, Frederik Hermans, Henrik Andreasson, Olga Sharonova and Sandeep Vijayasekar

              Johannes Kron voted Code-Review+1

              Code-Review+1
              Open in Gerrit

              Related details

              Attention is currently required from:
              • Bruno Braga
              • Frederik Hermans
              • Henrik Andreasson
              • Olga Sharonova
              • Sandeep Vijayasekar
                Submit Requirements:
                  • requirement satisfiedCode-Coverage
                  • requirement satisfiedCode-Owners
                  • requirement is not satisfiedCode-Review
                  • requirement satisfiedReview-Enforcement
                  Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                  Gerrit-MessageType: comment
                  Gerrit-Project: chromium/src
                  Gerrit-Branch: main
                  Gerrit-Change-Id: I19b2ecffd1eb169cf1de85bc48198f1c954dc246
                  Gerrit-Change-Number: 7820568
                  Gerrit-PatchSet: 9
                  Gerrit-Owner: Frederik Hermans <fred...@google.com>
                  Gerrit-Reviewer: Bruno Braga <bruno...@google.com>
                  Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
                  Gerrit-Reviewer: Frederik Hermans <fred...@google.com>
                  Gerrit-Reviewer: Henrik Andreasson <hen...@chromium.org>
                  Gerrit-Reviewer: Johannes Kron <kr...@chromium.org>
                  Gerrit-Reviewer: Olga Sharonova <ol...@chromium.org>
                  Gerrit-Reviewer: Sandeep Vijayasekar <sa...@google.com>
                  Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
                  Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
                  Gerrit-CC: Zijie He <zij...@google.com>
                  Gerrit-Attention: Olga Sharonova <ol...@chromium.org>
                  Gerrit-Attention: Henrik Andreasson <hen...@chromium.org>
                  Gerrit-Attention: Frederik Hermans <fred...@google.com>
                  Gerrit-Attention: Sandeep Vijayasekar <sa...@google.com>
                  Gerrit-Attention: Bruno Braga <bruno...@google.com>
                  Gerrit-Comment-Date: Fri, 15 May 2026 07:54:31 +0000
                  Gerrit-HasComments: No
                  Gerrit-Has-Labels: Yes
                  satisfied_requirement
                  unsatisfied_requirement
                  open
                  diffy

                  Henrik Andreasson (Gerrit)

                  unread,
                  3:07 AM (7 hours ago) 3:07 AM
                  to Frederik Hermans, Johannes Kron, Sandeep Vijayasekar, Olga Sharonova, luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, Bruno Braga, android-bu...@system.gserviceaccount.com, Rijubrata Bhaumik, Zijie He, Chromium Metrics Reviews, halliwe...@chromium.org, ios-r...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, fuchsia...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, chfreme...@chromium.org, asvitkine...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, mfoltz+wa...@chromium.org
                  Attention needed from Bruno Braga, Frederik Hermans, Olga Sharonova and Sandeep Vijayasekar

                  Henrik Andreasson voted Code-Review+1

                  Code-Review+1
                  Open in Gerrit

                  Related details

                  Attention is currently required from:
                  • Bruno Braga
                  • Frederik Hermans
                  • Olga Sharonova
                  • Sandeep Vijayasekar
                  Submit Requirements:
                    • requirement satisfiedCode-Coverage
                    • requirement satisfiedCode-Owners
                    • requirement satisfiedCode-Review
                    • requirement satisfiedReview-Enforcement
                    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                    Gerrit-MessageType: comment
                    Gerrit-Project: chromium/src
                    Gerrit-Branch: main
                    Gerrit-Change-Id: I19b2ecffd1eb169cf1de85bc48198f1c954dc246
                    Gerrit-Change-Number: 7820568
                    Gerrit-PatchSet: 9
                    Gerrit-Owner: Frederik Hermans <fred...@google.com>
                    Gerrit-Reviewer: Bruno Braga <bruno...@google.com>
                    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
                    Gerrit-Reviewer: Frederik Hermans <fred...@google.com>
                    Gerrit-Reviewer: Henrik Andreasson <hen...@chromium.org>
                    Gerrit-Reviewer: Johannes Kron <kr...@chromium.org>
                    Gerrit-Reviewer: Olga Sharonova <ol...@chromium.org>
                    Gerrit-Reviewer: Sandeep Vijayasekar <sa...@google.com>
                    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
                    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
                    Gerrit-CC: Zijie He <zij...@google.com>
                    Gerrit-Attention: Olga Sharonova <ol...@chromium.org>
                    Gerrit-Attention: Frederik Hermans <fred...@google.com>
                    Gerrit-Attention: Sandeep Vijayasekar <sa...@google.com>
                    Gerrit-Attention: Bruno Braga <bruno...@google.com>
                    Gerrit-Comment-Date: Mon, 18 May 2026 07:06:59 +0000
                    Gerrit-HasComments: No
                    Gerrit-Has-Labels: Yes
                    satisfied_requirement
                    open
                    diffy

                    Frederik Hermans (Gerrit)

                    unread,
                    3:09 AM (7 hours ago) 3:09 AM
                    to Henrik Andreasson, Johannes Kron, Sandeep Vijayasekar, Olga Sharonova, luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, Bruno Braga, android-bu...@system.gserviceaccount.com, Rijubrata Bhaumik, Zijie He, Chromium Metrics Reviews, halliwe...@chromium.org, ios-r...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, fuchsia...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, chfreme...@chromium.org, asvitkine...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, mfoltz+wa...@chromium.org
                    Attention needed from Bruno Braga, Olga Sharonova and Sandeep Vijayasekar

                    Frederik Hermans voted Commit-Queue+2

                    Commit-Queue+2
                    Open in Gerrit

                    Related details

                    Attention is currently required from:
                    • Bruno Braga
                    • Olga Sharonova
                    • Sandeep Vijayasekar
                    Gerrit-Attention: Sandeep Vijayasekar <sa...@google.com>
                    Gerrit-Attention: Bruno Braga <bruno...@google.com>
                    Gerrit-Comment-Date: Mon, 18 May 2026 07:08:51 +0000
                    Gerrit-HasComments: No
                    Gerrit-Has-Labels: Yes
                    satisfied_requirement
                    open
                    diffy

                    Olga Sharonova (Gerrit)

                    unread,
                    5:08 AM (5 hours ago) 5:08 AM
                    to Frederik Hermans, Henrik Andreasson, Johannes Kron, Sandeep Vijayasekar, luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, Bruno Braga, android-bu...@system.gserviceaccount.com, Rijubrata Bhaumik, Zijie He, Chromium Metrics Reviews, halliwe...@chromium.org, ios-r...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, fuchsia...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, chfreme...@chromium.org, asvitkine...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, mfoltz+wa...@chromium.org
                    Attention needed from Bruno Braga, Frederik Hermans and Sandeep Vijayasekar

                    Olga Sharonova voted Code-Review+1

                    Code-Review+1
                    Open in Gerrit

                    Related details

                    Attention is currently required from:
                    • Bruno Braga
                    • Frederik Hermans
                    • Sandeep Vijayasekar
                    Gerrit-Attention: Frederik Hermans <fred...@google.com>
                    Gerrit-Attention: Sandeep Vijayasekar <sa...@google.com>
                    Gerrit-Attention: Bruno Braga <bruno...@google.com>
                    Gerrit-Comment-Date: Mon, 18 May 2026 09:08:29 +0000
                    Gerrit-HasComments: No
                    Gerrit-Has-Labels: Yes
                    satisfied_requirement
                    open
                    diffy
                    Reply all
                    Reply to author
                    Forward
                    0 new messages