Disallow random() in container style queries [chromium/src : main]

[Munira Tursunova (Gerrit)]

Attention needed from Rune Lillesveen

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

• Rune Lillesveen

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I247934c3c81fe8bd22731f7f7a9632aa60ec84d4

Gerrit-Change-Number: 8174011

Gerrit-PatchSet: 1

Gerrit-Owner: Munira Tursunova <moo...@google.com>

Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>

Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>

Gerrit-Comment-Date: Mon, 03 Aug 2026 13:50:39 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Rune Lillesveen (Gerrit)]

Attention needed from Munira Tursunova

Rune Lillesveen voted and added 1 comment

Votes added by Rune Lillesveen

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Rune Lillesveen . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:

• Munira Tursunova

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I247934c3c81fe8bd22731f7f7a9632aa60ec84d4

Gerrit-Change-Number: 8174011

Gerrit-PatchSet: 1

Gerrit-Owner: Munira Tursunova <moo...@google.com>

Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>

Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Munira Tursunova <moo...@google.com>

Gerrit-Comment-Date: Mon, 03 Aug 2026 13:55:04 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Munira Tursunova (Gerrit)]

Munira Tursunova voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I247934c3c81fe8bd22731f7f7a9632aa60ec84d4

Gerrit-Change-Number: 8174011

Gerrit-PatchSet: 1

Gerrit-Owner: Munira Tursunova <moo...@google.com>

Gerrit-Reviewer: Munira Tursunova <moo...@google.com>

Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>

Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Mon, 03 Aug 2026 13:55:29 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Rune Lillesveen (Gerrit)]

Attention needed from Munira Tursunova

Rune Lillesveen added 1 comment

File third_party/blink/renderer/core/css/css_variable_data.cc

Line 99, Patchset 2 (Latest): has_random = true;

Rune Lillesveen . unresolved

Why did you move has_random part out of features/ExtractFeatures?

Open in Gerrit

Related details

Attention is currently required from:

• Munira Tursunova

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review

• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I247934c3c81fe8bd22731f7f7a9632aa60ec84d4

Gerrit-Change-Number: 8174011

Gerrit-PatchSet: 2

Gerrit-Owner: Munira Tursunova <moo...@google.com>

Gerrit-Reviewer: Munira Tursunova <moo...@google.com>

Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Munira Tursunova <moo...@google.com>

Gerrit-Comment-Date: Wed, 05 Aug 2026 07:51:36 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Munira Tursunova (Gerrit)]

Attention needed from Rune Lillesveen

Munira Tursunova added 1 comment

File third_party/blink/renderer/core/css/css_variable_data.cc

Line 99, Patchset 2 (Latest): has_random = true;

Rune Lillesveen . unresolved

Why did you move has_random part out of features/ExtractFeatures?

Munira Tursunova

Moved has_Random out of the features to prevent sizeof CSSVariableData increase. ExtractFeatures works with VariableDataFeatures, which does not have VariableDataFeature::kHasRandom anymore, so didn't want to mess the logic there.

Open in Gerrit

Related details

Attention is currently required from:

• Rune Lillesveen

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I247934c3c81fe8bd22731f7f7a9632aa60ec84d4

Gerrit-Change-Number: 8174011

Gerrit-PatchSet: 2

Gerrit-Owner: Munira Tursunova <moo...@google.com>

Gerrit-Reviewer: Munira Tursunova <moo...@google.com>

Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>

Gerrit-Comment-Date: Wed, 05 Aug 2026 08:47:43 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Rune Lillesveen <fut...@chromium.org>

[Rune Lillesveen (Gerrit)]

Attention needed from Munira Tursunova

Rune Lillesveen added 1 comment

File third_party/blink/renderer/core/css/css_variable_data.cc

Line 99, Patchset 2 (Latest): has_random = true;

Rune Lillesveen . unresolved

Why did you move has_random part out of features/ExtractFeatures?

Munira Tursunova

Moved has_Random out of the features to prevent sizeof CSSVariableData increase. ExtractFeatures works with VariableDataFeatures, which does not have VariableDataFeature::kHasRandom anymore, so didn't want to mess the logic there.

Rune Lillesveen

Why would increasing kVariableDataFeatureBits be different from adding a new boolean bit?

Open in Gerrit

Related details

Attention is currently required from:

• Munira Tursunova

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I247934c3c81fe8bd22731f7f7a9632aa60ec84d4

Gerrit-Change-Number: 8174011

Gerrit-PatchSet: 2

Gerrit-Owner: Munira Tursunova <moo...@google.com>

Gerrit-Reviewer: Munira Tursunova <moo...@google.com>

Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Munira Tursunova <moo...@google.com>

Gerrit-Comment-Date: Wed, 05 Aug 2026 10:51:53 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Rune Lillesveen <fut...@chromium.org>

Comment-In-Reply-To: Munira Tursunova <moo...@google.com>

[Munira Tursunova (Gerrit)]

Attention needed from Rune Lillesveen

Munira Tursunova added 1 comment

File third_party/blink/renderer/core/css/css_variable_data.cc

Line 99, Patchset 2: has_random = true;

Rune Lillesveen . resolved

Why did you move has_random part out of features/ExtractFeatures?

Munira Tursunova

Moved has_Random out of the features to prevent sizeof CSSVariableData increase. ExtractFeatures works with VariableDataFeatures, which does not have VariableDataFeature::kHasRandom anymore, so didn't want to mess the logic there.

Rune Lillesveen

Why would increasing kVariableDataFeatureBits be different from adding a new boolean bit?

Munira Tursunova

yeah, I don't know what I was thinking, I should have just decreased unused bits size 🫪 well that's embarrassing

Open in Gerrit

Related details

Attention is currently required from:

• Rune Lillesveen

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I247934c3c81fe8bd22731f7f7a9632aa60ec84d4

Gerrit-Change-Number: 8174011

Gerrit-PatchSet: 4

Gerrit-Owner: Munira Tursunova <moo...@google.com>

Gerrit-Reviewer: Munira Tursunova <moo...@google.com>

Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>

Gerrit-Comment-Date: Wed, 05 Aug 2026 11:16:26 +0000

[Rune Lillesveen (Gerrit)]

Attention needed from Munira Tursunova

Rune Lillesveen voted and added 1 comment

Votes added by Rune Lillesveen

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Rune Lillesveen . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:

• Munira Tursunova

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I247934c3c81fe8bd22731f7f7a9632aa60ec84d4

Gerrit-Change-Number: 8174011

Gerrit-PatchSet: 4

Gerrit-Owner: Munira Tursunova <moo...@google.com>

Gerrit-Reviewer: Munira Tursunova <moo...@google.com>

Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Munira Tursunova <moo...@google.com>

Gerrit-Comment-Date: Wed, 05 Aug 2026 11:21:06 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Munira Tursunova (Gerrit)]

Munira Tursunova voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I247934c3c81fe8bd22731f7f7a9632aa60ec84d4

Gerrit-Change-Number: 8174011

Gerrit-PatchSet: 4

Gerrit-Owner: Munira Tursunova <moo...@google.com>

Gerrit-Reviewer: Munira Tursunova <moo...@google.com>

Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Wed, 05 Aug 2026 11:21:30 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes