[WebAudio] Implement async platform device initialization (Part 2 of 3) [chromium/src : main]

[Mahesh Kannan (Gerrit)]

Attention needed from Michael Wilson

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

• Michael Wilson

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia231e4e20d69143b4bf83caa41102509d64e724c

Gerrit-Change-Number: 8063809

Gerrit-PatchSet: 7

Gerrit-Owner: Mahesh Kannan <kmah...@google.com>

Gerrit-Reviewer: Mahesh Kannan <kmah...@google.com>

Gerrit-Reviewer: Michael Wilson <mjwi...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Michael Wilson <mjwi...@chromium.org>

Gerrit-Comment-Date: Fri, 17 Jul 2026 17:38:04 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Michael Wilson (Gerrit)]

Attention needed from Michael Wilson

Michael Wilson added 1 comment

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Michael Wilson . unresolved

Sorry about the delay in my review. I may need another day or two before I can work through this.

Open in Gerrit

Related details

Attention is currently required from:

• Michael Wilson

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia231e4e20d69143b4bf83caa41102509d64e724c

Gerrit-Change-Number: 8063809

Gerrit-PatchSet: 7

Gerrit-Owner: Mahesh Kannan <kmah...@google.com>

Gerrit-Reviewer: Mahesh Kannan <kmah...@google.com>

Gerrit-Reviewer: Michael Wilson <mjwi...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Hongchan Choi <hong...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Michael Wilson <mjwi...@chromium.org>

Gerrit-Comment-Date: Mon, 20 Jul 2026 17:24:39 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Michael Wilson (Gerrit)]

Attention needed from Mahesh Kannan

Michael Wilson added 1 comment

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Michael Wilson . unresolved

Sorry about the delay in my review. I may need another day or two before I can work through this.

Michael Wilson

Sorry again about the long delay. Please resolve the merge conflicts and then I should have time to take a look.

Open in Gerrit

Related details

Attention is currently required from:

• Mahesh Kannan

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia231e4e20d69143b4bf83caa41102509d64e724c

Gerrit-Change-Number: 8063809

Gerrit-PatchSet: 7

Gerrit-Owner: Mahesh Kannan <kmah...@google.com>

Gerrit-Reviewer: Mahesh Kannan <kmah...@google.com>

Gerrit-Reviewer: Michael Wilson <mjwi...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: Hongchan Choi <hong...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Mahesh Kannan <kmah...@google.com>

Gerrit-Comment-Date: Tue, 04 Aug 2026 00:15:23 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Michael Wilson <mjwi...@chromium.org>

[Mahesh Kannan (Gerrit)]

Attention needed from Michael Wilson

Mahesh Kannan added 1 comment

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Mahesh Kannan . resolved

Rebased and fixed CQ failure, PTAL whenever possible. Thanks!

Open in Gerrit

Related details

Attention is currently required from:

• Michael Wilson

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia231e4e20d69143b4bf83caa41102509d64e724c

Gerrit-Change-Number: 8063809

Gerrit-PatchSet: 10

Gerrit-Owner: Mahesh Kannan <kmah...@google.com>

Gerrit-Reviewer: Mahesh Kannan <kmah...@google.com>

Gerrit-Reviewer: Michael Wilson <mjwi...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: Hongchan Choi <hong...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Michael Wilson <mjwi...@chromium.org>

Gerrit-Comment-Date: Tue, 04 Aug 2026 21:51:49 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Michael Wilson (Gerrit)]

Attention needed from Hongchan Choi and Mahesh Kannan

Michael Wilson added 3 comments

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Michael Wilson . resolved

I added a couple of initial comments, but it will probably take me a few passes to fully understand this change. Also adding Hongchan for an additional point of view.

I know we discussed that this change isn't really possible to split up, but if we could find even some small things to break off as pre-work CLs it would make the review easier.

File content/renderer/media/renderer_webaudiodevice_impl.cc

Line 91, Patchset 10 (Latest): .DeprecatedDefaultTaskRunner();

Michael Wilson . unresolved

We should probably not add new usages of deprecated APIs. It it possible to use an execution context or non-JS-capable thread scheduler instead?

Line 368, Patchset 10 (Latest): if (!weak_this) {
return;

Michael Wilson . unresolved

Is this pattern checking if this object has been destructed during the loop?

Open in Gerrit

Related details

Attention is currently required from:

• Hongchan Choi
• Mahesh Kannan

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia231e4e20d69143b4bf83caa41102509d64e724c

Gerrit-Change-Number: 8063809

Gerrit-PatchSet: 10

Gerrit-Owner: Mahesh Kannan <kmah...@google.com>

Gerrit-Reviewer: Hongchan Choi <hong...@chromium.org>

Gerrit-Reviewer: Mahesh Kannan <kmah...@google.com>

Gerrit-Reviewer: Michael Wilson <mjwi...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Mahesh Kannan <kmah...@google.com>

Gerrit-Attention: Hongchan Choi <hong...@chromium.org>

Gerrit-Comment-Date: Wed, 05 Aug 2026 01:22:50 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Michael Wilson (Gerrit)]

Attention needed from Hongchan Choi and Mahesh Kannan

Michael Wilson added 1 comment

Patchset-level comments

File-level comment, Patchset 7:

Michael Wilson . resolved

Sorry about the delay in my review. I may need another day or two before I can work through this.

Michael Wilson

Sorry again about the long delay. Please resolve the merge conflicts and then I should have time to take a look.

Michael Wilson

Done

Gerrit-Comment-Date: Wed, 05 Aug 2026 01:23:10 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Michael Wilson <mjwi...@chromium.org>