Groups keyboard shortcuts have been updated
Dismiss
See shortcuts

Disable C4467 'usage of ATL attributes is deprecated' in midi (issue 2308093002 by scottmg@chromium.org)

887 views
Skip to first unread message

sco...@chromium.org

unread,
Sep 2, 2016, 5:21:15 PM9/2/16
to toyoshim...@chromium.org, chromium...@chromium.org, feature-me...@chromium.org, toyosh...@chromium.org
Reviewers: toyoshim
CL: https://codereview.chromium.org/2308093002/

Description:
Disable C4467 'usage of ATL attributes is deprecated' in midi

robuffer.h causes

d:\src\depot_tools\win_toolchain\vs_files\d5dc33b15d1b2c086f2f6632e2fd15882f80dbd3\win_sdk\include\10.0.10586.0\winrt\robuffer.h(46):
warning C4467: usage of ATL attributes is deprecated

on VS2015 Update 3.

BUG=627216,637456

Affected files (+1, -0 lines):
M media/midi/BUILD.gn


Index: media/midi/BUILD.gn
diff --git a/media/midi/BUILD.gn b/media/midi/BUILD.gn
index cdea3b77f6ae812369d94a515bf80c66e50b811a..19911a395853465b7d2c4109cfa92dfca6112498 100644
--- a/media/midi/BUILD.gn
+++ b/media/midi/BUILD.gn
@@ -143,6 +143,7 @@ component("midi") {
"midi_manager_winrt.cc",
"midi_manager_winrt.h",
]
+ cflags = [ "/wd4467" ] # usage of ATL attributes is deprecated.
}

if (use_alsa && use_udev) {


bruce...@chromium.org

unread,
Sep 2, 2016, 5:27:37 PM9/2/16
to sco...@chromium.org, toyoshim...@chromium.org, chromium...@chromium.org, feature-me...@chromium.org, toyosh...@chromium.org

qianku...@intel.com

unread,
Sep 2, 2016, 9:39:24 PM9/2/16
to sco...@chromium.org, toyoshim...@chromium.org, bruce...@chromium.org, chromium...@chromium.org, feature-me...@chromium.org, toyosh...@chromium.org

sco...@chromium.org

unread,
Sep 2, 2016, 10:35:12 PM9/2/16
to toyoshim...@chromium.org, bruce...@chromium.org, qianku...@intel.com, chromium...@chromium.org, feature-me...@chromium.org, toyosh...@chromium.org
On 2016/09/03 01:39:24, qiankun wrote:
> I fixed this issue in another way:
https://codereview.chromium.org/2301523008/.

toyo...@chromium.org

unread,
Sep 5, 2016, 2:19:51 AM9/5/16
to sco...@chromium.org, bruce...@chromium.org, qianku...@intel.com, chromium...@chromium.org, feature-me...@chromium.org, toyosh...@chromium.org
Thank you guys for handling this issue, and sorry for overlooking this error.

https://codereview.chromium.org/2308093002/

sco...@chromium.org

unread,
Sep 6, 2016, 1:39:34 PM9/6/16
to toyoshim...@chromium.org, bruce...@chromium.org, qianku...@intel.com, chromium...@chromium.org, feature-me...@chromium.org, toyosh...@chromium.org
On 2016/09/05 06:19:50, toyoshim wrote:
> Thank you guys for handling this issue, and sorry for overlooking this error.

No problem, nothing to overlook -- we haven't switched to this release of the
compiler yet so there's no way you could have known.

https://codereview.chromium.org/2308093002/
Reply all
Reply to author
Forward
0 new messages