[fileapi] Remove Blob's URLRegistry dependency [chromium/src : main]
0 views
Skip to first unread message
Aaron Teo (Gerrit)
Aug 3, 2026, 10:50:44 PM (2 days ago) Aug 3
to Ming-Ying Chung, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, feature-me...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko+...@chromium.org
Attention needed from Ming-Ying Chung
Aaron Teo added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Aaron Teo . resolved
+mych
Hello, please take a look at this CL when you have time, thank you!
Related details
Attention is currently required from:
- Ming-Ying Chung
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aaron Teo (Gerrit)
Aug 4, 2026, 7:53:09 PM (12 hours ago) Aug 4
to Tsuyoshi Horo, Ming-Ying Chung, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, feature-me...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko+...@chromium.org
Attention needed from Tsuyoshi Horo
Aaron Teo added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Tsuyoshi Horo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tsuyoshi Horo (Gerrit)
Aug 4, 2026, 8:13:37 PM (11 hours ago) Aug 4
to Aaron Teo, Ming-Ying Chung, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, feature-me...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko+...@chromium.org
Attention needed from Ming-Ying Chung
Tsuyoshi Horo added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Tsuyoshi Horo . resolved
Sorry, I'm no longer storage OWNER https://crrev.com/c/8192056 . (I forgot to remove me from storage/OWNERS in https://crrev.com/c/8104855 .)
mych@
Could you please review this? Or could you assign it to someone on the storage team?
Related details
Attention is currently required from:
- Ming-Ying Chung
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ming-Ying Chung (Gerrit)
Aug 4, 2026, 8:21:33 PM (11 hours ago) Aug 4
to Aaron Teo, Tsuyoshi Horo, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, feature-me...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko+...@chromium.org
Attention needed from Aaron Teo
Ming-Ying Chung added 1 comment![]( "Open in Gerrit")
Commit Message
Line 9, Patchset 3 (Latest):
Remove Blob's URLRegistrable implementation and its dummyMing-Ying Chung . unresolved
Could you provide any context why this removal is needed and why it's okay? It's not clear in the CL.
Related details
Attention is currently required from:
- Aaron Teo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aaron Teo (Gerrit)
Aug 4, 2026, 8:40:39 PM (11 hours ago) Aug 4
to Ming-Ying Chung, Tsuyoshi Horo, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, feature-me...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko+...@chromium.org
Attention needed from Ming-Ying Chung
Aaron Teo added 1 comment![]( "Open in Gerrit")
Commit Message
Line 9, Patchset 3:
Remove Blob's URLRegistrable implementation and its dummyMing-Ying Chung . resolved
Could you provide any context why this removal is needed and why it's okay? It's not clear in the CL.
Aaron Teo
Thank you for the review; I have updated the commit message. Please take another look.
Related details
Attention is currently required from:
- Ming-Ying Chung
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aaron Teo (Gerrit)
2:29 AM (5 hours ago) 2:29 AM
to Ming-Ying Chung, Tsuyoshi Horo, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, feature-me...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko+...@chromium.org
Attention needed from Ming-Ying Chung
Aaron Teo added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Aaron Teo . resolved
@mych
Hi, when you have some free time, could you please take a look at this CL? If there are any issues, please feel free to let me know. Thanks!
Related details
Attention is currently required from:
- Ming-Ying Chung
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ming-Ying Chung (Gerrit)
3:34 AM (4 hours ago) 3:34 AM
to Aaron Teo, Tsuyoshi Horo, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, feature-me...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko+...@chromium.org
Attention needed from Aaron Teo
Ming-Ying Chung added 3 comments![]( "Open in Gerrit")
Commit Message
Line 9, Patchset 4 (Latest):
Now that MojoBlobURL and the Network Service are fully shipped, Blob noMing-Ying Chung . unresolved
Could you add links or reference to these in the description, and explain more about the relationship between the refactored target?
File third_party/blink/renderer/core/fileapi/blob.cc
Line 86, Patchset 4 (Latest):
BlobFileReaderClient(scoped_refptr<BlobDataHandle> blob_data_handle,
scoped_refptr<base::SingleThreadTaskRunner> task_runner,
FileReadType read_type,Ming-Ying Chung . unresolved
Why are the const qualifiers removed?
File third_party/blink/renderer/core/fileapi/public_url_manager.cc
Line 157, Patchset 4 (Latest):
String PublicURLManager::RegisterURL(Blob* blob) {Ming-Ying Chung . unresolved
This is hard to compare. Can you move this before `GenerateURL()` so that git displays the minimal diff?
Related details
Attention is currently required from:
- Aaron Teo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages