[IWA] Move IwaKeyDistributionInfoProvider to //components (Mechanical Move) [chromium/src : main]

0 views
Skip to first unread message

Magdalena Skarbińska (Gerrit)

unread,
Jun 26, 2026, 8:06:58 AM (3 days ago) Jun 26
to James Maclean, Mark Schillaci, Kevin McNee, Chromium Metrics Reviews, (Julie)Jeongeun Kim, Andrew Rayskiy, Edman Anjos, Rijubrata Bhaumik, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Chromium LUCI CQ, ios-r...@chromium.org, ios-revie...@chromium.org, josiah...@chromium.org, yuzo+...@chromium.org, francisjp...@google.com, nektar...@chromium.org, abigailbk...@google.com, blink-...@chromium.org, michaelchec...@google.com, dtseng...@chromium.org, jdonnel...@chromium.org, extension...@chromium.org, marq+...@chromium.org, omnibox-...@chromium.org, android-web...@chromium.org, chromium-a...@chromium.org, devtools...@chromium.org, yongshun+...@google.com, christia...@chromium.org, kyungjunle...@google.com, dewitt...@chromium.org, asvitkine...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, chfreme...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, chromeos-kio...@google.com, aixba+wat...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, droger+w...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, rmcelra...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Andrew Rayskiy and Edman Anjos

Magdalena Skarbińska added 16 comments

Patchset-level comments
File-level comment, Patchset 23:
Edman Anjos . resolved

I made some comments about splitting things to separate CLs. in general let's avoid making refactors while moving/renaming files as it's harder to review.

Magdalena Skarbińska

Done

Commit Message
Line 7, Patchset 22:Move IwaKeyDistributionInfoProvider and installer policy to //components
Edman Anjos . resolved

needs update, the installer policy is still in //chrome

also below

Magdalena Skarbińska

Done

File chrome/browser/component_updater/iwa_key_distribution_component_installer.h
Line 30, Patchset 19 (Parent):BASE_DECLARE_FEATURE(kIwaKeyDistributionComponent);
Andrew Rayskiy . resolved

This flag logically belongs to the installer and to the `component_updater` namespace, so it has to stay with the installer.

Magdalena Skarbińska

Done

File chrome/browser/component_updater/iwa_key_distribution_component_installer.cc
Line 110, Patchset 22:void IwaKeyDistributionComponentInstallerPolicy::SetUp() {
Edman Anjos . resolved

it seems you create the class and immediately call `SetUp`.

can `SetUp` be implemented in the ctor instead of a separate function?

Magdalena Skarbińska

Done

Line 116, Patchset 19: return web_app::IwaKeyDistributionInfoProvider::GetInstance();
Andrew Rayskiy . resolved

nit: it's much easier to just inline these calls, no need for a separate func

Magdalena Skarbińska

Done

Line 157, Patchset 19 (Parent): // No custom install.
Andrew Rayskiy . resolved

revert

Magdalena Skarbińska

Done

File chrome/browser/media/webrtc/multi_capture/multi_capture_data_service.h
Line 34, Patchset 19 (Parent):class ChromeIwaRuntimeDataProvider;
Andrew Rayskiy . resolved

revert?

Magdalena Skarbińska

Done

File chrome/browser/web_applications/isolated_web_apps/key_distribution/iwa_key_distribution_info_provider_unittest.cc
File-level comment, Patchset 22:
Edman Anjos . unresolved

should this be moved too?

Magdalena Skarbińska

I left it here bc I use component installer and test utils from //chrome in these tests. Is that ok then to leave it as is?

Line 511, Patchset 22:class IwaKeyDistributionInfoProviderReadinessTest
Edman Anjos . resolved

can you split this rename to a separate CL?

Magdalena Skarbińska

Done

File chrome/browser/web_applications/isolated_web_apps/runtime_data/chrome_iwa_runtime_data_provider.h
Line 18, Patchset 22 (Parent):class ChromeIwaRuntimeDataProvider : public IwaRuntimeDataProvider {
Edman Anjos . resolved

can this be split to a separate CL?

Magdalena Skarbińska

Done

File chrome/browser/web_applications/isolated_web_apps/test/key_distribution/test_utils.h
Line 39, Patchset 22 (Parent):// A builder-style class to help create and update the key distribution
Edman Anjos . resolved

let's keep those comments

Magdalena Skarbińska

Done

Line 21, Patchset 19 (Parent):struct IwaComponentMetadata {
Andrew Rayskiy . resolved

I pointed this out in a separate CL -- this testing infra is intended to be used in very specific user journeys that require actually loading the component data. Do you really need it in `//components`?

Edman Anjos

No strong opinion on my side but this sounds fair to me. The helpers are related to key distribution so it makes sense to colocate them, which seems possible as they don't have `//chrome` dependencies.

Magdalena Skarbińska

Acknowledged

File components/webapps/isolated_web_apps/key_distribution/features.cc
Line 10, Patchset 19:BASE_FEATURE(kIwaKeyDistributionDevMode, base::FEATURE_DISABLED_BY_DEFAULT);
Andrew Rayskiy . resolved

This is only used in `//chrome` and doesn't have to be moved. Feel free to inline it in an anon namespace in `chrome/browser/ui/webui/web_app_internals/web_app_internals_ui.cc`

Magdalena Skarbińska

Done

File components/webapps/isolated_web_apps/key_distribution/iwa_key_distribution_info_provider.h
Line 49, Patchset 22: static IwaKeyDistributionInfoProvider& GetInstance();
Edman Anjos . resolved

can you split this to a separate CL?

Magdalena Skarbińska

Done

File components/webapps/isolated_web_apps/key_distribution/iwa_key_distribution_info_provider.cc
Line 396, Patchset 22: if (!is_setup_) {
Edman Anjos . resolved

the previous code seems good enough. you can rely on the `queue_on_demand_update_` callback being null before `SetUp` is called, so we don't need the new `is_setup_` flag

you could call `.is_null()` if you want to be explicit

Magdalena Skarbińska

Done

Line 530, Patchset 22: if (queue_on_demand_update_) {
Edman Anjos . unresolved

should the code below this `if` block still run when `queue_on_demand_update_` is null?

I'm wondering if this check should be moved to L528 as an early exit like `if (!queue_on_demand_update_) return;`

Magdalena Skarbińska

i reverted the check to be present again

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Rayskiy
  • Edman Anjos
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4f89e9cd7a5a4013bcca3740b9011a33bf530939
Gerrit-Change-Number: 7941934
Gerrit-PatchSet: 33
Gerrit-Owner: Magdalena Skarbińska <mskar...@google.com>
Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
Gerrit-Reviewer: Edman Anjos <ed...@chromium.org>
Gerrit-Reviewer: Magdalena Skarbińska <mskar...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Kevin McNee <mc...@chromium.org>
Gerrit-CC: Mark Schillaci <mschi...@google.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-Attention: Andrew Rayskiy <green...@google.com>
Gerrit-Attention: Edman Anjos <ed...@chromium.org>
Gerrit-Comment-Date: Fri, 26 Jun 2026 12:06:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Andrew Rayskiy <green...@google.com>
Comment-In-Reply-To: Edman Anjos <ed...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Edman Anjos (Gerrit)

unread,
Jun 26, 2026, 9:13:20 AM (3 days ago) Jun 26
to Magdalena Skarbińska, Edman Anjos, James Maclean, Mark Schillaci, Kevin McNee, Chromium Metrics Reviews, (Julie)Jeongeun Kim, Andrew Rayskiy, Rijubrata Bhaumik, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Chromium LUCI CQ, ios-r...@chromium.org, ios-revie...@chromium.org, josiah...@chromium.org, yuzo+...@chromium.org, francisjp...@google.com, nektar...@chromium.org, abigailbk...@google.com, blink-...@chromium.org, michaelchec...@google.com, dtseng...@chromium.org, jdonnel...@chromium.org, extension...@chromium.org, marq+...@chromium.org, omnibox-...@chromium.org, android-web...@chromium.org, chromium-a...@chromium.org, devtools...@chromium.org, yongshun+...@google.com, christia...@chromium.org, kyungjunle...@google.com, dewitt...@chromium.org, asvitkine...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, chfreme...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, chromeos-kio...@google.com, aixba+wat...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, droger+w...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, rmcelra...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Andrew Rayskiy and Magdalena Skarbińska

Edman Anjos voted and added 6 comments

Votes added by Edman Anjos

Code-Review+1

6 comments

Patchset-level comments
File-level comment, Patchset 33 (Latest):
Edman Anjos . resolved

thanks Magda, LGTM % few comments and questions

Commit Message
Line 22, Patchset 33 (Latest):TAG=agy CONV=8a5fe3f3-89f8-427b-8e45-62c0d5e3d48d
Edman Anjos . unresolved

I think you can remove this line, AFAIK this is meant for google3

Line 23, Patchset 33 (Latest):
Edman Anjos . unresolved

add a `Bug: number` please

File chrome/browser/component_updater/iwa_key_distribution_component_installer.h
Line 57, Patchset 33 (Parent): base::PassKey<web_app::IwaKeyDistributionInfoProvider>);
Edman Anjos . unresolved

is it intentional that the passkey was removed in this CL?

File chrome/browser/web_applications/isolated_web_apps/key_distribution/iwa_key_distribution_info_provider_unittest.cc
File-level comment, Patchset 22:
Edman Anjos . resolved

should this be moved too?

Magdalena Skarbińska

I left it here bc I use component installer and test utils from //chrome in these tests. Is that ok then to leave it as is?

Edman Anjos

Acknowledged, thanks for explaining

File components/webapps/isolated_web_apps/key_distribution/iwa_key_distribution_info_provider.cc
Line 530, Patchset 22: if (queue_on_demand_update_) {
Edman Anjos . unresolved

should the code below this `if` block still run when `queue_on_demand_update_` is null?

I'm wondering if this check should be moved to L528 as an early exit like `if (!queue_on_demand_update_) return;`

Magdalena Skarbińska

i reverted the check to be present again

Edman Anjos

if you have `CHECK` above you can remove the `if (queue_on_demand_update_)` here.

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Rayskiy
  • Magdalena Skarbińska
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4f89e9cd7a5a4013bcca3740b9011a33bf530939
    Gerrit-Change-Number: 7941934
    Gerrit-PatchSet: 33
    Gerrit-Owner: Magdalena Skarbińska <mskar...@google.com>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Edman Anjos <ed...@chromium.org>
    Gerrit-Reviewer: Magdalena Skarbińska <mskar...@google.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: James Maclean <wjma...@chromium.org>
    Gerrit-CC: Kevin McNee <mc...@chromium.org>
    Gerrit-CC: Mark Schillaci <mschi...@google.com>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-Attention: Magdalena Skarbińska <mskar...@google.com>
    Gerrit-Attention: Andrew Rayskiy <green...@google.com>
    Gerrit-Comment-Date: Fri, 26 Jun 2026 13:13:02 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Magdalena Skarbińska <mskar...@google.com>
    Comment-In-Reply-To: Edman Anjos <ed...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Andrew Rayskiy (Gerrit)

    unread,
    Jun 26, 2026, 10:27:51 AM (3 days ago) Jun 26
    to Magdalena Skarbińska, Edman Anjos, James Maclean, Mark Schillaci, Kevin McNee, Chromium Metrics Reviews, (Julie)Jeongeun Kim, Rijubrata Bhaumik, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Chromium LUCI CQ, ios-r...@chromium.org, ios-revie...@chromium.org, josiah...@chromium.org, yuzo+...@chromium.org, francisjp...@google.com, nektar...@chromium.org, abigailbk...@google.com, blink-...@chromium.org, michaelchec...@google.com, dtseng...@chromium.org, jdonnel...@chromium.org, extension...@chromium.org, marq+...@chromium.org, omnibox-...@chromium.org, android-web...@chromium.org, chromium-a...@chromium.org, devtools...@chromium.org, yongshun+...@google.com, christia...@chromium.org, kyungjunle...@google.com, dewitt...@chromium.org, asvitkine...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, chfreme...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, chromeos-kio...@google.com, aixba+wat...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, droger+w...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, rmcelra...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
    Attention needed from Magdalena Skarbińska

    Andrew Rayskiy voted and added 1 comment

    Votes added by Andrew Rayskiy

    Code-Review+1

    1 comment

    File chrome/browser/component_updater/iwa_key_distribution_component_installer.h
    Line 15, Patchset 36 (Latest):#include "base/memory/weak_ptr.h"
    Andrew Rayskiy . unresolved

    Is this needed?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Magdalena Skarbińska
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4f89e9cd7a5a4013bcca3740b9011a33bf530939
    Gerrit-Change-Number: 7941934
    Gerrit-PatchSet: 36
    Gerrit-Owner: Magdalena Skarbińska <mskar...@google.com>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Edman Anjos <ed...@chromium.org>
    Gerrit-Reviewer: Magdalena Skarbińska <mskar...@google.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: James Maclean <wjma...@chromium.org>
    Gerrit-CC: Kevin McNee <mc...@chromium.org>
    Gerrit-CC: Mark Schillaci <mschi...@google.com>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-Attention: Magdalena Skarbińska <mskar...@google.com>
    Gerrit-Comment-Date: Fri, 26 Jun 2026 14:27:34 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Magdalena Skarbińska (Gerrit)

    unread,
    Jun 26, 2026, 11:15:07 AM (3 days ago) Jun 26
    to Andrew Rayskiy, Edman Anjos, James Maclean, Mark Schillaci, Kevin McNee, Chromium Metrics Reviews, (Julie)Jeongeun Kim, Rijubrata Bhaumik, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Chromium LUCI CQ, ios-r...@chromium.org, ios-revie...@chromium.org, josiah...@chromium.org, yuzo+...@chromium.org, francisjp...@google.com, nektar...@chromium.org, abigailbk...@google.com, blink-...@chromium.org, michaelchec...@google.com, dtseng...@chromium.org, jdonnel...@chromium.org, extension...@chromium.org, marq+...@chromium.org, omnibox-...@chromium.org, android-web...@chromium.org, chromium-a...@chromium.org, devtools...@chromium.org, yongshun+...@google.com, christia...@chromium.org, kyungjunle...@google.com, dewitt...@chromium.org, asvitkine...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, chfreme...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, chromeos-kio...@google.com, aixba+wat...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, droger+w...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, rmcelra...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

    Magdalena Skarbińska voted and added 5 comments

    Votes added by Magdalena Skarbińska

    Commit-Queue+1

    5 comments

    Commit Message
    Line 22, Patchset 33:TAG=agy CONV=8a5fe3f3-89f8-427b-8e45-62c0d5e3d48d
    Edman Anjos . resolved

    I think you can remove this line, AFAIK this is meant for google3

    Magdalena Skarbińska

    Done

    Line 23, Patchset 33:
    Edman Anjos . resolved

    add a `Bug: number` please

    Magdalena Skarbińska

    Done

    File chrome/browser/component_updater/iwa_key_distribution_component_installer.h
    Line 15, Patchset 36:#include "base/memory/weak_ptr.h"
    Andrew Rayskiy . resolved

    Is this needed?

    Magdalena Skarbińska

    Done

    Line 57, Patchset 33 (Parent): base::PassKey<web_app::IwaKeyDistributionInfoProvider>);
    Edman Anjos . resolved

    is it intentional that the passkey was removed in this CL?

    Magdalena Skarbińska

    it came back right now :)

    File components/webapps/isolated_web_apps/key_distribution/iwa_key_distribution_info_provider.cc
    Line 530, Patchset 22: if (queue_on_demand_update_) {
    Edman Anjos . resolved

    should the code below this `if` block still run when `queue_on_demand_update_` is null?

    I'm wondering if this check should be moved to L528 as an early exit like `if (!queue_on_demand_update_) return;`

    Magdalena Skarbińska

    i reverted the check to be present again

    Edman Anjos

    if you have `CHECK` above you can remove the `if (queue_on_demand_update_)` here.

    Magdalena Skarbińska

    Done

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I4f89e9cd7a5a4013bcca3740b9011a33bf530939
      Gerrit-Change-Number: 7941934
      Gerrit-PatchSet: 36
      Gerrit-Owner: Magdalena Skarbińska <mskar...@google.com>
      Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
      Gerrit-Reviewer: Edman Anjos <ed...@chromium.org>
      Gerrit-Reviewer: Magdalena Skarbińska <mskar...@google.com>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: James Maclean <wjma...@chromium.org>
      Gerrit-CC: Kevin McNee <mc...@chromium.org>
      Gerrit-CC: Mark Schillaci <mschi...@google.com>
      Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
      Gerrit-Comment-Date: Fri, 26 Jun 2026 15:14:48 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Magdalena Skarbińska <mskar...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      gwsq (Gerrit)

      unread,
      Jun 26, 2026, 11:21:12 AM (3 days ago) Jun 26
      to Magdalena Skarbińska, Chromium Web Applications Reviews, Kunjan Patel, Xiaoling Bao, Andrew Rayskiy, Edman Anjos, James Maclean, Mark Schillaci, Kevin McNee, Chromium Metrics Reviews, (Julie)Jeongeun Kim, Rijubrata Bhaumik, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Chromium LUCI CQ, ios-r...@chromium.org, ios-revie...@chromium.org, josiah...@chromium.org, yuzo+...@chromium.org, francisjp...@google.com, nektar...@chromium.org, abigailbk...@google.com, blink-...@chromium.org, michaelchec...@google.com, dtseng...@chromium.org, jdonnel...@chromium.org, extension...@chromium.org, marq+...@chromium.org, omnibox-...@chromium.org, android-web...@chromium.org, chromium-a...@chromium.org, devtools...@chromium.org, yongshun+...@google.com, christia...@chromium.org, kyungjunle...@google.com, dewitt...@chromium.org, asvitkine...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, chfreme...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, chromeos-kio...@google.com, aixba+wat...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, droger+w...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, rmcelra...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
      Attention needed from Kunjan Patel and Xiaoling Bao

      Message from gwsq

      Shadowed: ks...@chromium.org

      Reviewer source(s):
      ks...@chromium.org is from context(googleclient/chrome/chromium_gwsq/chrome/browser/ui/web_applications/config.gwsq,googleclient/chrome/chromium_gwsq/chrome/browser/web_applications/config.gwsq)

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Kunjan Patel
      • Xiaoling Bao
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I4f89e9cd7a5a4013bcca3740b9011a33bf530939
      Gerrit-Change-Number: 7941934
      Gerrit-PatchSet: 37
      Gerrit-Owner: Magdalena Skarbińska <mskar...@google.com>
      Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
      Gerrit-Reviewer: Edman Anjos <ed...@chromium.org>
      Gerrit-Reviewer: Kunjan Patel <ks...@chromium.org>
      Gerrit-Reviewer: Magdalena Skarbińska <mskar...@google.com>
      Gerrit-Reviewer: Xiaoling Bao <xiaol...@chromium.org>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Chromium Web Applications Reviews <chromium-web...@google.com>
      Gerrit-CC: James Maclean <wjma...@chromium.org>
      Gerrit-CC: Kevin McNee <mc...@chromium.org>
      Gerrit-CC: Mark Schillaci <mschi...@google.com>
      Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
      Gerrit-CC: gwsq
      Gerrit-Attention: Xiaoling Bao <xiaol...@chromium.org>
      Gerrit-Attention: Kunjan Patel <ks...@chromium.org>
      Gerrit-Comment-Date: Fri, 26 Jun 2026 15:20:35 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Andrew Rayskiy (Gerrit)

      unread,
      Jun 26, 2026, 11:22:43 AM (3 days ago) Jun 26
      to Magdalena Skarbińska, Chromium Web Applications Reviews, Kunjan Patel, Xiaoling Bao, Edman Anjos, James Maclean, Mark Schillaci, Kevin McNee, Chromium Metrics Reviews, (Julie)Jeongeun Kim, Rijubrata Bhaumik, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Chromium LUCI CQ, ios-r...@chromium.org, ios-revie...@chromium.org, josiah...@chromium.org, yuzo+...@chromium.org, francisjp...@google.com, nektar...@chromium.org, abigailbk...@google.com, blink-...@chromium.org, michaelchec...@google.com, dtseng...@chromium.org, jdonnel...@chromium.org, extension...@chromium.org, marq+...@chromium.org, omnibox-...@chromium.org, android-web...@chromium.org, chromium-a...@chromium.org, devtools...@chromium.org, yongshun+...@google.com, christia...@chromium.org, kyungjunle...@google.com, dewitt...@chromium.org, asvitkine...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, chfreme...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, chromeos-kio...@google.com, aixba+wat...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, droger+w...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, rmcelra...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
      Attention needed from Kunjan Patel, Magdalena Skarbińska and Xiaoling Bao

      Andrew Rayskiy voted and added 1 comment

      Votes added by Andrew Rayskiy

      Code-Review+1

      1 comment

      File chrome/browser/ui/webui/web_app_internals/iwa_internals_handler.cc
      Line 39, Patchset 37 (Latest):#include "components/webapps/isolated_web_apps/key_distribution/iwa_key_distribution_info_provider.h"
      Andrew Rayskiy . unresolved

      I believe this is not needed here anymore?

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Kunjan Patel
      • Magdalena Skarbińska
      • Xiaoling Bao
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        Gerrit-Attention: Magdalena Skarbińska <mskar...@google.com>
        Gerrit-Attention: Kunjan Patel <ks...@chromium.org>
        Gerrit-Comment-Date: Fri, 26 Jun 2026 15:22:25 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Kunjan Patel (Gerrit)

        unread,
        Jun 26, 2026, 8:22:26 PM (3 days ago) Jun 26
        to Magdalena Skarbińska, Daniel Murphy, Chromium Web Applications Reviews, Xiaoling Bao, Andrew Rayskiy, Edman Anjos, James Maclean, Mark Schillaci, Kevin McNee, Chromium Metrics Reviews, (Julie)Jeongeun Kim, Rijubrata Bhaumik, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Chromium LUCI CQ, ios-r...@chromium.org, ios-revie...@chromium.org, josiah...@chromium.org, yuzo+...@chromium.org, francisjp...@google.com, nektar...@chromium.org, abigailbk...@google.com, blink-...@chromium.org, michaelchec...@google.com, dtseng...@chromium.org, jdonnel...@chromium.org, extension...@chromium.org, marq+...@chromium.org, omnibox-...@chromium.org, android-web...@chromium.org, chromium-a...@chromium.org, devtools...@chromium.org, yongshun+...@google.com, christia...@chromium.org, kyungjunle...@google.com, dewitt...@chromium.org, asvitkine...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, chfreme...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, chromeos-kio...@google.com, aixba+wat...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, droger+w...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, rmcelra...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
        Attention needed from Daniel Murphy, Magdalena Skarbińska and Xiaoling Bao

        Kunjan Patel voted and added 1 comment

        Votes added by Kunjan Patel

        Code-Review+1

        1 comment

        Patchset-level comments
        File-level comment, Patchset 37 (Latest):
        Kunjan Patel . resolved

        LGTM! Assigning to an owner so that they can allow the code to land.

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Daniel Murphy
        • Magdalena Skarbińska
        • Xiaoling Bao
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I4f89e9cd7a5a4013bcca3740b9011a33bf530939
        Gerrit-Change-Number: 7941934
        Gerrit-PatchSet: 37
        Gerrit-Owner: Magdalena Skarbińska <mskar...@google.com>
        Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
        Gerrit-Reviewer: Daniel Murphy <dmu...@chromium.org>
        Gerrit-Reviewer: Edman Anjos <ed...@chromium.org>
        Gerrit-Reviewer: Kunjan Patel <ks...@chromium.org>
        Gerrit-Reviewer: Magdalena Skarbińska <mskar...@google.com>
        Gerrit-Reviewer: Xiaoling Bao <xiaol...@chromium.org>
        Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
        Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
        Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
        Gerrit-CC: Chromium Web Applications Reviews <chromium-web...@google.com>
        Gerrit-CC: James Maclean <wjma...@chromium.org>
        Gerrit-CC: Kevin McNee <mc...@chromium.org>
        Gerrit-CC: Mark Schillaci <mschi...@google.com>
        Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
        Gerrit-CC: gwsq
        Gerrit-Attention: Xiaoling Bao <xiaol...@chromium.org>
        Gerrit-Attention: Daniel Murphy <dmu...@chromium.org>
        Gerrit-Attention: Magdalena Skarbińska <mskar...@google.com>
        Gerrit-Comment-Date: Sat, 27 Jun 2026 00:22:10 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Magdalena Skarbińska (Gerrit)

        unread,
        4:58 AM (15 hours ago) 4:58 AM
        to Daniel Murphy, Kunjan Patel, Chromium Web Applications Reviews, Xiaoling Bao, Andrew Rayskiy, Edman Anjos, James Maclean, Mark Schillaci, Kevin McNee, Chromium Metrics Reviews, (Julie)Jeongeun Kim, Rijubrata Bhaumik, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Chromium LUCI CQ, ios-r...@chromium.org, ios-revie...@chromium.org, josiah...@chromium.org, yuzo+...@chromium.org, francisjp...@google.com, nektar...@chromium.org, abigailbk...@google.com, blink-...@chromium.org, michaelchec...@google.com, dtseng...@chromium.org, jdonnel...@chromium.org, extension...@chromium.org, marq+...@chromium.org, omnibox-...@chromium.org, android-web...@chromium.org, chromium-a...@chromium.org, devtools...@chromium.org, yongshun+...@google.com, christia...@chromium.org, kyungjunle...@google.com, dewitt...@chromium.org, asvitkine...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, chfreme...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, chromeos-kio...@google.com, aixba+wat...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, droger+w...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, rmcelra...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
        Attention needed from Daniel Murphy and Xiaoling Bao

        Magdalena Skarbińska added 1 comment

        File chrome/browser/ui/webui/web_app_internals/iwa_internals_handler.cc
        Line 39, Patchset 37:#include "components/webapps/isolated_web_apps/key_distribution/iwa_key_distribution_info_provider.h"
        Andrew Rayskiy . resolved

        I believe this is not needed here anymore?

        Magdalena Skarbińska

        Done

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Daniel Murphy
        • Xiaoling Bao
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement is not satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I4f89e9cd7a5a4013bcca3740b9011a33bf530939
          Gerrit-Change-Number: 7941934
          Gerrit-PatchSet: 38
          Gerrit-Owner: Magdalena Skarbińska <mskar...@google.com>
          Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
          Gerrit-Reviewer: Daniel Murphy <dmu...@chromium.org>
          Gerrit-Reviewer: Edman Anjos <ed...@chromium.org>
          Gerrit-Reviewer: Kunjan Patel <ks...@chromium.org>
          Gerrit-Reviewer: Magdalena Skarbińska <mskar...@google.com>
          Gerrit-Reviewer: Xiaoling Bao <xiaol...@chromium.org>
          Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
          Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
          Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
          Gerrit-CC: Chromium Web Applications Reviews <chromium-web...@google.com>
          Gerrit-CC: James Maclean <wjma...@chromium.org>
          Gerrit-CC: Kevin McNee <mc...@chromium.org>
          Gerrit-CC: Mark Schillaci <mschi...@google.com>
          Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
          Gerrit-CC: gwsq
          Gerrit-Attention: Xiaoling Bao <xiaol...@chromium.org>
          Gerrit-Attention: Daniel Murphy <dmu...@chromium.org>
          Gerrit-Comment-Date: Mon, 29 Jun 2026 08:57:42 +0000
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Daniel Murphy (Gerrit)

          unread,
          5:19 PM (3 hours ago) 5:19 PM
          to Magdalena Skarbińska, Daniel Murphy, Kunjan Patel, Chromium Web Applications Reviews, Xiaoling Bao, Andrew Rayskiy, Edman Anjos, James Maclean, Mark Schillaci, Kevin McNee, Chromium Metrics Reviews, (Julie)Jeongeun Kim, Rijubrata Bhaumik, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Chromium LUCI CQ, ios-r...@chromium.org, ios-revie...@chromium.org, josiah...@chromium.org, yuzo+...@chromium.org, francisjp...@google.com, nektar...@chromium.org, abigailbk...@google.com, blink-...@chromium.org, michaelchec...@google.com, dtseng...@chromium.org, jdonnel...@chromium.org, extension...@chromium.org, marq+...@chromium.org, omnibox-...@chromium.org, android-web...@chromium.org, chromium-a...@chromium.org, devtools...@chromium.org, yongshun+...@google.com, christia...@chromium.org, kyungjunle...@google.com, dewitt...@chromium.org, asvitkine...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, chfreme...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, chromeos-kio...@google.com, aixba+wat...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, droger+w...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, rmcelra...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
          Attention needed from Magdalena Skarbińska and Xiaoling Bao

          Daniel Murphy voted Code-Review+1

          Code-Review+1
          Open in Gerrit

          Related details

          Attention is currently required from:
          • Magdalena Skarbińska
          • Xiaoling Bao
          Gerrit-Attention: Magdalena Skarbińska <mskar...@google.com>
          Gerrit-Comment-Date: Mon, 29 Jun 2026 21:19:06 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Xiaoling Bao (Gerrit)

          unread,
          6:27 PM (2 hours ago) 6:27 PM
          to Magdalena Skarbińska, Daniel Murphy, Kunjan Patel, Chromium Web Applications Reviews, Andrew Rayskiy, Edman Anjos, James Maclean, Mark Schillaci, Kevin McNee, Chromium Metrics Reviews, (Julie)Jeongeun Kim, Rijubrata Bhaumik, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Chromium LUCI CQ, ios-r...@chromium.org, ios-revie...@chromium.org, josiah...@chromium.org, yuzo+...@chromium.org, francisjp...@google.com, nektar...@chromium.org, abigailbk...@google.com, blink-...@chromium.org, michaelchec...@google.com, dtseng...@chromium.org, jdonnel...@chromium.org, extension...@chromium.org, marq+...@chromium.org, omnibox-...@chromium.org, android-web...@chromium.org, chromium-a...@chromium.org, devtools...@chromium.org, yongshun+...@google.com, christia...@chromium.org, kyungjunle...@google.com, dewitt...@chromium.org, asvitkine...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, chfreme...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, chromeos-kio...@google.com, aixba+wat...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, droger+w...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, rmcelra...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
          Attention needed from Magdalena Skarbińska

          Xiaoling Bao voted Code-Review+1

          Code-Review+1
          Open in Gerrit

          Related details

          Attention is currently required from:
          • Magdalena Skarbińska
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          Gerrit-Attention: Magdalena Skarbińska <mskar...@google.com>
          Gerrit-Comment-Date: Mon, 29 Jun 2026 22:27:40 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy
          Reply all
          Reply to author
          Forward
          0 new messages