[UrlIndex] Make the MemoryPressureListener async [chromium/src : main]

0 views
Skip to first unread message

Patrick Monette (Gerrit)

unread,
Sep 18, 2025, 11:11:57 AM (2 days ago) Sep 18
to Mark Foltz, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org
Attention needed from Mark Foltz

Patrick Monette voted and added 1 comment

Votes added by Patrick Monette

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Patrick Monette . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Mark Foltz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I360257e62e52de20480cf87eb72809bf8151ba47
Gerrit-Change-Number: 6966556
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Monette <pmon...@chromium.org>
Gerrit-Reviewer: Mark Foltz <mfo...@chromium.org>
Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
Gerrit-Attention: Mark Foltz <mfo...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Sep 2025 15:11:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Patrick Monette (Gerrit)

unread,
Sep 19, 2025, 1:03:19 PM (19 hours ago) Sep 19
to Mark Foltz, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org
Attention needed from Mark Foltz

Patrick Monette added 1 comment

Patchset-level comments
Patrick Monette . resolved

@Mark friendly ping

Open in Gerrit

Related details

Attention is currently required from:
  • Mark Foltz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I360257e62e52de20480cf87eb72809bf8151ba47
Gerrit-Change-Number: 6966556
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Monette <pmon...@chromium.org>
Gerrit-Reviewer: Mark Foltz <mfo...@chromium.org>
Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
Gerrit-Attention: Mark Foltz <mfo...@chromium.org>
Gerrit-Comment-Date: Fri, 19 Sep 2025 17:03:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Mark Foltz (Gerrit)

unread,
Sep 19, 2025, 1:52:38 PM (19 hours ago) Sep 19
to Patrick Monette, Mark Foltz, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org
Attention needed from Patrick Monette

Mark Foltz voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Patrick Monette
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I360257e62e52de20480cf87eb72809bf8151ba47
Gerrit-Change-Number: 6966556
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Monette <pmon...@chromium.org>
Gerrit-Reviewer: Mark Foltz <mfo...@chromium.org>
Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
Gerrit-Attention: Patrick Monette <pmon...@chromium.org>
Gerrit-Comment-Date: Fri, 19 Sep 2025 17:52:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Sep 19, 2025, 3:09:09 PM (17 hours ago) Sep 19
to Patrick Monette, Mark Foltz, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[UrlIndex] Make the MemoryPressureListener async

In the future, MemoryPressureListener will be migrated to be
synchronously invoked on the main thread. Migrating the one in UrlIndex
should be technically possible, as it lives on the renderer's main
thread, but --single-process mode breaks that assumption.

This change is a no-op, as all MemoryPressureListeners are currently
async.
Bug: 436324601
Change-Id: I360257e62e52de20480cf87eb72809bf8151ba47
Auto-Submit: Patrick Monette <pmon...@chromium.org>
Commit-Queue: Mark Foltz <mfo...@chromium.org>
Reviewed-by: Mark Foltz <mfo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1518107}
Files:
  • M third_party/blink/renderer/platform/media/url_index.h
Change size: XS
Delta: 1 file changed, 3 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Mark Foltz
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I360257e62e52de20480cf87eb72809bf8151ba47
Gerrit-Change-Number: 6966556
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Monette <pmon...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Mark Foltz <mfo...@chromium.org>
Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages