Add @JniType to a batch of files in //components (#2) [chromium/src : main]

0 views
Skip to first unread message

Andrew Grieve (Gerrit)

unread,
Mar 11, 2026, 9:19:23 AMMar 11
to Andrew Grieve, Peter Wen, Peter Beverloo, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, mfoltz+wa...@chromium.org, feature-me...@chromium.org, chrome-tab-group-en...@google.com, dibyapal+wa...@chromium.org, christia...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Peter Wen

Andrew Grieve voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Peter Wen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4192976c00285aaef77e42e89213d40af7d5782b
Gerrit-Change-Number: 7650895
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Peter Wen <wn...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-Attention: Peter Wen <wn...@chromium.org>
Gerrit-Comment-Date: Wed, 11 Mar 2026 13:19:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Peter Wen (Gerrit)

unread,
Mar 11, 2026, 10:40:42 AMMar 11
to Andrew Grieve, Peter Beverloo, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, mfoltz+wa...@chromium.org, feature-me...@chromium.org, chrome-tab-group-en...@google.com, dibyapal+wa...@chromium.org, christia...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Andrew Grieve

Peter Wen voted and added 3 comments

Votes added by Peter Wen

Code-Review+1

3 comments

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Peter Wen . resolved

lgtm % comments

File components/permissions/android/bluetooth_chooser_android.h
Line 58, Patchset 6 (Latest): content::BluetoothChooserEvent event_type,
Peter Wen . unresolved

nit: also rename to event

File components/permissions/android/java/src/org/chromium/components/permissions/BluetoothChooserDialog.java
Line 544, Patchset 6 (Latest): String deviceId);
Peter Wen . unresolved

Do we want this to be @JniType("std::string") too?

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Grieve
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4192976c00285aaef77e42e89213d40af7d5782b
    Gerrit-Change-Number: 7650895
    Gerrit-PatchSet: 6
    Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Peter Wen <wn...@chromium.org>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
    Gerrit-Comment-Date: Wed, 11 Mar 2026 14:40:32 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Andrew Grieve (Gerrit)

    unread,
    Mar 11, 2026, 2:07:22 PMMar 11
    to Andrew Grieve, Peter Wen, Peter Beverloo, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, mfoltz+wa...@chromium.org, feature-me...@chromium.org, chrome-tab-group-en...@google.com, dibyapal+wa...@chromium.org, christia...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org

    Andrew Grieve voted and added 2 comments

    Votes added by Andrew Grieve

    Commit-Queue+2
    Owners-Override+1

    2 comments

    File components/permissions/android/bluetooth_chooser_android.h
    Line 58, Patchset 6: content::BluetoothChooserEvent event_type,
    Peter Wen . resolved

    nit: also rename to event

    Andrew Grieve

    Done

    File components/permissions/android/java/src/org/chromium/components/permissions/BluetoothChooserDialog.java
    Line 544, Patchset 6: String deviceId);
    Peter Wen . resolved

    Do we want this to be @JniType("std::string") too?

    Andrew Grieve

    I at first thought no, since the param is not used depending on the type, but then figured it's small anyways, so did in the follow-up.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4192976c00285aaef77e42e89213d40af7d5782b
    Gerrit-Change-Number: 7650895
    Gerrit-PatchSet: 7
    Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Peter Wen <wn...@chromium.org>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-Comment-Date: Wed, 11 Mar 2026 18:07:14 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Peter Wen <wn...@chromium.org>
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Mar 11, 2026, 3:40:27 PMMar 11
    to Andrew Grieve, Peter Wen, Peter Beverloo, AyeAye, chromium...@chromium.org, mfoltz+wa...@chromium.org, feature-me...@chromium.org, chrome-tab-group-en...@google.com, dibyapal+wa...@chromium.org, christia...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org

    Chromium LUCI CQ submitted the change with unreviewed changes

    Unreviewed changes

    6 is the latest approved patch-set.
    The change was submitted with unreviewed changes in the following files:

    ```
    The name of the file: components/permissions/android/bluetooth_chooser_android.h
    Insertions: 1, Deletions: 1.

    @@ -55,7 +55,7 @@
     
       // Report the dialog's result.
       void OnDialogFinished(JNIEnv* env,
    -                        content::BluetoothChooserEvent event_type,
    +                        content::BluetoothChooserEvent event,
                             const base::android::JavaRef<jstring>& device_id);
     
       // Notify bluetooth stack that the search needs to be re-issued.
    ```

    Change information

    Commit message:
    Add @JniType to a batch of files in //components (#2)
    Bug: 491444984
    Change-Id: I4192976c00285aaef77e42e89213d40af7d5782b
    Cq-Include-Trybots: luci.chrome.try:android-internal-dbg,android-internal-binary-size
    Commit-Queue: Andrew Grieve <agr...@chromium.org>
    Reviewed-by: Peter Wen <wn...@chromium.org>
    Owners-Override: Andrew Grieve <agr...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1597923}
    Files:
    • M components/permissions/android/bluetooth_chooser_android.cc
    • M components/permissions/android/bluetooth_chooser_android.h
    • M components/permissions/android/bluetooth_chooser_android_unittest.cc
    • M components/permissions/android/bluetooth_scanning_prompt_android.cc
    • M components/permissions/android/bluetooth_scanning_prompt_android.h
    • M components/permissions/android/bluetooth_scanning_prompt_android_unittest.cc
    • M components/permissions/android/java/src/org/chromium/components/permissions/BluetoothChooserDialog.java
    • M components/permissions/android/java/src/org/chromium/components/permissions/BluetoothScanningPermissionDialog.java
    Change size: M
    Delta: 8 files changed, 32 insertions(+), 35 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Peter Wen
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4192976c00285aaef77e42e89213d40af7d5782b
    Gerrit-Change-Number: 7650895
    Gerrit-PatchSet: 8
    Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Peter Wen <wn...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages