Carlos Marcelo Barrera Nolasco (Gerrit)

unread,

Nov 7, 2025, 5:54:20 PMNov 7

to David Tseng, AI Code Reviewer, Chromium LUCI CQ, AyeAye, feature-me...@chromium.org, jatapiaro+wat...@google.com, lwinston+watc...@google.com, trewin...@google.com, mac-r...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from David Tseng

Carlos Marcelo Barrera Nolasco added 6 comments

Commit Message

Line 7, Patchset 2:[a11y] Prototype for improving the way we identify clickable nodes.

David Tseng . resolved

Please revise this title (it's likely no longer a prototype). Also, in the below description, add a little more detail and a link to the design.

Carlos Marcelo Barrera Nolasco

Done

Line 7, Patchset 2:[a11y] Prototype for improving the way we identify clickable nodes.

David Tseng . resolved

Please revise this title (it's likely no longer a prototype). Also, in the below description, add a little more detail and a link to the design.

Carlos Marcelo Barrera Nolasco

Done

File content/public/android/java/src/org/chromium/content/browser/accessibility/WebContentsAccessibilityImpl.java

Line 2132, Patchset 17: // TODO: Check if AccessibilityEvent.CONTENT_CHANGE_TYPE_UNDEFINED is the right type to

David Tseng . resolved

nit: TODO(accessibility): ...

Carlos Marcelo Barrera Nolasco

Done

File third_party/blink/renderer/modules/accessibility/ax_object.h

Line 1559, Patchset 17: bool use_layout_based_action_ = false;

David Tseng . resolved

nit: may help to explain what this means briefly e.g.
// When true, actions may use more expensive computations e.g. DefaultActionVerb::kClickInHitTest.
Also, we may want to name it something more like
bool use_layout_based_actions_

Carlos Marcelo Barrera Nolasco

Done

File third_party/blink/renderer/modules/accessibility/ax_object.cc

Line 7375, Patchset 17: // Mark this node dirty.

David Tseng . resolved

nit: remove this comment (it's superfluous).

Carlos Marcelo Barrera Nolasco

Done

File ui/accessibility/ax_enum_localization_util.cc

Line 35, Patchset 17: case ax::mojom::DefaultActionVerb::kClickInHitTest:

David Tseng . resolved

As discussed offline, we have a couple of choices for this and the below case. I think I prefer just NOTREACHED here and returning an empty string.

Carlos Marcelo Barrera Nolasco

Done

Open in Gerrit

Related details

Attention is currently required from:

David Tseng

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jacobo Misael Tapia (Gerrit)

unread,

Nov 7, 2025, 6:06:22 PMNov 7

to Carlos Marcelo Barrera Nolasco, David Tseng, AI Code Reviewer, Chromium LUCI CQ, AyeAye, feature-me...@chromium.org, jatapiaro+wat...@google.com, lwinston+watc...@google.com, trewin...@google.com, mac-r...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Carlos Marcelo Barrera Nolasco and David Tseng

Jacobo Misael Tapia added 5 comments

Patchset-level comments

File-level comment, Patchset 21:

Jacobo Misael Tapia . resolved

Few comments, but LGTM.

File content/public/android/java/src/org/chromium/content/browser/accessibility/WebContentsAccessibilityImpl.java

Line 2115, Patchset 21: if (ContentFeatureMap.isEnabled(ContentFeatureList.ACCESSIBILITY_DEPRECATE_TYPE_ANNOUNCE)) {

Jacobo Misael Tapia . unresolved

Nit: I have always tried to avoid nesting. Is it a god idea to have early returns to avoid nesting code? I mean, if the first if is false, we do an early return and then the same for the 2nd if.

File content/renderer/accessibility/render_accessibility_impl.cc

Line 130, Patchset 2:

Jacobo Misael Tapia . unresolved

Is this change necessary?

File third_party/blink/renderer/modules/accessibility/ax_object.cc

Line 2561, Patchset 21: CommandEventType action = html_element->GetCommandEventType(

Jacobo Misael Tapia . unresolved

What is our policy for handling this, are we allowed to either write a method here or in the CommandEventType that is something like isCommandForOrShowsPopover()?

Line 7369, Patchset 2: // Mark this node dirty.

Jacobo Misael Tapia . unresolved

Is it ok to remove this comment?

Open in Gerrit

Related details

Attention is currently required from:

Carlos Marcelo Barrera Nolasco
David Tseng

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Carlos Marcelo Barrera Nolasco (Gerrit)

unread,

Nov 10, 2025, 1:21:22 PMNov 10

to Lucas Radaelli, Gregory Dardyk, Jacobo Misael Tapia, David Tseng, AI Code Reviewer, Chromium LUCI CQ, AyeAye, feature-me...@chromium.org, jatapiaro+wat...@google.com, lwinston+watc...@google.com, trewin...@google.com, mac-r...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from David Tseng, Gregory Dardyk, Jacobo Misael Tapia and Lucas Radaelli

Carlos Marcelo Barrera Nolasco added 4 comments

File content/public/android/java/src/org/chromium/content/browser/accessibility/WebContentsAccessibilityImpl.java

Line 2115, Patchset 21: if (ContentFeatureMap.isEnabled(ContentFeatureList.ACCESSIBILITY_DEPRECATE_TYPE_ANNOUNCE)) {

Jacobo Misael Tapia . resolved

Nit: I have always tried to avoid nesting. Is it a god idea to have early returns to avoid nesting code? I mean, if the first if is false, we do an early return and then the same for the 2nd if.

Carlos Marcelo Barrera Nolasco

This code is out of scope of the current change.

File content/renderer/accessibility/render_accessibility_impl.cc

Line 130, Patchset 2:

Jacobo Misael Tapia . resolved

Is this change necessary?

Carlos Marcelo Barrera Nolasco

Good catch, was a misclick.

File third_party/blink/renderer/modules/accessibility/ax_object.cc

Line 2561, Patchset 21: CommandEventType action = html_element->GetCommandEventType(

Jacobo Misael Tapia . resolved

What is our policy for handling this, are we allowed to either write a method here or in the CommandEventType that is something like isCommandForOrShowsPopover()?

Carlos Marcelo Barrera Nolasco

This line is out of the scope of the current CL

Line 7369, Patchset 2: // Mark this node dirty.

Jacobo Misael Tapia . resolved

Is it ok to remove this comment?

Carlos Marcelo Barrera Nolasco

It is. In the previous review I was asked to remove it.

Open in Gerrit

Related details

Attention is currently required from:

David Tseng
Gregory Dardyk
Jacobo Misael Tapia
Lucas Radaelli

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

David Tseng (Gerrit)

unread,

Nov 10, 2025, 5:57:57 PMNov 10

to Carlos Marcelo Barrera Nolasco, Lucas Radaelli, Gregory Dardyk, Jacobo Misael Tapia, AI Code Reviewer, Chromium LUCI CQ, AyeAye, feature-me...@chromium.org, jatapiaro+wat...@google.com, lwinston+watc...@google.com, trewin...@google.com, mac-r...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Carlos Marcelo Barrera Nolasco, Gregory Dardyk, Jacobo Misael Tapia and Lucas Radaelli

David Tseng voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Carlos Marcelo Barrera Nolasco

Gregory Dardyk
Jacobo Misael Tapia
Lucas Radaelli

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

gwsq (Gerrit)

unread,

Nov 11, 2025, 11:24:49 AMNov 11

to Carlos Marcelo Barrera Nolasco, Chromium IPC Reviews, David Tseng, Jinsuk Kim, Avi Drissman, Lucas Radaelli, Gregory Dardyk, Jacobo Misael Tapia, AI Code Reviewer, Chromium LUCI CQ, AyeAye, feature-me...@chromium.org, jatapiaro+wat...@google.com, lwinston+watc...@google.com, trewin...@google.com, mac-r...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Avi Drissman, David Tseng, Gregory Dardyk, Jacobo Misael Tapia, Jinsuk Kim, Joe Mason, Lucas Radaelli and Nasko Oskov

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: joenot...@google.com, na...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): joenot...@google.com, na...@chromium.org

Reviewer source(s):
joenot...@google.com is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

Avi Drissman
David Tseng

Gregory Dardyk
Jacobo Misael Tapia

Jinsuk Kim
Joe Mason
Lucas Radaelli
Nasko Oskov

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Avi Drissman (Gerrit)

unread,

Nov 11, 2025, 3:25:27 PMNov 11

to Carlos Marcelo Barrera Nolasco, Avi Drissman, Chromium IPC Reviews, David Tseng, Jinsuk Kim, Lucas Radaelli, Gregory Dardyk, Jacobo Misael Tapia, AI Code Reviewer, Chromium LUCI CQ, AyeAye, feature-me...@chromium.org, jatapiaro+wat...@google.com, lwinston+watc...@google.com, trewin...@google.com, mac-r...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Carlos Marcelo Barrera Nolasco, David Tseng, Gregory Dardyk, Jacobo Misael Tapia, Jinsuk Kim, Joe Mason, Lucas Radaelli and Nasko Oskov

Avi Drissman voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Carlos Marcelo Barrera Nolasco

David Tseng
Gregory Dardyk
Jacobo Misael Tapia
Jinsuk Kim
Joe Mason
Lucas Radaelli
Nasko Oskov

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

David Tseng (Gerrit)

unread,

Nov 11, 2025, 5:03:53 PMNov 11

to Carlos Marcelo Barrera Nolasco, Avi Drissman, Chromium IPC Reviews, Jinsuk Kim, Lucas Radaelli, Gregory Dardyk, Jacobo Misael Tapia, AI Code Reviewer, Chromium LUCI CQ, AyeAye, feature-me...@chromium.org, jatapiaro+wat...@google.com, lwinston+watc...@google.com, trewin...@google.com, mac-r...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Carlos Marcelo Barrera Nolasco, Gregory Dardyk, Jacobo Misael Tapia, Jinsuk Kim, Joe Mason, Lucas Radaelli and Nasko Oskov

David Tseng voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Carlos Marcelo Barrera Nolasco

Gregory Dardyk
Jacobo Misael Tapia
Jinsuk Kim
Joe Mason
Lucas Radaelli
Nasko Oskov

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

satisfied_requirement

unsatisfied_requirement

open

diffy

gwsq (Gerrit)

unread,

Nov 11, 2025, 5:24:34 PMNov 11

to Carlos Marcelo Barrera Nolasco, Chromium IPC Reviews, David Tseng, Avi Drissman, Jinsuk Kim, Lucas Radaelli, Gregory Dardyk, Jacobo Misael Tapia, AI Code Reviewer, Chromium LUCI CQ, AyeAye, feature-me...@chromium.org, jatapiaro+wat...@google.com, lwinston+watc...@google.com, trewin...@google.com, mac-r...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Gregory Dardyk, Jacobo Misael Tapia, Jinsuk Kim, Joe Mason, Lucas Radaelli and Nasko Oskov

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: joenot...@google.com, na...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): joenot...@google.com, na...@chromium.org

Reviewer source(s):
joenot...@google.com is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

satisfied_requirement

unsatisfied_requirement

open

diffy

Lucas Radaelli (Gerrit)

unread,

Nov 12, 2025, 1:20:00 PMNov 12

to Carlos Marcelo Barrera Nolasco, Chromium IPC Reviews, David Tseng, Avi Drissman, Jinsuk Kim, Gregory Dardyk, Jacobo Misael Tapia, AI Code Reviewer, Chromium LUCI CQ, AyeAye, feature-me...@chromium.org, jatapiaro+wat...@google.com, lwinston+watc...@google.com, trewin...@google.com, mac-r...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Carlos Marcelo Barrera Nolasco, Gregory Dardyk, Jacobo Misael Tapia, Jinsuk Kim, Joe Mason and Nasko Oskov

Lucas Radaelli added 3 comments

Commit Message

Line 17, Patchset 24 (Latest):Design doc: http://goto.google.com/chrome-request-layout-based-actions

Lucas Radaelli . unresolved

nit: we avoid using go links in change descriptions.

File content/browser/accessibility/browser_accessibility_android.cc

Line 2310, Patchset 24 (Latest): auto default_action_verb = GetData().GetDefaultActionVerb();

Lucas Radaelli . unresolved

nit: const

File content/public/android/java/src/org/chromium/content/browser/accessibility/WebContentsAccessibilityImpl.java

Line 2132, Patchset 24 (Latest): // TODO(accessibility): Check if AccessibilityEvent.CONTENT_CHANGE_TYPE_UNDEFINED is

Lucas Radaelli . unresolved

nit: please file as crbug.com/xxx and with an appropriate bug instead of just todo(accessibility)

Open in Gerrit

Related details

Attention is currently required from:

Carlos Marcelo Barrera Nolasco

Gregory Dardyk
Jacobo Misael Tapia
Jinsuk Kim
Joe Mason

Nasko Oskov

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jinsuk Kim (Gerrit)

unread,

Nov 12, 2025, 5:23:40 PMNov 12

to Carlos Marcelo Barrera Nolasco, Chromium IPC Reviews, David Tseng, Avi Drissman, Lucas Radaelli, Gregory Dardyk, Jacobo Misael Tapia, AI Code Reviewer, Chromium LUCI CQ, AyeAye, feature-me...@chromium.org, jatapiaro+wat...@google.com, lwinston+watc...@google.com, trewin...@google.com, mac-r...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Carlos Marcelo Barrera Nolasco, Gregory Dardyk, Jacobo Misael Tapia, Joe Mason and Nasko Oskov

Jinsuk Kim added 1 comment

Patchset-level comments

File-level comment, Patchset 24 (Latest):

Jinsuk Kim . resolved

Removing myself as all the changes were already covered.

Open in Gerrit

Related details

Attention is currently required from:

Carlos Marcelo Barrera Nolasco
Gregory Dardyk
Jacobo Misael Tapia

Joe Mason
Nasko Oskov

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nasko Oskov (Gerrit)

unread,

Nov 12, 2025, 6:09:43 PMNov 12

to Carlos Marcelo Barrera Nolasco, Chromium IPC Reviews, David Tseng, Avi Drissman, Lucas Radaelli, Gregory Dardyk, Jacobo Misael Tapia, AI Code Reviewer, Chromium LUCI CQ, AyeAye, feature-me...@chromium.org, jatapiaro+wat...@google.com, lwinston+watc...@google.com, trewin...@google.com, mac-r...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Carlos Marcelo Barrera Nolasco, Gregory Dardyk, Jacobo Misael Tapia and Joe Mason

Nasko Oskov voted and added 1 comment

Votes added by Nasko Oskov

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 24 (Latest):

Nasko Oskov . resolved

IPC bits LGTM

Open in Gerrit

Related details

Attention is currently required from:

Carlos Marcelo Barrera Nolasco
Gregory Dardyk
Jacobo Misael Tapia
Joe Mason

Submit Requirements:

Code-Coverage
Code-Owners

satisfied_requirement

unsatisfied_requirement

open

diffy

Joe Mason (Gerrit)

unread,

Nov 13, 2025, 10:20:33 AMNov 13

to Carlos Marcelo Barrera Nolasco, Chromium IPC Reviews, David Tseng, Avi Drissman, Lucas Radaelli, Gregory Dardyk, Jacobo Misael Tapia, AI Code Reviewer, Chromium LUCI CQ, AyeAye, feature-me...@chromium.org, jatapiaro+wat...@google.com, lwinston+watc...@google.com, trewin...@google.com, mac-r...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Carlos Marcelo Barrera Nolasco, Gregory Dardyk and Jacobo Misael Tapia

Joe Mason voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Carlos Marcelo Barrera Nolasco
Gregory Dardyk
Jacobo Misael Tapia

satisfied_requirement

unsatisfied_requirement

open

diffy

Carlos Marcelo Barrera Nolasco (Gerrit)

unread,

Nov 13, 2025, 10:27:52 PMNov 13

to Chromium IPC Reviews, David Tseng, Avi Drissman, Lucas Radaelli, Gregory Dardyk, Jacobo Misael Tapia, AI Code Reviewer, Chromium LUCI CQ, AyeAye, feature-me...@chromium.org, jatapiaro+wat...@google.com, lwinston+watc...@google.com, trewin...@google.com, mac-r...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Carlos Marcelo Barrera Nolasco added 3 comments

Commit Message

Line 17, Patchset 24:Design doc: http://goto.google.com/chrome-request-layout-based-actions

Lucas Radaelli . resolved

nit: we avoid using go links in change descriptions.

Carlos Marcelo Barrera Nolasco

Done

File content/browser/accessibility/browser_accessibility_android.cc

Line 2310, Patchset 24: auto default_action_verb = GetData().GetDefaultActionVerb();

Lucas Radaelli . resolved

nit: const

Carlos Marcelo Barrera Nolasco

Done

File content/public/android/java/src/org/chromium/content/browser/accessibility/WebContentsAccessibilityImpl.java

Line 2132, Patchset 24: // TODO(accessibility): Check if AccessibilityEvent.CONTENT_CHANGE_TYPE_UNDEFINED is

Lucas Radaelli . resolved

nit: please file as crbug.com/xxx and with an appropriate bug instead of just todo(accessibility)

Carlos Marcelo Barrera Nolasco

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Avi Drissman (Gerrit)

unread,

Nov 14, 2025, 11:10:21 AMNov 14

to Carlos Marcelo Barrera Nolasco, Avi Drissman, Chromium IPC Reviews, David Tseng, Lucas Radaelli, Gregory Dardyk, Jacobo Misael Tapia, AI Code Reviewer, Chromium LUCI CQ, AyeAye, feature-me...@chromium.org, jatapiaro+wat...@google.com, lwinston+watc...@google.com, trewin...@google.com, mac-r...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Carlos Marcelo Barrera Nolasco, David Tseng, Joe Mason and Nasko Oskov

Avi Drissman voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Carlos Marcelo Barrera Nolasco
David Tseng
Joe Mason
Nasko Oskov

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Joe Mason (Gerrit)

unread,

Nov 14, 2025, 2:00:22 PMNov 14

to Carlos Marcelo Barrera Nolasco, Avi Drissman, Chromium IPC Reviews, David Tseng, Lucas Radaelli, Gregory Dardyk, Jacobo Misael Tapia, AI Code Reviewer, Chromium LUCI CQ, AyeAye, feature-me...@chromium.org, jatapiaro+wat...@google.com, lwinston+watc...@google.com, trewin...@google.com, mac-r...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Carlos Marcelo Barrera Nolasco, David Tseng and Nasko Oskov

Joe Mason voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Carlos Marcelo Barrera Nolasco
David Tseng

Nasko Oskov

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

satisfied_requirement

open

diffy

David Tseng (Gerrit)

unread,

Nov 14, 2025, 3:13:38 PMNov 14

to Carlos Marcelo Barrera Nolasco, Avi Drissman, Chromium IPC Reviews, Lucas Radaelli, Gregory Dardyk, Jacobo Misael Tapia, AI Code Reviewer, Chromium LUCI CQ, AyeAye, feature-me...@chromium.org, jatapiaro+wat...@google.com, lwinston+watc...@google.com, trewin...@google.com, mac-r...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Carlos Marcelo Barrera Nolasco and Nasko Oskov

David Tseng voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Carlos Marcelo Barrera Nolasco
Nasko Oskov

satisfied_requirement

open

diffy

Carlos Marcelo Barrera Nolasco (Gerrit)

unread,

Nov 18, 2025, 12:04:20 PMNov 18

to David Tseng, Avi Drissman, Chromium IPC Reviews, Lucas Radaelli, Gregory Dardyk, Jacobo Misael Tapia, AI Code Reviewer, Chromium LUCI CQ, AyeAye, feature-me...@chromium.org, jatapiaro+wat...@google.com, lwinston+watc...@google.com, trewin...@google.com, mac-r...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Nasko Oskov

Carlos Marcelo Barrera Nolasco voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Nasko Oskov

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Nov 18, 2025, 1:27:23 PMNov 18

to Carlos Marcelo Barrera Nolasco, David Tseng, Avi Drissman, Chromium IPC Reviews, Lucas Radaelli, Gregory Dardyk, Jacobo Misael Tapia, AI Code Reviewer, AyeAye, feature-me...@chromium.org, jatapiaro+wat...@google.com, lwinston+watc...@google.com, trewin...@google.com, mac-r...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[a11y] New API for requesting layout based clickability.

This CL introduces a more accurate layout-based computation of
clickability, reducing the number of elements considered clickable.
Since this calculation is resource-expensive, a new key is introduced
that is used on-demand within the `requestExtraData` method in the
Android Accessibility Framework, so that any service can request this
information when strictly necessary.

Bug: 443280446
Design doc: http://goto.google.com/chrome-request-layout-based-actions

Change-Id: Ifeff75fb02da81d4bef14fa83b13aedbc9c2698e

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7108303

Reviewed-by: Joe Mason <joenot...@google.com>

Reviewed-by: Avi Drissman <a...@chromium.org>

Reviewed-by: David Tseng <dts...@chromium.org>

Commit-Queue: Carlos Marcelo Barrera Nolasco <carlos...@google.com>

Cr-Commit-Position: refs/heads/main@{#1546661}

Files:

M chrome/browser/accessibility/media_app/ax_media_app_untrusted_service.cc
M chrome/renderer/accessibility/read_anything/read_anything_app_model.cc
M content/browser/accessibility/browser_accessibility_android.cc
M content/browser/accessibility/browser_accessibility_android.h
M content/browser/accessibility/browser_accessibility_manager_android.cc
M content/browser/accessibility/web_contents_accessibility_android.cc
M content/browser/accessibility/web_contents_accessibility_android.h
M content/browser/android/content_feature_map.cc
M content/public/android/java/src/org/chromium/content/browser/accessibility/AccessibilityNodeInfoBuilder.java
M content/public/android/java/src/org/chromium/content/browser/accessibility/WebContentsAccessibilityImpl.java
M content/public/common/content_features.cc
M content/public/common/content_features.h
M content/renderer/accessibility/render_accessibility_impl.cc
M extensions/browser/api/automation_internal/automation_internal_api.cc
M extensions/common/api/automation.idl
M third_party/blink/renderer/modules/accessibility/ax_object.cc
M third_party/blink/renderer/modules/accessibility/ax_object.h
M ui/accessibility/ax_enum_localization_util.cc
M ui/accessibility/ax_enum_util.cc
M ui/accessibility/ax_enums.mojom
M ui/accessibility/ax_event_generator.cc
M ui/accessibility/ax_event_generator.h
M ui/accessibility/ax_node_data.cc
M ui/accessibility/platform/automation/automation_api_util.cc
M ui/accessibility/platform/browser_accessibility_manager_auralinux.cc
M ui/accessibility/platform/browser_accessibility_manager_mac.mm
M ui/accessibility/platform/browser_accessibility_manager_win.cc

Change size: M

Delta: 27 files changed, 176 insertions(+), 8 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Avi Drissman, +1 by Joe Mason, +1 by David Tseng

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[a11y] New API for requesting layout based clickability. [chromium/src : main]

Carlos Marcelo Barrera Nolasco (Gerrit)

Carlos Marcelo Barrera Nolasco added 6 comments

Related details

Jacobo Misael Tapia (Gerrit)

Jacobo Misael Tapia added 5 comments

Related details

Carlos Marcelo Barrera Nolasco (Gerrit)

Carlos Marcelo Barrera Nolasco added 4 comments

Related details

David Tseng (Gerrit)

David Tseng voted Code-Review+1

Related details

gwsq (Gerrit)

Message from gwsq

Related details

Avi Drissman (Gerrit)

Avi Drissman voted Code-Review+1

Related details

David Tseng (Gerrit)

David Tseng voted Code-Review+1

Related details

gwsq (Gerrit)

Message from gwsq

Related details

Lucas Radaelli (Gerrit)

Lucas Radaelli added 3 comments

Related details

Jinsuk Kim (Gerrit)

Jinsuk Kim added 1 comment

Related details

Nasko Oskov (Gerrit)

Nasko Oskov voted and added 1 comment

Votes added by Nasko Oskov

1 comment

Related details

Joe Mason (Gerrit)

Joe Mason voted Code-Review+1

Related details

Carlos Marcelo Barrera Nolasco (Gerrit)

Carlos Marcelo Barrera Nolasco added 3 comments

Related details

Avi Drissman (Gerrit)

Avi Drissman voted Code-Review+1

Related details

Joe Mason (Gerrit)

Joe Mason voted Code-Review+1

Related details

David Tseng (Gerrit)

David Tseng voted Code-Review+1

Related details

Carlos Marcelo Barrera Nolasco (Gerrit)

Carlos Marcelo Barrera Nolasco voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information