[iOS] Check URL validity before pinning it [chromium/src : main]
0 views
Skip to first unread message
Ginny Huang (Gerrit)
9:49 AM (4 hours ago) 9:49 AM
to Eric Ekey, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Eric Ekey
Ginny Huang voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Eric Ekey
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ginny Huang (Gerrit)
9:52 AM (4 hours ago) 9:52 AM
to Chromium LUCI CQ, Eric Ekey, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Eric Ekey
Ginny Huang voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Eric Ekey
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eric Ekey (Gerrit)
10:01 AM (4 hours ago) 10:01 AM
to Ginny Huang, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Ginny Huang
Eric Ekey voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Ginny Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
10:54 AM (3 hours ago) 10:54 AM
to Ginny Huang, Eric Ekey, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Check URL validity before pinning it
We used to rely on `CustomLinksManager` to detect URL validity, but it
doesn't distinguish invalid URLs from duplicate URLs, and will lead to
showing a wrong error message. Fixing that by checking URL validity
before sending it to custom links manager.
Fixed: 490025231
Change-Id: I86d9b85ed3ca2ec2a0d708202c2df21adc5d7a4d
Reviewed-by: Eric Ekey <eric...@google.com>
Auto-Submit: Ginny Huang <ginny...@chromium.org>
Commit-Queue: Eric Ekey <eric...@google.com>
Commit-Queue: Ginny Huang <ginny...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1594689}
Files:
- M ios/chrome/browser/content_suggestions/most_visited_tiles/coordinator/most_visited_tiles_mediator.mm
Change size: XS
Delta: 1 file changed, 2 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Eric Ekey
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages