Update the ABR algorithm for the native HLS player [chromium/src : main]
Ted (Chromium) Meyer (Gerrit)
Ted (Chromium) Meyer voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ted (Chromium) Meyer
| Commit-Queue | +1 |
1 comment
A spreadsheet of ABR ideas and graphs and what not.
Related details
- Syed AbuTalib
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Syed AbuTalib (Gerrit)
Syed AbuTalib voted Code-Review+1![]( "Open in Gerrit")
- Ted (Chromium) Meyer
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Dale Curtis added 7 comments![]( "Open in Gerrit")
FixedAbrAlgorithm(uint64_t network_bps);Please fix this WARNING reported by ClangTidy: check: google-explicit-constructor
single-argument constructors must be marked ...
check: google-explicit-constructor
single-argument constructors must be marked explicit to avoid unintentional implicit conversions (https://clang.llvm.org/extra/clang-tidy/checks/google/explicit-constructor.html)
(Note: You can add `Skip-Clang-Tidy-Checks: google-explicit-constructor` footer to the CL description to skip the check)
(Lint observed on `android-clang-tidy-rel`, but not on `linux-clang-tidy-rel`)
FixedAbrAlgorithm(uint64_t network_bps);Please fix this WARNING reported by ClangTidy: check: google-explicit-constructor
single-argument constructors must be marked ...
check: google-explicit-constructor
single-argument constructors must be marked explicit to avoid unintentional implicit conversions (https://clang.llvm.org/extra/clang-tidy/checks/google/explicit-constructor.html)
(Note: You can add `Skip-Clang-Tidy-Checks: google-explicit-constructor` footer to the CL description to skip the check)
(Lint observed on `linux-clang-tidy-rel`, but not on `android-clang-tidy-rel`)
class MEDIA_EXPORT EwmaAbrAlgorithm : public ABRAlgorithm {Probably you want to use the base:: classes for calculating this?
class MEDIA_EXPORT ABRAlgorithm {Needs more docs
EwmaAbrAlgorithm::EwmaAbrAlgorithm() {}Please fix this WARNING reported by ClangTidy: check: modernize-use-equals-default
use '= default' to define a trivial default...
check: modernize-use-equals-default
use '= default' to define a trivial default constructor (https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-equals-default.html)
(Note: You can add `Skip-Clang-Tidy-Checks: modernize-use-equals-default` footer to the CL description to skip the check)
(Lint observed on `android-clang-tidy-rel`, but not on `linux-clang-tidy-rel`)
EwmaAbrAlgorithm::EwmaAbrAlgorithm() {}Please fix this WARNING reported by ClangTidy: check: modernize-use-equals-default
use '= default' to define a trivial default...
check: modernize-use-equals-default
use '= default' to define a trivial default constructor (https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-equals-default.html)
(Note: You can add `Skip-Clang-Tidy-Checks: modernize-use-equals-default` footer to the CL description to skip the check)
(Lint observed on `linux-clang-tidy-rel`, but not on `android-clang-tidy-rel`)
Related details
- Ted (Chromium) Meyer
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ted (Chromium) Meyer (Gerrit)
Ted (Chromium) Meyer added 6 comments![]( "Open in Gerrit")
FixedAbrAlgorithm(uint64_t network_bps);Please fix this WARNING reported by ClangTidy: check: google-explicit-constructor
single-argument constructors must be marked ...
check: google-explicit-constructor
single-argument constructors must be marked explicit to avoid unintentional implicit conversions (https://clang.llvm.org/extra/clang-tidy/checks/google/explicit-constructor.html)
(Note: You can add `Skip-Clang-Tidy-Checks: google-explicit-constructor` footer to the CL description to skip the check)
(Lint observed on `android-clang-tidy-rel`, but not on `linux-clang-tidy-rel`)
Done
FixedAbrAlgorithm(uint64_t network_bps);Please fix this WARNING reported by ClangTidy: check: google-explicit-constructor
single-argument constructors must be marked ...
check: google-explicit-constructor
single-argument constructors must be marked explicit to avoid unintentional implicit conversions (https://clang.llvm.org/extra/clang-tidy/checks/google/explicit-constructor.html)
(Note: You can add `Skip-Clang-Tidy-Checks: google-explicit-constructor` footer to the CL description to skip the check)
(Lint observed on `linux-clang-tidy-rel`, but not on `android-clang-tidy-rel`)
Done
class MEDIA_EXPORT EwmaAbrAlgorithm : public ABRAlgorithm {Probably you want to use the base:: classes for calculating this?
I'm not sure which bases classes you're referring to. There's a sliding window class in there, but that's not how this one works.
class MEDIA_EXPORT ABRAlgorithm {Ted (Chromium) MeyerNeeds more docs
Done
EwmaAbrAlgorithm::EwmaAbrAlgorithm() {}Please fix this WARNING reported by ClangTidy: check: modernize-use-equals-default
use '= default' to define a trivial default...
check: modernize-use-equals-default
use '= default' to define a trivial default constructor (https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-equals-default.html)
(Note: You can add `Skip-Clang-Tidy-Checks: modernize-use-equals-default` footer to the CL description to skip the check)
(Lint observed on `linux-clang-tidy-rel`, but not on `android-clang-tidy-rel`)
Done
EwmaAbrAlgorithm::EwmaAbrAlgorithm() {}Please fix this WARNING reported by ClangTidy: check: modernize-use-equals-default
use '= default' to define a trivial default...
check: modernize-use-equals-default
use '= default' to define a trivial default constructor (https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-equals-default.html)
(Note: You can add `Skip-Clang-Tidy-Checks: modernize-use-equals-default` footer to the CL description to skip the check)
(Lint observed on `android-clang-tidy-rel`, but not on `linux-clang-tidy-rel`)
- Dale Curtis
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ted (Chromium) Meyer (Gerrit)
Ted (Chromium) Meyer added 1 comment![]( "Open in Gerrit")
Oh, and if anyone is interested, here are some weird experiments I did when coming up with numbers for the EWMA: https://docs.google.com/spreadsheets/d/15SQjRVGgzDyx3Uj_ObZ7IRZpXh0VdPgRvsJq1PYcnCM/edit?usp=sharing
Related details
- Dale Curtis
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ted (Chromium) Meyer (Gerrit)
Ted (Chromium) Meyer voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
- Dale Curtis
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Dale Curtis added 1 comment![]( "Open in Gerrit")
class MEDIA_EXPORT EwmaAbrAlgorithm : public ABRAlgorithm {Ted (Chromium) MeyerProbably you want to use the base:: classes for calculating this?
I'm not sure which bases classes you're referring to. There's a sliding window class in there, but that's not how this one works.
Yes, I was referring to https://source.chromium.org/chromium/chromium/src/+/main:base/moving_window.h since that seemed like what you'd want here
Related details
- Ted (Chromium) Meyer
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ted (Chromium) Meyer (Gerrit)
Ted (Chromium) Meyer voted![]( "Open in Gerrit")
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Update the ABR algorithm for the native HLS player
This one is fairly simple - I tried modeling out more complex things but
couldn't find anything that was both computationly light (IE, no sliding
windows, sigmoids, standard deviations, etc), and which also did a good
job at scaling up slowly, down quickly, but avoided thrashing on network
jitter. This algorithm can at least meet the first two requirements, and
is very simple.
The tests all have to be tweaked, because we now start at low bit rates
and scale up.
- M media/filters/hls_manifest_demuxer_engine_unittest.cc
- M media/formats/BUILD.gn
- A media/formats/hls/abr_algorithm.cc
- A media/formats/hls/abr_algorithm.h
- A media/formats/hls/abr_algorithm_unittest.cc
- M media/formats/hls/rendition_manager.cc
- M media/formats/hls/rendition_manager.h
- M media/formats/hls/rendition_manager_unittest.cc
Code-Review: +1 by Syed AbuTalib, +1 by Ted (Chromium) Meyer
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |