[Autofill] Move temporarily-parked includes to the right files [chromium/src : main]

0 views
Skip to first unread message

Christoph Schwering (Gerrit)

unread,
May 15, 2026, 7:51:35 AM (3 days ago) May 15
to Stephen McGruer, Vidhan Jain, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, sloboda...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Stephen McGruer and Vidhan Jain

Christoph Schwering added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Christoph Schwering . resolved

Stephen PTAL at components/payments/core/payments_profile_comparator_unittest.cc

Open in Gerrit

Related details

Attention is currently required from:
  • Stephen McGruer
  • Vidhan Jain
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I138fa75fe195990cd8799a388deb9507c34f7077
Gerrit-Change-Number: 7849913
Gerrit-PatchSet: 1
Gerrit-Owner: Christoph Schwering <schw...@google.com>
Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
Gerrit-Reviewer: Stephen McGruer <smcg...@chromium.org>
Gerrit-Reviewer: Vidhan Jain <vid...@google.com>
Gerrit-Attention: Vidhan Jain <vid...@google.com>
Gerrit-Attention: Stephen McGruer <smcg...@chromium.org>
Gerrit-Comment-Date: Fri, 15 May 2026 11:51:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Christoph Schwering (Gerrit)

unread,
May 15, 2026, 7:52:06 AM (3 days ago) May 15
to Sergio Collazos, Stephen McGruer, Vidhan Jain, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, sloboda...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Sergio Collazos, Stephen McGruer and Vidhan Jain

Christoph Schwering added 1 comment

Patchset-level comments
Christoph Schwering . resolved

Sergio ptal at ios/chrome/browser/infobars/model/overlays/browser_agent/interaction_handlers/test/mock_autofill_save_update_address_profile_delegate_ios.h

Open in Gerrit

Related details

Attention is currently required from:
  • Sergio Collazos
  • Stephen McGruer
  • Vidhan Jain
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I138fa75fe195990cd8799a388deb9507c34f7077
Gerrit-Change-Number: 7849913
Gerrit-PatchSet: 1
Gerrit-Owner: Christoph Schwering <schw...@google.com>
Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
Gerrit-Reviewer: Sergio Collazos <sc...@chromium.org>
Gerrit-Reviewer: Stephen McGruer <smcg...@chromium.org>
Gerrit-Reviewer: Vidhan Jain <vid...@google.com>
Gerrit-Attention: Vidhan Jain <vid...@google.com>
Gerrit-Attention: Stephen McGruer <smcg...@chromium.org>
Gerrit-Attention: Sergio Collazos <sc...@chromium.org>
Gerrit-Comment-Date: Fri, 15 May 2026 11:51:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Slobodan Pejic (Gerrit)

unread,
May 15, 2026, 10:05:52 AM (3 days ago) May 15
to Stephen McGruer, Sergio Collazos, Vidhan Jain, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, sloboda...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Sergio Collazos, Stephen McGruer and Vidhan Jain

Slobodan Pejic voted and added 1 comment

Votes added by Slobodan Pejic

Code-Review+1

1 comment

Patchset-level comments
Slobodan Pejic . resolved

LGTM for components/payments.

Open in Gerrit

Related details

Attention is currently required from:
  • Sergio Collazos
  • Stephen McGruer
  • Vidhan Jain
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I138fa75fe195990cd8799a388deb9507c34f7077
    Gerrit-Change-Number: 7849913
    Gerrit-PatchSet: 1
    Gerrit-Owner: Christoph Schwering <schw...@google.com>
    Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
    Gerrit-Reviewer: Sergio Collazos <sc...@chromium.org>
    Gerrit-Reviewer: Slobodan Pejic <slob...@chromium.org>
    Gerrit-Reviewer: Vidhan Jain <vid...@google.com>
    Gerrit-CC: Stephen McGruer <smcg...@chromium.org>
    Gerrit-Attention: Vidhan Jain <vid...@google.com>
    Gerrit-Attention: Stephen McGruer <smcg...@chromium.org>
    Gerrit-Attention: Sergio Collazos <sc...@chromium.org>
    Gerrit-Comment-Date: Fri, 15 May 2026 14:05:46 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Vidhan Jain (Gerrit)

    unread,
    6:28 AM (3 hours ago) 6:28 AM
    to Slobodan Pejic, Stephen McGruer, Sergio Collazos, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, sloboda...@chromium.org, tmartino+tran...@chromium.org
    Attention needed from Christoph Schwering, Sergio Collazos and Stephen McGruer

    Vidhan Jain voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Christoph Schwering
    • Sergio Collazos
    • Stephen McGruer
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I138fa75fe195990cd8799a388deb9507c34f7077
    Gerrit-Change-Number: 7849913
    Gerrit-PatchSet: 1
    Gerrit-Owner: Christoph Schwering <schw...@google.com>
    Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
    Gerrit-Reviewer: Sergio Collazos <sc...@chromium.org>
    Gerrit-Reviewer: Slobodan Pejic <slob...@chromium.org>
    Gerrit-Reviewer: Vidhan Jain <vid...@google.com>
    Gerrit-CC: Stephen McGruer <smcg...@chromium.org>
    Gerrit-Attention: Stephen McGruer <smcg...@chromium.org>
    Gerrit-Attention: Christoph Schwering <schw...@google.com>
    Gerrit-Attention: Sergio Collazos <sc...@chromium.org>
    Gerrit-Comment-Date: Mon, 18 May 2026 10:28:20 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages