Handle content: url() on HTMLVideoElement [chromium/src : main]
Hyowon Kim (Gerrit)
New activity on the change![]( "Open in Gerrit")
Related details
- Dale Curtis
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Dale Curtis added 1 comment![]( "Open in Gerrit")
LayoutVideo seems to have some special handling for poster images, so I suspect this may lead to weird interactions when a poster is present. Has that been considered? Since this is opt-in I guess it's not a big deal, but still want to double check.
Related details
- Hyowon Kim
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hyowon Kim (Gerrit)
Hyowon Kim added 1 comment![]( "Open in Gerrit")
LayoutVideo seems to have some special handling for poster images, so I suspect this may lead to weird interactions when a poster is present. Has that been considered? Since this is opt-in I guess it's not a big deal, but still want to double check.
Poster handling in Video only happens when LayoutVideo is created. This change creates a new LayoutObject via LayoutObject::CreateObject when content: url() is present, so the poster code path isn’t used in that case.
Also, the WPT ref (element-replacement-on-replaced-element-ref.html) covers the poster + content: url() case.
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/external/wpt/css/css-content/element-replacement-on-replaced-element-ref.html
Related details
- Dale Curtis
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Dale Curtis voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dale Curtis
| Code-Review | +1 |
1 comment
Hyowon KimLayoutVideo seems to have some special handling for poster images, so I suspect this may lead to weird interactions when a poster is present. Has that been considered? Since this is opt-in I guess it's not a big deal, but still want to double check.
Poster handling in Video only happens when LayoutVideo is created. This change creates a new LayoutObject via LayoutObject::CreateObject when content: url() is present, so the poster code path isn’t used in that case.
Also, the WPT ref (element-replacement-on-replaced-element-ref.html) covers the poster + content: url() case.
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/external/wpt/css/css-content/element-replacement-on-replaced-element-ref.html
- Hyowon Kim
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hyowon Kim (Gerrit)
Hyowon Kim voted Commit-Queue+2![]( "Open in Gerrit")
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Handle content: url() on HTMLVideoElement
HTMLVideoElement::CreateLayoutObject() ignored the CSS content property,
always returning a LayoutVideo. Add the same ImageContentData check that
HTMLImageElement already has, so that content: url() works consistently
on replaced elements.
This fixes the WPT reftest
element-replacement-on-replaced-element.tentative.html, which failed
because content: url() worked on <img> but not on <video> in the
reference file.
- M third_party/blink/renderer/core/html/media/html_video_element.cc
- M third_party/blink/web_tests/TestExpectations
Code-Review: +1 by Dale Curtis
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |